From patchwork Mon Jun 2 09:09:37 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Arnez X-Patchwork-Id: 1231 Received: (qmail 695 invoked by alias); 2 Jun 2014 09:09:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 683 invoked by uid 89); 2 Jun 2014 09:09:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e06smtp15.uk.ibm.com Received: from e06smtp15.uk.ibm.com (HELO e06smtp15.uk.ibm.com) (195.75.94.111) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 02 Jun 2014 09:09:44 +0000 Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 2 Jun 2014 10:09:40 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp15.uk.ibm.com (192.168.101.145) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 2 Jun 2014 10:09:39 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 8EC7917D8063 for ; Mon, 2 Jun 2014 10:10:56 +0100 (BST) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps4075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s5299dQN20906186 for ; Mon, 2 Jun 2014 09:09:39 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s5299ckJ012910 for ; Mon, 2 Jun 2014 03:09:38 -0600 Received: from br87z6lw.de.ibm.com (dyn-9-152-212-188.boeblingen.de.ibm.com [9.152.212.188]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id s5299bMi012844; Mon, 2 Jun 2014 03:09:37 -0600 From: Andreas Arnez To: Yao Qi Cc: Subject: Re: [PATCH 08/12] NIOS2 Linux: Fill 'collect_regset' in regset structure. References: <1401122208-2481-1-git-send-email-arnez@linux.vnet.ibm.com> <1401122208-2481-9-git-send-email-arnez@linux.vnet.ibm.com> <5383F489.1010207@codesourcery.com> Date: Mon, 02 Jun 2014 11:09:37 +0200 In-Reply-To: <5383F489.1010207@codesourcery.com> (Yao Qi's message of "Tue, 27 May 2014 10:12:25 +0800") Message-ID: <87fvjn65ke.fsf@br87z6lw.de.ibm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14060209-0342-0000-0000-000008FE0CFE X-IsSubscribed: yes On Tue, May 27 2014, Yao Qi wrote: > On 05/27/2014 12:36 AM, Andreas Arnez wrote: >> +#define NIOS2_GREGS_SIZE (4 * 31) >> + > > Is it used? No, this is needed in the follow-on patch series, but not here. Removed. >> /* Implement the supply_regset hook for core files. */ >> >> static void >> @@ -73,11 +75,26 @@ nios2_supply_gregset (const struct regset *regset, >> } >> } >> >> +static void >> +nios2_collect_gregset (const struct regset *regset, >> + const struct regcache *regcache, >> + int regnum, void *gregs_buf, size_t len) > > The comment to this function is needed, like the comment to > nios2_supply_gregset. Done. >> static const struct regset nios2_core_regset = >> { >> - NULL, >> - nios2_supply_gregset, >> - NULL, >> + NULL, nios2_supply_gregset, nios2_collect_gregset >> }; > > I'd like to put each field in one line. Otherwise, it is OK. Done. See the updated patch below. BTW, I was wondering why nios2_supply_gregset initializes the unavailable registers with zero instead of just leaving them . This special treatment is the main reason against using the new generic supply/collect functions from regcache.c, because those currently do not support initializing registers with zero. diff --git a/gdb/nios2-linux-tdep.c b/gdb/nios2-linux-tdep.c index 84ab576..0f53477 100644 --- a/gdb/nios2-linux-tdep.c +++ b/gdb/nios2-linux-tdep.c @@ -73,11 +73,30 @@ nios2_supply_gregset (const struct regset *regset, } } +/* Implement the collect_regset hook for core files. */ + +static void +nios2_collect_gregset (const struct regset *regset, + const struct regcache *regcache, + int regnum, void *gregs_buf, size_t len) +{ + gdb_byte *gregs = gregs_buf; + int regno; + + for (regno = NIOS2_Z_REGNUM; regno <= NIOS2_MPUACC_REGNUM; regno++) + if (regnum == -1 || regnum == regno) + { + if (reg_offsets[regno] != -1) + regcache_raw_collect (regcache, regno, + gregs + 4 * reg_offsets[regno]); + } +} + static const struct regset nios2_core_regset = { NULL, nios2_supply_gregset, - NULL, + nios2_collect_gregset }; /* Implement the regset_from_core_section gdbarch method. */