Message ID | 87ftmmhz7m.fsf@tromey.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 64385 invoked by alias); 31 Jul 2019 17:48:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 64377 invoked by uid 89); 31 Jul 2019 17:48:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.0 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:813 X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.146.7) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 31 Jul 2019 17:48:48 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 2BB8FE9FD for <gdb-patches@sourceware.org>; Wed, 31 Jul 2019 12:48:47 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ssiVhc7LG2qH7ssiVhe9bl; Wed, 31 Jul 2019 12:48:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=wMTHdrP4Y2+aGsUqr9jEwsJnGqUGnCEaslXIfbvzJFI=; b=w+A7CxEzDPltCvIOTUDO9mq7lj kRaCV9BsIAHlKC91wbqo+Zl5cMn6551RgApq7SHk9X1PAv0cQbaKs5Z2ZH1tF74MZlWh1K4DIPw8t gPDDCDe9gwqJH6c8ghwZWWgEm; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:40854 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from <tom@tromey.com>) id 1hssiU-002Udc-PK; Wed, 31 Jul 2019 12:48:46 -0500 From: Tom Tromey <tom@tromey.com> To: Andreas Schwab <schwab@suse.de> Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org Subject: Re: [PATCH] Don't include gdbarch.h from defs.h References: <20190614211035.398-1-tom@tromey.com> <mvmy30e71pj.fsf@suse.de> Date: Wed, 31 Jul 2019 11:48:45 -0600 In-Reply-To: <mvmy30e71pj.fsf@suse.de> (Andreas Schwab's message of "Wed, 31 Jul 2019 15:50:16 +0200") Message-ID: <87ftmmhz7m.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable |
Commit Message
Tom Tromey
July 31, 2019, 5:48 p.m. UTC
>>>>> "Andreas" == Andreas Schwab <schwab@suse.de> writes:
Andreas> In file included from ../../gdb/ia64-tdep.h:25:0,
Andreas> from ../../gdb/ia64-linux-tdep.c:21:
Andreas> ../../gdb/ia64-libunwind-tdep.h:74:11: error: ‘readable_regcache’ has not been declared
Andreas> readable_regcache *regcache,
I don't have libunwind-ia64.h, so I couldn't reproduce this locally.
Anyway, please try the appended. Maybe it will work.
thanks,
Tom
Comments
On Jul 31 2019, Tom Tromey <tom@tromey.com> wrote: >>>>>> "Andreas" == Andreas Schwab <schwab@suse.de> writes: > > Andreas> In file included from ../../gdb/ia64-tdep.h:25:0, > Andreas> from ../../gdb/ia64-linux-tdep.c:21: > Andreas> ../../gdb/ia64-libunwind-tdep.h:74:11: error: ‘readable_regcache’ has not been declared > Andreas> readable_regcache *regcache, > > I don't have libunwind-ia64.h, so I couldn't reproduce this locally. > > Anyway, please try the appended. Maybe it will work. This fixes the errors. Andreas.
diff --git a/gdb/ia64-libunwind-tdep.h b/gdb/ia64-libunwind-tdep.h index 3ad3d44f367..06a8d5463d7 100644 --- a/gdb/ia64-libunwind-tdep.h +++ b/gdb/ia64-libunwind-tdep.h @@ -36,6 +36,8 @@ struct frame_unwind; running on. */ #include "libunwind-ia64.h" +#include "gdbarch.h" + struct libunwind_descr { int (*gdb2uw) (int);