From patchwork Mon Aug 25 12:09:33 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 2524 Received: (qmail 32254 invoked by alias); 25 Aug 2014 12:13:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 32239 invoked by uid 89); 25 Aug 2014 12:13:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Aug 2014 12:13:22 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1XLt9C-0002yL-K2 from Yao_Qi@mentor.com ; Mon, 25 Aug 2014 05:13:18 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 25 Aug 2014 05:13:18 -0700 Received: from GreenOnly (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Mon, 25 Aug 2014 05:13:17 -0700 From: Yao Qi To: Pedro Alves CC: Subject: Re: [PATCH] Update comments in scan_partial_symbols and add_partial_subprogram References: <1408708971-15299-1-git-send-email-yao@codesourcery.com> <53F77297.80704@redhat.com> <87lhqegfrt.fsf@codesourcery.com> <53FB08A4.2060609@redhat.com> Date: Mon, 25 Aug 2014 20:09:33 +0800 In-Reply-To: <53FB08A4.2060609@redhat.com> (Pedro Alves's message of "Mon, 25 Aug 2014 10:57:56 +0100") Message-ID: <87egw4hite.fsf@codesourcery.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-IsSubscribed: yes Pedro Alves writes: > Hmm. I still can't parse this though. It's actually the "to the" part > that seems to miss a verb to me. Isn't a "Set" missing instead of > "are"? Like: > > that this subprogram contains. If SET_ADDRMAP is true, record the > covered ranges in the addrmap. Set *LOWPC and *HIGHPC to the lowest and > highest PC values found in PDI. Sigh, my brain stopped working! Sorry about that. Fix it as you suggested. diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index df6deef..4720198 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -7007,8 +7007,8 @@ add_partial_module (struct partial_die_info *pdi, CORE_ADDR *lowpc, symbol for that subprogram. When the CU language allows it, this routine also defines a partial symbol for each nested subprogram that this subprogram contains. If SET_ADDRMAP is true, record the - covered ranges in the addrmap. *LOWPC and *HIGHPC to the lowest and - highest PC values are found in PDI. + covered ranges in the addrmap. Set *LOWPC and *HIGHPC to the lowest + and highest PC values found in PDI. PDI may also be a lexical block, in which case we simply search recursively for subprograms defined inside that lexical block.