From patchwork Tue Sep 9 14:55:46 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabriel Krisman Bertazi X-Patchwork-Id: 2704 Received: (qmail 19683 invoked by alias); 9 Sep 2014 14:55:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 19672 invoked by uid 89); 9 Sep 2014 14:55:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.2 X-HELO: layla.krisman.be Received: from layla.krisman.be (HELO layla.krisman.be) (176.31.208.35) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 09 Sep 2014 14:55:53 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (envelope-from ) id 1XRMmR-0005ij-TJ; Tue, 09 Sep 2014 16:52:28 +0200 From: Gabriel Krisman Bertazi To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [PING] [PATCH] Fix gdb.fortran/array-element.exp failures. References: <1404453487-20108-1-git-send-email-gabriel@krisman.be> <87zjgobth0.fsf@Argo.krisman.be> <8761jbbu6l.fsf@Argo.krisman.be> <87lhrv36pm.fsf@Argo.krisman.be> <87zjf3sqrd.fsf@krisman.be> <87r4048546.fsf_-_@krisman.be> <20140909130901.GG28404@adacore.com> Date: Tue, 09 Sep 2014 11:55:46 -0300 In-Reply-To: <20140909130901.GG28404@adacore.com> (Joel Brobecker's message of "Tue, 9 Sep 2014 06:09:01 -0700") Message-ID: <87d2b4c07h.fsf@anubis.Home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-IsSubscribed: yes Joel, > To help us out, it's useful to show what the patch does in practice. > In this case, I'd like to do what's not working before the patch > gets applied, and how things change once your patch is applied. > GDB transcripts before and after usually help with that. Sorry I didn't resend the original message with my pings. Here it goes. This fixes two FAIL results when running this test file due to a misplaced "continue" command, which caused the inferior to end execution prematurely. On trunk, we have: FAIL: gdb.fortran/array-element.exp: continue to breakpoint once again (the program exited) FAIL: gdb.fortran/array-element.exp: print the second element of array a === gdb Summary === # of expected passes 3 # of unexpected failures 2 And now, we get: === gdb Summary === # of expected passes 3 Is this ok? 2014-07-04 Gabriel Krisman Bertazi * gdb.fortran/array-element.exp: Remove wrong "continue" command. Simplify test case. diff --git a/gdb/testsuite/gdb.fortran/array-element.exp b/gdb/testsuite/gdb.fortran/array-element.exp index 579db03..1ac3623 100644 --- a/gdb/testsuite/gdb.fortran/array-element.exp +++ b/gdb/testsuite/gdb.fortran/array-element.exp @@ -31,18 +31,9 @@ if ![runto sub_] then { continue } -set bp_location [gdb_get_line_number "continue"] -gdb_test "break $bp_location" \ - "Breakpoint.*at.* file .*$srcfile, line $bp_location\\." \ - "breakpoint at continue" - -gdb_test "continue" \ - "Continuing\\..*Breakpoint.*" \ - "continue to breakpoint" -gdb_test "print a(1)" ".*1 = 1.*" "print the first element of array a" +gdb_breakpoint [gdb_get_line_number "continue"] +gdb_continue_to_breakpoint "continue" -gdb_test "continue" \ - "Continuing\\..*Breakpoint.*" \ - "continue to breakpoint once again" +gdb_test "print a(1)" ".*1 = 1.*" "print the first element of array a" gdb_test "print a(2)" ".*2 = 2.*" "print the second element of array a"