From patchwork Tue Jul 17 16:00:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 28442 Received: (qmail 97343 invoked by alias); 17 Jul 2018 16:00:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 97164 invoked by uid 89); 17 Jul 2018 16:00:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 spammy=signing, macos, macOS, gui X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.133) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Jul 2018 16:00:21 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway21.websitewelcome.com (Postfix) with ESMTP id ACAD940153E52 for ; Tue, 17 Jul 2018 11:00:10 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id fSOYfbLoq79N3fSOYfxo9s; Tue, 17 Jul 2018 11:00:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=O5c32+9FbmV1gfeEnni5AY75dbuPq22XwGV/shFhv6A=; b=V3blLpHzc7RIa46GqjkloAMPFo mptsImfZyR8dOZlWedv7Ene6JOGNMgY2r4Q5Zf5+c5p4CSjMKe9YD7mv8VBO30TDTiwZ7BwXOEmE4 lLiy6lrwj1u6+rKFh8jhdCGBF; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:46854 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1ffSOY-000Onq-Ee; Tue, 17 Jul 2018 11:00:10 -0500 From: Tom Tromey To: Tom Tromey Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [RFA] Remove --disable-gdbcli and --disable-gdbmi References: <20180628172132.28843-1-tom@tromey.com> <8bebd1b1-e620-b393-bc0d-d216ca737327@redhat.com> <87h8kyyn7s.fsf@tromey.com> Date: Tue, 17 Jul 2018 10:00:09 -0600 In-Reply-To: <87h8kyyn7s.fsf@tromey.com> (Tom Tromey's message of "Tue, 17 Jul 2018 08:02:31 -0600") Message-ID: <87d0vlzwc6.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 >>>>> "Tom" == Tom Tromey writes: Tom> I just stumbled across it. I will redo it to just remove Tom> --disable-gdbcli and leave --disable-gdbmi alone. Like so. Tom commit 056dec39ed11e0027ae399018c3fef3a719718b9 Author: Tom Tromey Date: Thu Jun 28 11:19:33 2018 -0600 Remove --disable-gdbcli I think it doesn't really make sense to allow building gdb without the CLI. Perhaps at one time this was a goal, but libgdb is long gone and the CLI is intrinsic to gdb. So, this patch removes the implementation of this configure option. It is still recognized (this is autoconf's default), but does nothing. This simplifies configure.ac and Makefile.in a bit. Tested by rebuilding. gdb/ChangeLog 2018-07-17 Tom Tromey * configure.ac: Remove --disable-gdbcli. * configure: Rebuild. * Makefile.in (SUBDIR_CLI_DEPS, SUBDIR_CLI_LDFLAGS) (SUBDIR_CLI_CFLAGS): Remove. (SFILES): Use SUBDIR_CLI_SRCS. (COMMON_OBS): Use SUBDIR_CLI_OBS. diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 01c1a2501db..6f5487c10e8 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,12 @@ +2018-07-17 Tom Tromey + + * configure.ac: Remove --disable-gdbcli. + * configure: Rebuild. + * Makefile.in (SUBDIR_CLI_DEPS, SUBDIR_CLI_LDFLAGS) + (SUBDIR_CLI_CFLAGS): Remove. + (SFILES): Use SUBDIR_CLI_SRCS. + (COMMON_OBS): Use SUBDIR_CLI_OBS. + 2018-07-17 Tom Tromey PR gdb/18624: diff --git a/gdb/Makefile.in b/gdb/Makefile.in index b145e5138f4..e68aee250e2 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -253,10 +253,6 @@ SUBDIR_CLI_SRCS = \ SUBDIR_CLI_OBS = $(patsubst %.c,%.o,$(SUBDIR_CLI_SRCS)) -SUBDIR_CLI_DEPS = -SUBDIR_CLI_LDFLAGS = -SUBDIR_CLI_CFLAGS = - # # MI sub directory definitons # @@ -1160,6 +1156,7 @@ SFILES = \ symfile-mem.c \ ui-file.h \ mi/mi-common.c \ + $(SUBDIR_CLI_SRCS) \ $(SUBDIR_TARGET_SRCS) \ $(COMMON_SFILES) \ $(SUBDIR_GCC_COMPILE_SRCS) @@ -1557,6 +1554,7 @@ COMMON_OBS = $(DEPFILES) $(CONFIG_OBS) $(YYOBJ) \ version.o \ xml-builtin.o \ $(patsubst %.c,%.o,$(COMMON_SFILES)) \ + $(SUBDIR_CLI_OBS) \ $(SUBDIR_TARGET_OBS) \ $(SUBDIR_GCC_COMPILE_OBS) diff --git a/gdb/NEWS b/gdb/NEWS index 2b51465495f..76b963e2bc1 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -130,13 +130,16 @@ SH-5/SH64 running OpenBSD SH-5/SH64 support in sh*-*-openbsd* the tradeoff that there is a possibility of false hits being reported. -* New configure options +* Configure changes --enable-codesign=CERT This can be used to invoke "codesign -s CERT" after building gdb. This option is useful on macOS, where code signing is required for gdb to work properly. +--disable-gdbcli has been removed + This is now silently accepted, but does nothing. + *** Changes in GDB 8.1 * GDB now supports dynamically creating arbitrary register groups specified diff --git a/gdb/configure b/gdb/configure index 28756ed9826..3f0a22073d0 100755 --- a/gdb/configure +++ b/gdb/configure @@ -855,7 +855,6 @@ with_auto_load_dir with_auto_load_safe_path enable_targets enable_64_bit_bfd -enable_gdbcli enable_gdbmi enable_tui enable_gdbtk @@ -1547,7 +1546,6 @@ Optional Features: --enable-targets=TARGETS alternative target configurations --enable-64-bit-bfd 64-bit support (on hosts with narrower word sizes) - --disable-gdbcli disable command-line interface (CLI) --disable-gdbmi disable machine-interface (MI) --enable-tui enable full-screen terminal user interface (TUI) --enable-gdbtk enable gdbtk graphical user interface (GUI) @@ -6755,32 +6753,6 @@ _ACEOF fi -# The CLI cannot be disabled yet, but may be in the future. - -# Enable CLI. -# Check whether --enable-gdbcli was given. -if test "${enable_gdbcli+set}" = set; then : - enableval=$enable_gdbcli; case $enableval in - yes) - ;; - no) - as_fn_error $? "the command-line interface cannot be disabled yet" "$LINENO" 5 ;; - *) - as_fn_error $? "bad value $enableval for --enable-gdbcli" "$LINENO" 5 ;; - esac -else - enable_gdbcli=yes -fi - -if test x"$enable_gdbcli" = xyes; then - if test -d $srcdir/cli; then - CONFIG_OBS="$CONFIG_OBS \$(SUBDIR_CLI_OBS)" - CONFIG_DEPS="$CONFIG_DEPS \$(SUBDIR_CLI_DEPS)" - CONFIG_SRCS="$CONFIG_SRCS \$(SUBDIR_CLI_SRCS)" - ENABLE_CFLAGS="$ENABLE_CFLAGS \$(SUBDIR_CLI_CFLAGS)" - fi -fi - # Enable MI. # Check whether --enable-gdbmi was given. if test "${enable_gdbmi+set}" = set; then : diff --git a/gdb/configure.ac b/gdb/configure.ac index 4c20ea5178d..dfd38a730f4 100644 --- a/gdb/configure.ac +++ b/gdb/configure.ac @@ -299,29 +299,6 @@ if test "x$targ_defvec" != x; then [Define to BFD's default target vector. ]) fi -# The CLI cannot be disabled yet, but may be in the future. - -# Enable CLI. -AC_ARG_ENABLE(gdbcli, -AS_HELP_STRING([--disable-gdbcli], [disable command-line interface (CLI)]), - [case $enableval in - yes) - ;; - no) - AC_MSG_ERROR([the command-line interface cannot be disabled yet]) ;; - *) - AC_MSG_ERROR([bad value $enableval for --enable-gdbcli]) ;; - esac], - [enable_gdbcli=yes]) -if test x"$enable_gdbcli" = xyes; then - if test -d $srcdir/cli; then - CONFIG_OBS="$CONFIG_OBS \$(SUBDIR_CLI_OBS)" - CONFIG_DEPS="$CONFIG_DEPS \$(SUBDIR_CLI_DEPS)" - CONFIG_SRCS="$CONFIG_SRCS \$(SUBDIR_CLI_SRCS)" - ENABLE_CFLAGS="$ENABLE_CFLAGS \$(SUBDIR_CLI_CFLAGS)" - fi -fi - # Enable MI. AC_ARG_ENABLE(gdbmi, AS_HELP_STRING([--disable-gdbmi], [disable machine-interface (MI)]),