From patchwork Thu Aug 9 16:00:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 28816 Received: (qmail 129270 invoked by alias); 9 Aug 2018 16:01:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 129223 invoked by uid 89); 9 Aug 2018 16:00:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=administrator, Single X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.47.79) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Aug 2018 16:00:52 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 92E8560B86 for ; Thu, 9 Aug 2018 11:00:51 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id nnMQf3HWLbXuJnnMefS2ly; Thu, 09 Aug 2018 11:00:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mxgxzVJOigMIwTp/XKC3QJGWYxzu/8eNWAj+GGam0DQ=; b=JvAwAQxw4hpEmViySFyUfhZ2OW Q7nFvJgFw2e3iiEzeZEsB/RacUEBEwxAWn7cW1eGVyetJenf+sdvYi2RUXzzmRcZZHbtQOSDfd+Dm vyI+46Y4qKXgBgShKwrLZrBQy; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:60468 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fnnMQ-001i4f-Ai; Thu, 09 Aug 2018 11:00:26 -0500 From: Tom Tromey To: Jim Wilson Cc: gdb-patches@sourceware.org Subject: Re: New ARI warning Thu Aug 9 01:56:05 UTC 2018 References: <20180809015605.GA57522@sourceware.org> Date: Thu, 09 Aug 2018 10:00:25 -0600 In-Reply-To: <20180809015605.GA57522@sourceware.org> (GDB Administrator's message of "Thu, 9 Aug 2018 01:56:05 +0000") Message-ID: <87bmab8r8m.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 >>>>> ">" == GDB Administrator writes: >> 482a483 >> gdb/riscv-tdep.h:84: code: function call in first column: Function >> name in first column should be restricted to function implementation >> gdb/riscv-tdep.h:84:riscv_software_single_step (struct regcache *regcache); Here's a patch to fix a few minor formatting issues in riscv-tdep.h, including the one pointed out by ARI. Let me know what you think. Tom diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 4d0593f1630..5e0e0e2a035 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2018-08-09 Tom Tromey + + * riscv-tdep.h: Minor formatting fixes. + 2018-08-08 Simon Marchi * target.c (str_comma_list_concat_elem): Fix typo in comment. diff --git a/gdb/riscv-tdep.h b/gdb/riscv-tdep.h index 85911169221..8358d4e00ba 100644 --- a/gdb/riscv-tdep.h +++ b/gdb/riscv-tdep.h @@ -1,4 +1,5 @@ -/* Target-dependent header for the RISC-V architecture, for GDB, the GNU Debugger. +/* Target-dependent header for the RISC-V architecture, for GDB, the + GNU Debugger. Copyright (C) 2018 Free Software Foundation, Inc. @@ -39,7 +40,8 @@ enum RISCV_LAST_FP_REGNUM = 64, /* Last Floating Point Register */ RISCV_FIRST_CSR_REGNUM = 65, /* First CSR */ -#define DECLARE_CSR(name, num) RISCV_ ## num ## _REGNUM = RISCV_FIRST_CSR_REGNUM + num, +#define DECLARE_CSR(name, num) \ + RISCV_ ## num ## _REGNUM = RISCV_FIRST_CSR_REGNUM + num, #include "opcode/riscv-opc.h" #undef DECLARE_CSR RISCV_LAST_CSR_REGNUM = 4160, @@ -80,7 +82,7 @@ struct gdbarch_tdep extern int riscv_isa_xlen (struct gdbarch *gdbarch); /* Single step based on where the current instruction will take us. */ -extern std::vector -riscv_software_single_step (struct regcache *regcache); +extern std::vector riscv_software_single_step + (struct regcache *regcache); #endif /* RISCV_TDEP_H */