New ARI warning Thu Aug 9 01:56:05 UTC 2018
Commit Message
>>>>> ">" == GDB Administrator <gdbadmin@sourceware.org> writes:
>> 482a483
>> gdb/riscv-tdep.h:84: code: function call in first column: Function
>> name in first column should be restricted to function implementation
>> gdb/riscv-tdep.h:84:riscv_software_single_step (struct regcache *regcache);
Here's a patch to fix a few minor formatting issues in riscv-tdep.h,
including the one pointed out by ARI.
Let me know what you think.
Tom
Comments
On Thu, Aug 9, 2018 at 9:00 AM, Tom Tromey <tom@tromey.com> wrote:
>>>>>> ">" == GDB Administrator <gdbadmin@sourceware.org> writes:
>
>>> 482a483
>>> gdb/riscv-tdep.h:84: code: function call in first column: Function
>>> name in first column should be restricted to function implementation
>>> gdb/riscv-tdep.h:84:riscv_software_single_step (struct regcache *regcache);
>
> Here's a patch to fix a few minor formatting issues in riscv-tdep.h,
> including the one pointed out by ARI.
>
> Let me know what you think.
Yes, it looks good to me. I copied the function definition a little
too literally and forgot to reformat it for the header file.
I'm not familiar with ARI, I will have to read up on that.
Jim
@@ -1,3 +1,7 @@
+2018-08-09 Tom Tromey <tom@tromey.com>
+
+ * riscv-tdep.h: Minor formatting fixes.
+
2018-08-08 Simon Marchi <simon.marchi@ericsson.com>
* target.c (str_comma_list_concat_elem): Fix typo in comment.
@@ -1,4 +1,5 @@
-/* Target-dependent header for the RISC-V architecture, for GDB, the GNU Debugger.
+/* Target-dependent header for the RISC-V architecture, for GDB, the
+ GNU Debugger.
Copyright (C) 2018 Free Software Foundation, Inc.
@@ -39,7 +40,8 @@ enum
RISCV_LAST_FP_REGNUM = 64, /* Last Floating Point Register */
RISCV_FIRST_CSR_REGNUM = 65, /* First CSR */
-#define DECLARE_CSR(name, num) RISCV_ ## num ## _REGNUM = RISCV_FIRST_CSR_REGNUM + num,
+#define DECLARE_CSR(name, num) \
+ RISCV_ ## num ## _REGNUM = RISCV_FIRST_CSR_REGNUM + num,
#include "opcode/riscv-opc.h"
#undef DECLARE_CSR
RISCV_LAST_CSR_REGNUM = 4160,
@@ -80,7 +82,7 @@ struct gdbarch_tdep
extern int riscv_isa_xlen (struct gdbarch *gdbarch);
/* Single step based on where the current instruction will take us. */
-extern std::vector<CORE_ADDR>
-riscv_software_single_step (struct regcache *regcache);
+extern std::vector<CORE_ADDR> riscv_software_single_step
+ (struct regcache *regcache);
#endif /* RISCV_TDEP_H */