From patchwork Mon Dec 4 17:10:46 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergio Durigan Junior X-Patchwork-Id: 24713 Received: (qmail 114265 invoked by alias); 4 Dec 2017 17:10:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 114256 invoked by uid 89); 4 Dec 2017 17:10:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=liberty X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Dec 2017 17:10:52 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 76F0DC054C39; Mon, 4 Dec 2017 17:10:51 +0000 (UTC) Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 93CCC5DA6F; Mon, 4 Dec 2017 17:10:47 +0000 (UTC) From: Sergio Durigan Junior To: Eli Zaretskii Cc: Sergio Lopez , gdb-patches@sourceware.org Subject: Re: [PATCH v3 4/5] Document the new "-a" command line option for gcore References: <20171204081716.5414-1-slp@redhat.com> <20171204081716.5414-5-slp@redhat.com> <83609mzfar.fsf@gnu.org> Date: Mon, 04 Dec 2017 12:10:46 -0500 In-Reply-To: <83609mzfar.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 04 Dec 2017 17:25:00 +0200") Message-ID: <874lp65sh5.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 X-IsSubscribed: yes On Monday, December 04 2017, Eli Zaretskii wrote: >> From: Sergio Lopez >> Cc: Sergio Lopez >> Date: Mon, 4 Dec 2017 09:17:15 +0100 >> >> gdb/ChangeLog: >> 2017-11-29 Sergio Lopez >> >> * NEWS (Changes since GDB 8.0): Announce new "-a" >> command line option for gcore. >> >> gdb/doc/ChangeLog: >> 2017-11-29 Sergio Lopez >> >> * gdb.texinfo (gcore man): Document new "-a" command line option. > > OK, but... > >> @c man begin OPTIONS gcore >> @table @env >> +@item -a >> +Dump all memory mappings. The actual effect of this option depends on the >> +Operating System. On @sc{gnu}/Linux, it will disable >> +@code{use-coredump-filter} and enable @code{dump-excluded-mappings}. > > ...should we have a cross-reference here to where the above commands > are described? Pedro approved the patches and I pushed them for Sergio. I also took the liberty to address Eli's comment before applying the patches. here's the diff against Sergio's original patch. Thanks, diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 1c383b4d47..3b251c60c1 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -43063,9 +43063,11 @@ running without any change. @c man begin OPTIONS gcore @table @env @item -a -Dump all memory mappings. The actual effect of this option depends on the -Operating System. On @sc{gnu}/Linux, it will disable -@code{use-coredump-filter} and enable @code{dump-excluded-mappings}. +Dump all memory mappings. The actual effect of this option depends on +the Operating System. On @sc{gnu}/Linux, it will disable +@code{use-coredump-filter} (@pxref{set use-coredump-filter}) and +enable @code{dump-excluded-mappings} (@pxref{set +dump-excluded-mappings}). @item -o @var{filename} The optional argument