From patchwork Wed Jul 29 14:20:59 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergio Durigan Junior X-Patchwork-Id: 7913 Received: (qmail 445 invoked by alias); 29 Jul 2015 14:21:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 436 invoked by uid 89); 29 Jul 2015 14:21:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 29 Jul 2015 14:21:04 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id AA88435417B for ; Wed, 29 Jul 2015 14:21:03 +0000 (UTC) Received: from localhost (unused-10-15-17-51.yyz.redhat.com [10.15.17.51]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6TEL0ji000415 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 29 Jul 2015 10:21:02 -0400 From: Sergio Durigan Junior To: Pedro Alves Cc: GDB Patches Subject: Re: [PATCH] Uniquify test names from gdb.python/{py-objfile.exp, py-pp-registration.exp} References: <1437772393-6739-1-git-send-email-sergiodj@redhat.com> <55B8ACB3.8040607@redhat.com> X-URL: http://blog.sergiodj.net Date: Wed, 29 Jul 2015 10:20:59 -0400 In-Reply-To: <55B8ACB3.8040607@redhat.com> (Pedro Alves's message of "Wed, 29 Jul 2015 11:36:35 +0100") Message-ID: <873807niyc.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 X-IsSubscribed: yes On Wednesday, July 29 2015, Pedro Alves wrote: > Hi Sergio, > > This unfortunately caused regressions in the testsuite: > > Running /home/pedro/gdb/mygit/build/../src/gdb/testsuite/gdb.python/py-objfile.exp ... > FAIL: gdb.python/py-objfile.exp: Get no-debug objfile file > FAIL: gdb.python/py-objfile.exp: Test owner of real objfile. > FAIL: gdb.python/py-objfile.exp: Add separate debug file file > FAIL: gdb.python/py-objfile.exp: Test owner of separate debug file > FAIL: gdb.python/py-objfile.exp: Test user-name of owner of separate debug file > FAIL: gdb.python/py-objfile.exp: print main with debug info > FAIL: gdb.python/py-objfile.exp: print lookup_objfile of separate debug file > >> -gdb_py_test_silent_cmd "python objfile = gdb.objfiles()\[0\]" \ >> +gdb_py_test_silent_cmd "python objfile = gdb.s()\[0\]" \ > > Looks like a typo snuck in here. > > Breakpoint 1, 0x0000000000400594 in main () > (gdb) python objfile = gdb.s()[0] > Traceback (most recent call last): > File "", line 1, in > AttributeError: 'module' object has no attribute 's' > Error while executing Python code. > (gdb) FAIL: gdb.python/py-objfile.exp: Get no-debug objfile file Ops, thanks for the report. I confess I have no idea how this happened, but I pushed a fix. Sorry about that, diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index ee0af2a..1f9bf98 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2015-07-29 Sergio Durigan Junior + + * gdb.python/py-objfile.exp: Fix typo that snuck in from my last + commit. + 2015-07-29 Patrick Palka * gdb.base/batch-preserve-term-settings.exp diff --git a/gdb/testsuite/gdb.python/py-objfile.exp b/gdb/testsuite/gdb.python/py-objfile.exp index 7dd094c..6e6dfe7 100644 --- a/gdb/testsuite/gdb.python/py-objfile.exp +++ b/gdb/testsuite/gdb.python/py-objfile.exp @@ -106,7 +106,7 @@ if ![runto_main] { return 0 } -gdb_py_test_silent_cmd "python objfile = gdb.s()\[0\]" \ +gdb_py_test_silent_cmd "python objfile = gdb.objfiles()\[0\]" \ "Get no-debug objfile file" 1 gdb_test "python print (objfile.owner)" "None" \