Message ID | 86zj4qoyd3.fsf@gmail.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 87523 invoked by alias); 27 May 2015 15:05:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 87513 invoked by uid 89); 27 May 2015 15:05:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f177.google.com Received: from mail-pd0-f177.google.com (HELO mail-pd0-f177.google.com) (209.85.192.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 27 May 2015 15:04:57 +0000 Received: by pdbqa5 with SMTP id qa5so19018726pdb.0 for <gdb-patches@sourceware.org>; Wed, 27 May 2015 08:04:56 -0700 (PDT) X-Received: by 10.70.41.165 with SMTP id g5mr59564310pdl.143.1432739085990; Wed, 27 May 2015 08:04:45 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by mx.google.com with ESMTPSA id wt1sm16493767pbc.4.2015.05.27.08.04.42 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 27 May 2015 08:04:44 -0700 (PDT) From: Yao Qi <qiyaoltc@gmail.com> To: Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com> Cc: Yao Qi <qiyaoltc@gmail.com>, Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org Subject: Re: [PATCH 2/4] Implements aarch64 process record and reverse debugging support References: <1432041752-4638-1-git-send-email-yao.qi@linaro.org> <1432041752-4638-3-git-send-email-yao.qi@linaro.org> <555E3EAE.2080107@redhat.com> <86h9qzr2g2.fsf@gmail.com> <5564D0E9.3000402@linux.vnet.ibm.com> <86d21mqvl0.fsf@gmail.com> <868ucaqq0o.fsf@gmail.com> <5565D0B8.7090602@linux.vnet.ibm.com> Date: Wed, 27 May 2015 16:04:40 +0100 In-Reply-To: <5565D0B8.7090602@linux.vnet.ibm.com> (Edjunior Barbosa Machado's message of "Wed, 27 May 2015 11:12:08 -0300") Message-ID: <86zj4qoyd3.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes |
Commit Message
Yao Qi
May 27, 2015, 3:04 p.m. UTC
Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com> writes: > unfortunately I was unable to apply your patch due to the follow: > I copy my patch from thunderbird, and paste it in 2.path. I have no trouble applying it. > $ patch -p1 -i ~/fix.patch --dry > (Stripping trailing CRs from patch; use --binary to disable.) > checking file gdb/aarch64-tdep.c > patch: **** malformed patch at line 6: *aarch64_insn_r) Does your editor split the line in patch like this?
Comments
On 05/27/2015 12:04 PM, Yao Qi wrote: > Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com> writes: > >> unfortunately I was unable to apply your patch due to the follow: >> > > I copy my patch from thunderbird, and paste it in 2.path. I have no > trouble applying it. > >> $ patch -p1 -i ~/fix.patch --dry >> (Stripping trailing CRs from patch; use --binary to disable.) >> checking file gdb/aarch64-tdep.c >> patch: **** malformed patch at line 6: *aarch64_insn_r) > > Does your editor split the line in patch like this? > > diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c > index 8597497..d07b26c 100644 > --- a/gdb/aarch64-tdep.c > +++ b/gdb/aarch64-tdep.c > @@ -3592,7 +3592,7 @@ aarch64_record_data_proc_simd_fp (insn_decode_record > *aarch64_insn_r) > ^^^^^^^^^^^^^^^ > > it should be in previous line. > I also use thunderbird, but usually I save the raw message instead of copying to avoid miscopies. But I managed to apply the patch after copying it as you suggested and checked that it fixes the build issue. Btw, I'm using gcc 4.8.3 for these tests. Thanks! -- Edjunior
Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com> writes: > I also use thunderbird, but usually I save the raw message instead of > copying to avoid miscopies. But I managed to apply the patch after > copying it as you suggested and checked that it fixes the build issue. Thanks for the verification. I'll push it in.
diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c index 8597497..d07b26c 100644 --- a/gdb/aarch64-tdep.c +++ b/gdb/aarch64-tdep.c @@ -3592,7 +3592,7 @@ aarch64_record_data_proc_simd_fp (insn_decode_record *aarch64_insn_r) ^^^^^^^^^^^^^^^ it should be in previous line. -- Yao (é½å°§)