diff mbox

[2/4] Implements aarch64 process record and reverse debugging support

Message ID 86zj4qoyd3.fsf@gmail.com
State New
Headers show

Commit Message

Yao Qi May 27, 2015, 3:04 p.m. UTC
Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com> writes:

> unfortunately I was unable to apply your patch due to the follow:
>

I copy my patch from thunderbird, and paste it in 2.path.  I have no
trouble applying it.

> $ patch -p1 -i ~/fix.patch --dry
> (Stripping trailing CRs from patch; use --binary to disable.)
> checking file gdb/aarch64-tdep.c
> patch: **** malformed patch at line 6: *aarch64_insn_r)

Does your editor split the line in patch like this?

Comments

Edjunior Barbosa Machado May 27, 2015, 3:54 p.m. UTC | #1
On 05/27/2015 12:04 PM, Yao Qi wrote:
> Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com> writes:
> 
>> unfortunately I was unable to apply your patch due to the follow:
>>
> 
> I copy my patch from thunderbird, and paste it in 2.path.  I have no
> trouble applying it.
> 
>> $ patch -p1 -i ~/fix.patch --dry
>> (Stripping trailing CRs from patch; use --binary to disable.)
>> checking file gdb/aarch64-tdep.c
>> patch: **** malformed patch at line 6: *aarch64_insn_r)
> 
> Does your editor split the line in patch like this?
> 
> diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
> index 8597497..d07b26c 100644
> --- a/gdb/aarch64-tdep.c
> +++ b/gdb/aarch64-tdep.c
> @@ -3592,7 +3592,7 @@ aarch64_record_data_proc_simd_fp (insn_decode_record
> *aarch64_insn_r)
> ^^^^^^^^^^^^^^^
> 
> it should be in previous line.
> 

I also use thunderbird, but usually I save the raw message instead of
copying to avoid miscopies. But I managed to apply the patch after
copying it as you suggested and checked that it fixes the build issue.
Btw, I'm using gcc 4.8.3 for these tests.

Thanks!
--
Edjunior
Yao Qi May 27, 2015, 4:18 p.m. UTC | #2
Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com> writes:

> I also use thunderbird, but usually I save the raw message instead of
> copying to avoid miscopies. But I managed to apply the patch after
> copying it as you suggested and checked that it fixes the build issue.

Thanks for the verification.  I'll push it in.
diff mbox

Patch

diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
index 8597497..d07b26c 100644
--- a/gdb/aarch64-tdep.c
+++ b/gdb/aarch64-tdep.c
@@ -3592,7 +3592,7 @@  aarch64_record_data_proc_simd_fp (insn_decode_record
*aarch64_insn_r)
^^^^^^^^^^^^^^^

it should be in previous line.

-- 
Yao (齐尧)