From patchwork Wed Oct 5 13:47:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 16272 Received: (qmail 57575 invoked by alias); 5 Oct 2016 13:47:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 57551 invoked by uid 89); 5 Oct 2016 13:47:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pf0-f194.google.com Received: from mail-pf0-f194.google.com (HELO mail-pf0-f194.google.com) (209.85.192.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Oct 2016 13:47:09 +0000 Received: by mail-pf0-f194.google.com with SMTP id 190so5897118pfv.1 for ; Wed, 05 Oct 2016 06:47:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=vHyWmhzyBG728xJgoG6KKHVQo7tCKg0l7sC1B5wUeT8=; b=dZNldF6dBDvXumIqNFMhulXl/+6BEzwcGXZ8DLgm1MG35Ql1JKPQ7VqZcokZYUug5y IevMjm8zJRVpIw0D63EC4rwqJ1xoUzgmjqt6XM/Sx2edyXPauetDDez8MtjwjQ/aZRTH 364GYX1XQDxGjnO+j9pUreoOwqWTk1Il18DEyZ7MBwTk3cEmZxQXK8TFFA2pAshuBBOr igzdlCyF17cjVDgn6DAchV9Ktq35/YaAp17y1YDPKKHe96u8A5sFi/63ItXq3UegVd/0 JHDXpeFm/qFivfEEBYwb4ShoCmE1CWsa85boYu0f3RlT9KWk2KXBcTYDSlQFe/lH0XFr AxZg== X-Gm-Message-State: AA6/9Rnl/oCkTVBZsliRaYVahgNofNmHkHO9dsRnbP3bjHa0QlFzwhAcNtjNwjw4u5TfvA== X-Received: by 10.98.82.209 with SMTP id g200mr7134970pfb.84.1475675228305; Wed, 05 Oct 2016 06:47:08 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id t67sm63833246pfd.32.2016.10.05.06.47.05 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 05 Oct 2016 06:47:07 -0700 (PDT) From: Yao Qi To: Pedro Alves Cc: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH] Skip float complex types if gdb_skip_float_test References: <1475591646-9783-1-git-send-email-yao.qi@linaro.org> Date: Wed, 05 Oct 2016 14:47:02 +0100 In-Reply-To: (Pedro Alves's message of "Tue, 4 Oct 2016 19:48:56 +0100") Message-ID: <86wphmaox5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-IsSubscribed: yes Pedro Alves writes: > Shouldn't this be checked within support_complex_tests itself? > AFAIK, _Complex is always about floating point: > > http://en.cppreference.com/w/c/language/arithmetic_types#Complex_floating_types > http://en.cppreference.com/w/cpp/numeric/complex Right, how about this? diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 758db46..1230e77 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -2176,6 +2176,13 @@ proc with_timeout_factor { factor body } { # Return 1 if _Complex types are supported, otherwise, return 0. gdb_caching_proc support_complex_tests { + + if { [gdb_skip_float_test] } { + # If floating point is not supported, _Complex is not + # supported. + return 0 + } + # Set up, compile, and execute a test program containing _Complex types. # Include the current process ID in the file names to prevent conflicts # with invocations for multiple testsuites.