From patchwork Tue Aug 4 13:43:49 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 7996 Received: (qmail 74861 invoked by alias); 4 Aug 2015 13:44:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 74852 invoked by uid 89); 4 Aug 2015 13:44:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f52.google.com Received: from mail-pa0-f52.google.com (HELO mail-pa0-f52.google.com) (209.85.220.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 04 Aug 2015 13:44:24 +0000 Received: by pacgq8 with SMTP id gq8so8992968pac.3 for ; Tue, 04 Aug 2015 06:44:22 -0700 (PDT) X-Received: by 10.68.249.36 with SMTP id yr4mr8033130pbc.18.1438695862869; Tue, 04 Aug 2015 06:44:22 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id oi17sm1531807pdb.74.2015.08.04.06.44.19 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 04 Aug 2015 06:44:22 -0700 (PDT) From: Yao Qi To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/7] Use arm target description and regs_info for 32-bit file on aarch64 GDBserver References: <1438355801-25798-1-git-send-email-yao.qi@linaro.org> <1438355801-25798-4-git-send-email-yao.qi@linaro.org> Date: Tue, 04 Aug 2015 14:43:49 +0100 In-Reply-To: <1438355801-25798-4-git-send-email-yao.qi@linaro.org> (Yao Qi's message of "Fri, 31 Jul 2015 16:16:37 +0100") Message-ID: <86si7zcgoa.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-IsSubscribed: yes Yao Qi writes: > This patch teaches aarch64-linux GDBserver use 32-bit arm target > description and regs_info if the elf file is 32-bit. This patch is updated together with patch #2. Here is what I pushed in. diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index 0ed70a2..d652bb3 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,5 +1,18 @@ 2015-08-04 Yao Qi + * configure.srv (case aarch64*-*-linux*): Append arm-with-neon.o + to srv_regobj and append arm-core.xml arm-vfpv3.xml and + arm-with-neon.xml to srv_xmlfiles. + * linux-aarch64-low.c: Include linux-aarch32-low.h. + (is_64bit_tdesc): New function. + (aarch64_linux_read_description): New function. + (aarch64_arch_setup): Call aarch64_linux_read_description. + (regs_info): Rename to regs_info_aarch64. + (aarch64_regs_info): Return right regs_info. + (initialize_low_arch): Call initialize_low_arch_aarch32. + +2015-08-04 Yao Qi + * configure.srv (srv_tgtobj): Add linux-aarch32-low.o. * linux-aarch32-low.c: New file. * linux-aarch32-low.h: New file. diff --git a/gdb/gdbserver/configure.srv b/gdb/gdbserver/configure.srv index 1a8361a..0b18d1d 100644 --- a/gdb/gdbserver/configure.srv +++ b/gdb/gdbserver/configure.srv @@ -49,11 +49,15 @@ srv_linux_obj="linux-low.o linux-osdata.o linux-procfs.o linux-ptrace.o linux-wa case "${target}" in aarch64*-*-linux*) srv_regobj="aarch64.o" + srv_regobj="${srv_regobj} arm-with-neon.o" srv_tgtobj="linux-aarch64-low.o aarch64-linux-hw-point.o" + srv_tgtobj="$srv_tgtobj linux-aarch32-low.o" srv_tgtobj="${srv_tgtobj} $srv_linux_obj" srv_xmlfiles="aarch64.xml" srv_xmlfiles="${srv_xmlfiles} aarch64-core.xml" srv_xmlfiles="${srv_xmlfiles} aarch64-fpu.xml" + srv_xmlfiles="${srv_xmlfiles} arm-core.xml arm-vfpv3.xml" + srv_xmlfiles="${srv_xmlfiles} arm-with-neon.xml" srv_linux_regsets=yes srv_linux_thread_db=yes ;; diff --git a/gdb/gdbserver/linux-aarch64-low.c b/gdb/gdbserver/linux-aarch64-low.c index 3a47521..e4a41ce 100644 --- a/gdb/gdbserver/linux-aarch64-low.c +++ b/gdb/gdbserver/linux-aarch64-low.c @@ -22,6 +22,7 @@ #include "server.h" #include "linux-low.h" #include "nat/aarch64-linux-hw-point.h" +#include "linux-aarch32-low.h" #include "elf/common.h" #include @@ -69,6 +70,16 @@ struct arch_process_info struct aarch64_debug_reg_state debug_reg_state; }; +/* Return true if the size of register 0 is 8 byte. */ + +static int +is_64bit_tdesc (void) +{ + struct regcache *regcache = get_thread_regcache (current_thread, 0); + + return register_size (regcache->tdesc, 0) == 8; +} + /* Implementation of linux_target_ops method "cannot_store_register". */ static int @@ -582,12 +593,32 @@ aarch64_linux_prepare_to_resume (struct lwp_info *lwp) } } +/* Return the right target description according to the ELF file of + current thread. */ + +static const struct target_desc * +aarch64_linux_read_description (void) +{ + unsigned int machine; + int is_elf64; + int tid; + + tid = lwpid_of (current_thread); + + is_elf64 = linux_pid_exe_is_elf_64_file (tid, &machine); + + if (is_elf64) + return tdesc_aarch64; + else + return tdesc_arm_with_neon; +} + /* Implementation of linux_target_ops method "arch_setup". */ static void aarch64_arch_setup (void) { - current_process ()->tdesc = tdesc_aarch64; + current_process ()->tdesc = aarch64_linux_read_description (); aarch64_linux_get_debug_reg_capacity (lwpid_of (current_thread)); } @@ -611,7 +642,7 @@ static struct regsets_info aarch64_regsets_info = NULL, /* disabled_regsets */ }; -static struct regs_info regs_info = +static struct regs_info regs_info_aarch64 = { NULL, /* regset_bitmap */ NULL, /* usrregs */ @@ -623,7 +654,10 @@ static struct regs_info regs_info = static const struct regs_info * aarch64_regs_info (void) { - return ®s_info; + if (is_64bit_tdesc ()) + return ®s_info_aarch64; + else + return ®s_info_aarch32; } /* Implementation of linux_target_ops method "supports_tracepoints". */ @@ -682,5 +716,7 @@ initialize_low_arch (void) { init_registers_aarch64 (); + initialize_low_arch_aarch32 (); + initialize_regsets_info (&aarch64_regsets_info); }