From patchwork Tue Jun 2 09:30:25 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 7005 Received: (qmail 98840 invoked by alias); 2 Jun 2015 09:30:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 98824 invoked by uid 89); 2 Jun 2015 09:30:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f169.google.com Received: from mail-pd0-f169.google.com (HELO mail-pd0-f169.google.com) (209.85.192.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 02 Jun 2015 09:30:36 +0000 Received: by pdjm12 with SMTP id m12so46115701pdj.3 for ; Tue, 02 Jun 2015 02:30:34 -0700 (PDT) X-Received: by 10.70.101.200 with SMTP id fi8mr48127761pdb.161.1433237434440; Tue, 02 Jun 2015 02:30:34 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by mx.google.com with ESMTPSA id ux6sm17243691pab.24.2015.06.02.02.30.31 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 02 Jun 2015 02:30:33 -0700 (PDT) From: Yao Qi To: Mark Wielaard Cc: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 0/6] Use PTRACE_GETREGSET and PTRACE_SETREGSET in arm-linux-nat.c References: <1432822816-32327-1-git-send-email-yao.qi@linaro.org> <556C3F54.2060502@gmail.com> <1433231848.4538.212.camel@bordewijk.wildebeest.org> Date: Tue, 02 Jun 2015 10:30:25 +0100 In-Reply-To: <1433231848.4538.212.camel@bordewijk.wildebeest.org> (Mark Wielaard's message of "Tue, 02 Jun 2015 09:57:28 +0200") Message-ID: <86pp5eo3ta.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-IsSubscribed: yes Mark Wielaard writes: > I believe this caused a build regression on i386. After this patch > series went in various buildbot i386 buildslaves builds started failing: > http://gdb-build.sergiodj.net/waterfall > > ../../binutils-gdb/gdb/i386-linux-nat.c: In function ‘fetch_xstateregs’: > ../../binutils-gdb/gdb/i386-linux-nat.c:329:8: error: > ‘have_ptrace_getregset’ undeclared (first use in this function) > ../../binutils-gdb/gdb/i386-linux-nat.c:329:8: note: each undeclared > identifier is reported only once for each function it appears in > ../../binutils-gdb/gdb/i386-linux-nat.c: In function ‘store_xstateregs’: > ../../binutils-gdb/gdb/i386-linux-nat.c:352:8: error: > ‘have_ptrace_getregset’ undeclared (first use in this function) > make[2]: *** [i386-linux-nat.o] Error 1 > > Could you take a look? Oh, I forget rebuilding GDB for i686 target. This patch fixes the build failure. diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 5867465..eca000f 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2015-06-02 Yao Qi + + * i386-linux-nat.c: Include linux-nat.h. + 2015-06-01 Andreas Schwab Jan Kratochvil diff --git a/gdb/i386-linux-nat.c b/gdb/i386-linux-nat.c index 5666361..4401a2f 100644 --- a/gdb/i386-linux-nat.c +++ b/gdb/i386-linux-nat.c @@ -33,6 +33,7 @@ #include "i386-linux-tdep.h" #include "x86-xstate.h" +#include "linux-nat.h" #include "x86-linux-nat.h" #include "nat/linux-ptrace.h"