From patchwork Tue May 24 11:13:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 12487 Received: (qmail 38945 invoked by alias); 24 May 2016 11:14:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 38242 invoked by uid 89); 24 May 2016 11:14:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Received:10.98.28.84 X-HELO: mail-pf0-f169.google.com Received: from mail-pf0-f169.google.com (HELO mail-pf0-f169.google.com) (209.85.192.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 24 May 2016 11:13:39 +0000 Received: by mail-pf0-f169.google.com with SMTP id c189so6116052pfb.3 for ; Tue, 24 May 2016 04:13:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=5pxBTm1DtupYWGeTk/D6weKaYoKYO8WlJ3xEM67Bwmk=; b=cAO7PYWdBP2Ps/Litn2FVkqlZzgr6S7oxZjplpF9Exo7JUoc0FurtdBrLVzDqmgStu huSfFKbvsz48YIy6XV061OXH4AlHpRjfbNj9OXmlF1bIG5gb4kOKElmnbV5pKGsAn25G fdW821nUlT/2MqM8XoE0lU+tFQgGzHocPOby7a4M0ITFGJD7Lc2dJ62ilrNp60Y50J3q fKNNjeUgz3WaweaFbRSJIHWfDXoviBDKP/oh40Yn/0NH+of9yJhwnSdoLIqKPEiMWdoc bacJd3FbaHxMyBnMZ3uhOTeW6cKZ32JSoEMl8K1Js52Vh+PaCREtgDDQkh1I644WcU+x 7gUg== X-Gm-Message-State: ALyK8tK7cywVT6ysfvBKHgpDPuAv2Ul4YOHJJTKoezWO3vAmzveqfwTzuZmT30RZnq+cQw== X-Received: by 10.98.28.84 with SMTP id c81mr5851449pfc.131.1464088393037; Tue, 24 May 2016 04:13:13 -0700 (PDT) Received: from E107787-LIN (gcc113.osuosl.org. [140.211.9.71]) by smtp.gmail.com with ESMTPSA id vi6sm4455041pab.21.2016.05.24.04.13.09 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 24 May 2016 04:13:12 -0700 (PDT) From: Yao Qi To: Francis Ricci Cc: gdb-patches@sourceware.org, sas@fb.com, fjricci@fb.com Subject: Re: [PATCH] Fix syntax error in annota-input-while-running.exp References: Date: Tue, 24 May 2016 12:13:00 +0100 In-Reply-To: (Francis Ricci's message of "Mon, 23 May 2016 14:31:34 -0400") Message-ID: <86oa7v4slf.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-IsSubscribed: yes Francis Ricci writes: Hi Francis, Thanks for your patch, > annota-input-while-running.exp to crash the test suite runner. > > This is my first gdb contribution, so I have not signed a copyright > assignment form. However, from reading gdb/CONTRIBUTE, it looks like > this is not necessary for small changes. You can get more from https://sourceware.org/gdb/wiki/ContributionChecklist > > 2016-05-22 Francis Ricci There are two spaces before and after your name. > > * gdb.base/annota-input-while-running.exp: Fix syntax error. Patch below is pushed in. diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 1f0e3f9..c50edad 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2016-05-24 Francis Ricci (tiny patch) + + * gdb.base/annota-input-while-running.exp: Fix syntax error. + 2016-05-23 Tom Tromey PR python/19438, PR python/18393: diff --git a/gdb/testsuite/gdb.base/annota-input-while-running.exp b/gdb/testsuite/gdb.base/annota-input-while-running.exp index adc96e4..fc2e608 100644 --- a/gdb/testsuite/gdb.base/annota-input-while-running.exp +++ b/gdb/testsuite/gdb.base/annota-input-while-running.exp @@ -25,8 +25,8 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug] == -1} { # Because runto_main doesn't know how to handle the prompt with annotations, # run to main before we set the annotation level. if ![runto_main] then { -- fail "Can't run to main" -- return 1 + fail "Can't run to main" + return 1 } # NOTE: this prompt is OK only when the annotation level is > 1