[2/2] Add aarch64-linux in supports_get_siginfo_type
Commit Message
Pedro Alves <palves@redhat.com> writes:
> I note that a few other archs are also missing here:
>
> aarch64-linux-tdep.c: set_gdbarch_get_siginfo_type (gdbarch,
> linux_get_siginfo_type);
> amd64-linux-tdep.c: set_gdbarch_get_siginfo_type (gdbarch,
> linux_get_siginfo_type);
> arm-linux-tdep.c: set_gdbarch_get_siginfo_type (gdbarch,
> linux_get_siginfo_type);
> i386-linux-tdep.c: set_gdbarch_get_siginfo_type (gdbarch,
> linux_get_siginfo_type);
> m68klinux-tdep.c: set_gdbarch_get_siginfo_type (gdbarch,
> linux_get_siginfo_type);
> ppc-linux-tdep.c: set_gdbarch_get_siginfo_type (gdbarch,
> linux_get_siginfo_type);
> s390-linux-tdep.c: set_gdbarch_get_siginfo_type (gdbarch,
> linux_get_siginfo_type);
> tilegx-linux-tdep.c: set_gdbarch_get_siginfo_type (gdbarch,
> linux_get_siginfo_type);
Hmm, looks something wrong in my emacs+cscope that only the top four are
shown up.
>
> though at the pace this is taking, it'd probably be better to register
> linux_get_siginfo_type as default for all Linux archs (in
> linux-tdep.c:linux_init_abi),
> and have archs whoch kernel/ABI uses the non-generic siginfo layout install a
> custom get_siginfo_type version. The supports_get_siginfo_type
> testsuite function
> would then return true for [istarget "*-*-linux*"]. The testsuite
> would then help
> show which archs would those be.
Change like this may cause some fails for some linux targets which need
their custom get_siginfo_type implementations. Here is a patch below,
I rerun siginfo-obj.exp and siginfo-thread.exp on aarch64/arm/x86_64 linux.
Comments
On 06/24/2015 02:30 PM, Yao Qi wrote:
>>
>> though at the pace this is taking, it'd probably be better to register
>> linux_get_siginfo_type as default for all Linux archs (in
>> linux-tdep.c:linux_init_abi),
>> and have archs whoch kernel/ABI uses the non-generic siginfo layout install a
>> custom get_siginfo_type version. The supports_get_siginfo_type
>> testsuite function
>> would then return true for [istarget "*-*-linux*"]. The testsuite
>> would then help
>> show which archs would those be.
>
> Change like this may cause some fails for some linux targets which need
> their custom get_siginfo_type implementations.
Right, that's how I was thinking the tests would help. As is currently,
arch maintainers miss that the feature even exists.
> Here is a patch below,
> I rerun siginfo-obj.exp and siginfo-thread.exp on aarch64/arm/x86_64 linux.
Thanks.
> From 476653a2990b4ebfac806b0da6ffa24b5672ece9 Mon Sep 17 00:00:00 2001
> From: Yao Qi <yao.qi@linaro.org>
> Date: Fri, 19 Jun 2015 14:50:33 +0100
> Subject: [PATCH] Call set_gdbarch_get_siginfo_type in linux_init_abi
>
> linux_get_siginfo_type is installed to many linux gdbarch. This patch
> is to move this to a common area linux-tdep.c:linux_init_abi, so that
> linux_get_siginfo_type is installed to every linux gdbarch. If some
> linux gdbarch needs its own version, please override it in
> $ARCH_linux_init_abi. In the testsuite, we enable siginfo related
> tests for all linux targets.
(Or if you need a quick fix, set it to NULL in that particular arch's
gdbarch init function.)
Looks good to me. Thanks for doing this.
@@ -962,7 +962,6 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
/* Shared library handling. */
set_gdbarch_skip_trampoline_code (gdbarch, find_solib_trampoline_target);
- set_gdbarch_get_siginfo_type (gdbarch, linux_get_siginfo_type);
tramp_frame_prepend_unwinder (gdbarch, &aarch64_linux_rt_sigframe);
/* Enable longjmp. */
@@ -1835,8 +1835,6 @@ amd64_linux_init_abi_common(struct gdbarch_info info, struct gdbarch *gdbarch)
set_gdbarch_displaced_step_location (gdbarch,
linux_displaced_step_location);
- set_gdbarch_get_siginfo_type (gdbarch, linux_get_siginfo_type);
-
set_gdbarch_process_record (gdbarch, i386_process_record);
set_gdbarch_process_record_signal (gdbarch, amd64_linux_record_signal);
}
@@ -1441,8 +1441,6 @@ arm_linux_init_abi (struct gdbarch_info info,
(gdbarch, arm_linux_iterate_over_regset_sections);
set_gdbarch_core_read_description (gdbarch, arm_linux_core_read_description);
- set_gdbarch_get_siginfo_type (gdbarch, linux_get_siginfo_type);
-
/* Displaced stepping. */
set_gdbarch_displaced_step_copy_insn (gdbarch,
arm_linux_displaced_step_copy_insn);
@@ -996,8 +996,6 @@ i386_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
set_xml_syscall_file_name (gdbarch, XML_SYSCALL_FILENAME_I386);
set_gdbarch_get_syscall_number (gdbarch,
i386_linux_get_syscall_number);
-
- set_gdbarch_get_siginfo_type (gdbarch, linux_get_siginfo_type);
}
/* Provide a prototype to silence -Wmissing-prototypes. */
@@ -243,7 +243,7 @@ get_linux_inferior_data (void)
/* This function is suitable for architectures that don't
extend/override the standard siginfo structure. */
-struct type *
+static struct type *
linux_get_siginfo_type (struct gdbarch *gdbarch)
{
struct linux_gdbarch_data *linux_gdbarch_data;
@@ -2440,6 +2440,7 @@ linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
set_gdbarch_vsyscall_range (gdbarch, linux_vsyscall_range);
set_gdbarch_infcall_mmap (gdbarch, linux_infcall_mmap);
set_gdbarch_infcall_munmap (gdbarch, linux_infcall_munmap);
+ set_gdbarch_get_siginfo_type (gdbarch, linux_get_siginfo_type);
}
/* Provide a prototype to silence -Wmissing-prototypes. */
@@ -29,8 +29,6 @@ typedef char *(*linux_collect_thread_registers_ftype) (const struct regcache *,
bfd *, char *, int *,
enum gdb_signal);
-struct type *linux_get_siginfo_type (struct gdbarch *);
-
extern enum gdb_signal linux_gdb_signal_from_target (struct gdbarch *gdbarch,
int signal);
@@ -422,8 +422,6 @@ m68k_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
/* Enable TLS support. */
set_gdbarch_fetch_tls_load_module_address (gdbarch,
svr4_fetch_objfile_link_map);
-
- set_gdbarch_get_siginfo_type (gdbarch, linux_get_siginfo_type);
}
/* Provide a prototype to silence -Wmissing-prototypes. */
@@ -1801,8 +1801,6 @@ ppc_linux_init_abi (struct gdbarch_info info,
set_gdbarch_displaced_step_location (gdbarch,
linux_displaced_step_location);
- set_gdbarch_get_siginfo_type (gdbarch, linux_get_siginfo_type);
-
/* Support reverse debugging. */
set_gdbarch_process_record (gdbarch, ppc_process_record);
set_gdbarch_process_record_signal (gdbarch, ppc_linux_record_signal);
@@ -3329,8 +3329,6 @@ s390_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
set_gdbarch_fetch_tls_load_module_address (gdbarch,
svr4_fetch_objfile_link_map);
- set_gdbarch_get_siginfo_type (gdbarch, linux_get_siginfo_type);
-
/* SystemTap functions. */
set_gdbarch_stap_register_prefixes (gdbarch, stap_register_prefixes);
set_gdbarch_stap_register_indirection_prefixes (gdbarch,
@@ -2000,9 +2000,7 @@ gdb_caching_proc support_complex_tests {
# return 0.
proc supports_get_siginfo_type {} {
- if { [istarget "i?86-*-linux*"]
- || [istarget "x86_64-*-linux*"]
- || [istarget "arm*-*-linux*"] } {
+ if { [istarget "*-*-linux*"] } {
return 1
} else {
return 0
@@ -133,8 +133,6 @@ tilegx_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
/* Shared library handling. */
set_gdbarch_skip_trampoline_code (gdbarch, find_solib_trampoline_target);
set_gdbarch_skip_solib_resolver (gdbarch, glibc_skip_solib_resolver);
-
- set_gdbarch_get_siginfo_type (gdbarch, linux_get_siginfo_type);
}
/* Provide a prototype to silence -Wmissing-prototypes. */