From patchwork Fri Sep 22 11:01:36 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pedro Alves X-Patchwork-Id: 23077 Received: (qmail 43899 invoked by alias); 22 Sep 2017 11:01:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 43885 invoked by uid 89); 22 Sep 2017 11:01:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Sep 2017 11:01:41 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D4424272C0 for ; Fri, 22 Sep 2017 11:01:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D4424272C0 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5CC8A6292C; Fri, 22 Sep 2017 11:01:37 +0000 (UTC) Subject: Re: [PATCH v3 1/5] Import "glob" and "getcwd" modules from gnulib To: Sergio Durigan Junior , GDB Patches References: <20170912042325.14927-1-sergiodj@redhat.com> <20170921225926.23132-1-sergiodj@redhat.com> <20170921225926.23132-2-sergiodj@redhat.com> From: Pedro Alves Message-ID: <85ed7bac-f4d7-d348-01d1-acadcbbc56b8@redhat.com> Date: Fri, 22 Sep 2017 12:01:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170921225926.23132-2-sergiodj@redhat.com> On 09/21/2017 11:59 PM, Sergio Durigan Junior wrote: > * gnulib/import/m4/gnulib-cache.m4: Regenerate Missing period. > * ser-tcp.c: Undefine "close" before redefining it. Please add a comment. Something like: /* Gnulib defines close too, but gnulib's replacement doesn't call closesocket unless we import the socketlib module. */ Otherwise OK. Thanks, Pedro Alves diff --git a/gdb/ser-tcp.c b/gdb/ser-tcp.c index f35991c..c8be37b 100644 --- a/gdb/ser-tcp.c +++ b/gdb/ser-tcp.c @@ -42,6 +42,7 @@ > #ifndef ETIMEDOUT > #define ETIMEDOUT WSAETIMEDOUT > #endif > +#undef close > #define close(fd) closesocket (fd) > #define ioctl ioctlsocket > #else