From patchwork Thu Feb 28 18:30:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eli Zaretskii X-Patchwork-Id: 31689 Received: (qmail 29072 invoked by alias); 28 Feb 2019 18:31:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 29057 invoked by uid 89); 28 Feb 2019 18:31:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy=use_win32api, USE_WIN32API, 2111, UD:xz X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Feb 2019 18:31:09 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44320) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzQSW-0000U0-0L; Thu, 28 Feb 2019 13:31:06 -0500 Received: from [176.228.60.248] (port=2814 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gzQSM-0005cu-TF; Thu, 28 Feb 2019 13:30:59 -0500 Date: Thu, 28 Feb 2019 20:30:31 +0200 Message-Id: <837edjkbp4.fsf@gnu.org> From: Eli Zaretskii To: Joel Brobecker , Sergio Durigan Junior CC: gdb-patches@sourceware.org In-reply-to: <20190227055112.4A5E782D7B@joel.gnat.com> (message from Joel Brobecker on Wed, 27 Feb 2019 09:51:12 +0400 (+04)) Subject: MinGW build of GDB 8.2.90 (was: GDB 8.2.90 available for testing) References: <20190227055112.4A5E782D7B@joel.gnat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes > From: Joel Brobecker > Date: Wed, 27 Feb 2019 09:51:12 +0400 (+04) > > I have just finished creating the gdb-8.2.90 pre-release. > It is available for download at the following location: > > ftp://sourceware.org/pub/gdb/snapshots/branch/gdb-8.2.90.tar.xz Thanks, I've built this with mingw.org's MinGW and bumped into a few problems. First, the recent changes to support IPv6 caused compilation errors in several files. The problem is with several fragments such as this one: #ifdef USE_WIN32API #include #include #else ... mingw.org's MinGW doesn't have wspiapi.h. Moreover, the Microsoft documentation indicates that to get prototypes of getaddrinfo, freeaddrinfo, etc. one needs to include ws2tcpip.h (and not include winsock2.h separately), see, for example, https://docs.microsoft.com/en-us/windows/desktop/api/ws2tcpip/nf-ws2tcpip-getaddrinfo Sergio, can you tell why you used wspiapi.h instead? Is it okay to push changes such as the one below, master and branch (after filing a Bugzilla report)? Note that one other side effect of the IPv6 support additions is that on MS-Windows GDB will no longer run on versions older than XP, I guess this is something that should be mentioned in NEWS? The other two problems were minor warning, one in tui.c about an unused variable 'cap' (it is not used on Windows) and another in xml-syscall.c: CXX xml-syscall.o xml-syscall.c: In function 'bool xml_list_syscalls_by_group(gdbarch*, const char*, std::vector*)': xml-syscall.c:475:14: warning: types may not be defined in a for-range-declaration for (const struct syscall_desc *sysdesc : groupdesc->syscalls) ^~~~~~ I solved the latter by removing "struct" from the declaration. This is with GCC 6.3.0; is that a GCC bug? is removing "struct" the right solution? Thanks. --- ./gdb/common/netstuff.c~0 2019-02-27 06:51:50.000000000 +0200 +++ ./gdb/common/netstuff.c 2019-02-28 08:56:07.511568800 +0200 @@ -21,8 +21,11 @@ #include #ifdef USE_WIN32API -#include -#include +#if _WIN32_WINNT < 0x0501 +# undef _WIN32_WINNT +# define _WIN32_WINNT 0x0501 +#endif +#include #else #include #include