From patchwork Sat Apr 6 17:03:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 88130 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C02433858403 for ; Sat, 6 Apr 2024 17:04:05 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 23951385841E for ; Sat, 6 Apr 2024 17:03:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 23951385841E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 23951385841E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712423012; cv=none; b=THwBnnyoDHWQ6wc06qiCiM3xCYL8rdbc1LMicDc76suZchFsOpP4kwJyx3tRaMmJf5Cw29AnAY1nrnhibezQZ5BYk6ZLmECRx/+Tto5GoZRiCg0y32BR/+c//0bqJYy/iEy4L1XReRDdQVhTKr+1pC5NI5lFr3zX6iFlAGJ24hI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712423012; c=relaxed/simple; bh=q5Ypfshjtbukzyo5yaGWYRKGeSzFDxoYGlooACKlAH4=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=AKri7s/FB1EDq8pQoXfWKfIXSJ1sviYUNclhyZtsxoz6wGugjz0jGhUyWBZSimcnpwYYNU1cg6AnUDJtGAKLviYC6MviJdi95moXnffkDJMGywUmsVsya4d8dw0U12jka44+8P/aq2/dVEwKorllLp36LCYrkOrqB0AodI8NImM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712423008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ieCR6thRVKIZ43wfP1To80qff2k7bgX6sIs4sKEEMMw=; b=JWwGK2DuAx6DTcbRboL3qaCPSj7z8tmhLBJpBy1yqWeLdUdU47aEHad5eQOEfJA5LOepot E57nyzi11uYH7rfb7BS1l8tJlQu7sgGhD25kOtBRdvJOa1KMrdCGy17rkvsk9BmndsRxBR z8Dk6KMSMEmExUcJ8V9FyPTeUK3dLVM= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-32-jugKsrw-OrSnGEDbaewcYA-1; Sat, 06 Apr 2024 13:03:27 -0400 X-MC-Unique: jugKsrw-OrSnGEDbaewcYA-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a4455ae71fcso204183366b.3 for ; Sat, 06 Apr 2024 10:03:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712423005; x=1713027805; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ieCR6thRVKIZ43wfP1To80qff2k7bgX6sIs4sKEEMMw=; b=GoXTiMSVSSOnUBAOQQwPwdMPEsRE7AWnJ2Ut2u/inxgCzSiIFIlzfb35s5ztR4VZJM uE/CC9Iaf/l7MU2H0dZfczvAu032s+nbgsvm07e6qV20ELq7jNDwstfE0cKTfs9gFJLP COPBdryvcKDOkrssq1BG4QrfXajyw808z2j3apRbyJOFuBv18YSGTTe8o1xo/QnW6Ysh 9HOH6XRTD4ZlisxnOf7IaJq+1XJ0WBJ8CI+dFfjmPAWptOQQAz3jkCzAe9kBL1Of9NBR 495JUJ5ppOFW6n1QQst3N9i2oCrB4ph+4G0pfsPYkG18Q86LoSqQTcXq4l+7O5ZKKQw/ AEjQ== X-Gm-Message-State: AOJu0Yw6zMGugfxedWn7hivnUFelM6AOlt0r/vsi7UnEHBXnrQ8b1fKU Gkr1X6m2TtScRySsuBzOcOOfeDaKlSJ88w3vhW90tFXAugcII4dP6hCZrh7wgK9p2hgoaBLO5xQ V6J8ZPZ8sc7x3LigZMK95yRQtaIyKlIbvV8g+GYGFX29XN8FYx3+Ghwyk1EGBkFgX0WfUKEDZww I54Ojr5nYkddymE3Vlq0qZbzgcZZ1VLifSvQlH9VjGgUI= X-Received: by 2002:a50:c30c:0:b0:56d:c295:dde3 with SMTP id a12-20020a50c30c000000b0056dc295dde3mr3881770edb.35.1712423004961; Sat, 06 Apr 2024 10:03:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG0VPhw2it5UHbPMhAf9zLuncYa+9cHmf0Z+PaZdTptYV5ayMgxBb01LmJt6CEXIaw71UYd4w== X-Received: by 2002:a50:c30c:0:b0:56d:c295:dde3 with SMTP id a12-20020a50c30c000000b0056dc295dde3mr3881752edb.35.1712423004442; Sat, 06 Apr 2024 10:03:24 -0700 (PDT) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id de26-20020a056402309a00b0056c1cca33bfsm2040774edb.6.2024.04.06.10.03.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 10:03:23 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv2 3/6] gdb/Makefile: add some missing config.status dependencies Date: Sat, 6 Apr 2024 18:03:12 +0100 Message-Id: <7c64e75ac82b176db8bd4572ace865076851c36e.1712422921.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org I noticed that for the build targets jit-reader.h, gcore, gdb-gdb.py, and gdb-gdb.gdb the rules all use the config.status script, but don't have a dependency on the config.status target. This means we might fail to regenerate these targets in a case where config.status, or one of its dependencies changes. Two other targets that use config.status do correctly have a dependency on config.status. Fixed in this commit by adding the missing dependencies. There should be no changes in _what_ is generated after this commit. --- gdb/Makefile.in | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gdb/Makefile.in b/gdb/Makefile.in index 9340becbdc9..c1b3144b175 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -2313,16 +2313,16 @@ Makefile: Makefile.in config.status run: Makefile ./gdb$(EXEEXT) --data-directory=`pwd`/data-directory $(GDBFLAGS) -jit-reader.h: $(srcdir)/jit-reader.in +jit-reader.h: $(srcdir)/jit-reader.in config.status $(SHELL) config.status $@ -gcore: $(srcdir)/gcore.in +gcore: $(srcdir)/gcore.in config.status $(SHELL) config.status $@ -gdb-gdb.py: $(srcdir)/gdb-gdb.py.in +gdb-gdb.py: $(srcdir)/gdb-gdb.py.in config.status $(SHELL) config.status $@ -gdb-gdb.gdb: $(srcdir)/gdb-gdb.gdb.in +gdb-gdb.gdb: $(srcdir)/gdb-gdb.gdb.in config.status $(SHELL) config.status $@ config.h: stamp-h ; @true