[1/2] gdbsupport: rename source files to .cc

From: Simon Marchi <simon.marchi@efficios.com>

On 2020-02-13 1:33 p.m., Pedro Alves wrote:
> On 2/13/20 2:04 PM, Tom Tromey wrote:
>>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
>>
>> Simon> This patch renames the .c source files in gdbsupport to .cc.
>>
>> I support this change.
>>
>> Note that this would let us remove these hacks from gdbsupport/Makefile.am:
>>
>> override CXX += $(CXX_DIALECT)
>>
>> override CC := $(CXX)
>> override CFLAGS := $(CXXFLAGS)
>>
>> AM_CFLAGS = $(WARN_CFLAGS) $(WERROR_CFLAGS)
>>
>>
>> The CC and CFLAGS settings can be removed entirely.  AM_CFLAGS can be
>> renamed to AM_CXXFLAGS, and the CXX_DIALECT can be put there.
> 
> I had preferred overriding CXX instead of CXXFLAGS for the reasons
> explained at [1] [2].  Sounds like that defeats it.
> 
> [1] https://sourceware.org/ml/gdb-patches/2020-01/msg00453.html
> [2] https://sourceware.org/ml/gdb-patches/2020-01/msg00460.html
> 
> Thanks,
> Pedro Alves
> 

No problem.  Here's the updated patch.

Given that you have not commented on it, I presume you don't object to renaming these files?

From 9fd1aad643992cc3439e022e166807e7af121b1c Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@efficios.com>
Date: Wed, 12 Feb 2020 16:10:10 -0500
Subject: [PATCH] gdbsupport: rename source files to .cc

This patch renames the .c source files in gdbsupport to .cc.

In the gdb directory, there is an argument against renaming the source
files, which is that it makes using some git commands more difficult to
do archeology.  Some commands have some kind of "follow" option that
makes git try to follow renames, but it doesn't work in all situations.

Given that we have just moved the gdbsupport directory, that argument
doesn't hold for source files in that directory.  I therefore suggest
renaming them to .cc, so that they are automatically recognized as C++
by various tools and editors.

The original motivation behind this is that when building gdbsupport
with clang, I get:

      CC       agent.o
    clang: error: treating 'c' input as 'c++' when in C++ mode, this behavior is deprecated [-Werror,-Wdeprecated]

In the gdb/ directory, we make clang happy by passing "-x c++".  We
could do this in gdbsupport too, but I think that renaming the files is
a better long-term solution.

gdbserver still does its own build of gdbsupport, so a few changes in
its Makefile are necessary.

gdbsupport/ChangeLog:

	* Makefile.am: Rename source files from .c to .cc.
	(CC, CFLAGS): Don't override.
	(AM_CFLAGS): Rename to ...
	(AM_CXXFLAGS): ... this.
	* Makefile.in: Re-generate.
	* %.c: Rename to %.cc.

gdbserver/ChangeLog:

	* Makefile.in: Rename gdbsupport source files from .c to .cc.
---
 gdbserver/Makefile.in                         |  56 ++++----
 gdbsupport/Makefile.am                        |  73 +++++-----
 gdbsupport/Makefile.in                        | 126 +++++++++---------
 gdbsupport/{agent.c => agent.cc}              |   0
 .../{btrace-common.c => btrace-common.cc}     |   0
 gdbsupport/{buffer.c => buffer.cc}            |   0
 gdbsupport/{cleanups.c => cleanups.cc}        |   0
 .../{common-debug.c => common-debug.cc}       |   0
 ...mmon-exceptions.c => common-exceptions.cc} |   0
 .../{common-inferior.c => common-inferior.cc} |   0
 .../{common-regcache.c => common-regcache.cc} |   0
 .../{common-utils.c => common-utils.cc}       |   0
 gdbsupport/{environ.c => environ.cc}          |   0
 gdbsupport/{errors.c => errors.cc}            |   0
 gdbsupport/{fileio.c => fileio.cc}            |   0
 gdbsupport/{filestuff.c => filestuff.cc}      |   0
 gdbsupport/{format.c => format.cc}            |   0
 gdbsupport/{gdb-dlfcn.c => gdb-dlfcn.cc}      |   0
 ...gdb_tilde_expand.c => gdb_tilde_expand.cc} |   0
 gdbsupport/{gdb_vecs.c => gdb_vecs.cc}        |   0
 gdbsupport/{gdb_wait.c => gdb_wait.cc}        |   0
 gdbsupport/{job-control.c => job-control.cc}  |   0
 gdbsupport/{netstuff.c => netstuff.cc}        |   0
 gdbsupport/{new-op.c => new-op.cc}            |   0
 gdbsupport/{pathstuff.c => pathstuff.cc}      |   0
 gdbsupport/{print-utils.c => print-utils.cc}  |   0
 gdbsupport/{ptid.c => ptid.cc}                |   0
 gdbsupport/{rsp-low.c => rsp-low.cc}          |   0
 .../{run-time-clock.c => run-time-clock.cc}   |   0
 .../{safe-strerror.c => safe-strerror.cc}     |   0
 gdbsupport/{scoped_mmap.c => scoped_mmap.cc}  |   0
 gdbsupport/{selftest.c => selftest.cc}        |   0
 ...estore.c => signals-state-save-restore.cc} |   0
 gdbsupport/{signals.c => signals.cc}          |   0
 gdbsupport/{tdesc.c => tdesc.cc}              |   0
 gdbsupport/{thread-pool.c => thread-pool.cc}  |   0
 gdbsupport/{xml-utils.c => xml-utils.cc}      |   0
 gnulib/Makefile.in                            |   4 +-
 38 files changed, 126 insertions(+), 133 deletions(-)
 rename gdbsupport/{agent.c => agent.cc} (100%)
 rename gdbsupport/{btrace-common.c => btrace-common.cc} (100%)
 rename gdbsupport/{buffer.c => buffer.cc} (100%)
 rename gdbsupport/{cleanups.c => cleanups.cc} (100%)
 rename gdbsupport/{common-debug.c => common-debug.cc} (100%)
 rename gdbsupport/{common-exceptions.c => common-exceptions.cc} (100%)
 rename gdbsupport/{common-inferior.c => common-inferior.cc} (100%)
 rename gdbsupport/{common-regcache.c => common-regcache.cc} (100%)
 rename gdbsupport/{common-utils.c => common-utils.cc} (100%)
 rename gdbsupport/{environ.c => environ.cc} (100%)
 rename gdbsupport/{errors.c => errors.cc} (100%)
 rename gdbsupport/{fileio.c => fileio.cc} (100%)
 rename gdbsupport/{filestuff.c => filestuff.cc} (100%)
 rename gdbsupport/{format.c => format.cc} (100%)
 rename gdbsupport/{gdb-dlfcn.c => gdb-dlfcn.cc} (100%)
 rename gdbsupport/{gdb_tilde_expand.c => gdb_tilde_expand.cc} (100%)
 rename gdbsupport/{gdb_vecs.c => gdb_vecs.cc} (100%)
 rename gdbsupport/{gdb_wait.c => gdb_wait.cc} (100%)
 rename gdbsupport/{job-control.c => job-control.cc} (100%)
 rename gdbsupport/{netstuff.c => netstuff.cc} (100%)
 rename gdbsupport/{new-op.c => new-op.cc} (100%)
 rename gdbsupport/{pathstuff.c => pathstuff.cc} (100%)
 rename gdbsupport/{print-utils.c => print-utils.cc} (100%)
 rename gdbsupport/{ptid.c => ptid.cc} (100%)
 rename gdbsupport/{rsp-low.c => rsp-low.cc} (100%)
 rename gdbsupport/{run-time-clock.c => run-time-clock.cc} (100%)
 rename gdbsupport/{safe-strerror.c => safe-strerror.cc} (100%)
 rename gdbsupport/{scoped_mmap.c => scoped_mmap.cc} (100%)
 rename gdbsupport/{selftest.c => selftest.cc} (100%)
 rename gdbsupport/{signals-state-save-restore.c => signals-state-save-restore.cc} (100%)
 rename gdbsupport/{signals.c => signals.cc} (100%)
 rename gdbsupport/{tdesc.c => tdesc.cc} (100%)
 rename gdbsupport/{thread-pool.c => thread-pool.cc} (100%)
 rename gdbsupport/{xml-utils.c => xml-utils.cc} (100%)

[1/2] gdbsupport: rename source files to .cc

Commit Message

Comments

Patch