From patchwork Thu Aug 15 06:17:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 34110 Received: (qmail 114114 invoked by alias); 15 Aug 2019 06:17:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 114105 invoked by uid 89); 15 Aug 2019 06:17:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.0 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Aug 2019 06:17:37 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E8451ACCA; Thu, 15 Aug 2019 06:17:34 +0000 (UTC) Subject: [committed][gdb] Fix gdb build on mips64-linux To: Tom Tromey , gdb-patches@sourceware.org References: <20190814144130.10156-1-tromey@adacore.com> From: Tom de Vries Openpgp: preference=signencrypt Message-ID: <57404d17-a184-9121-a174-640a9fc70ade@suse.de> Date: Thu, 15 Aug 2019 08:17:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190814144130.10156-1-tromey@adacore.com> X-IsSubscribed: yes [ was: [FYI] Fix gdb build on macOS ] On 14-08-19 16:41, Tom Tromey wrote: > Internal testing showed that the macOS port did not build. The > breakage was caused by the patch to remove the gdbarch.h include from > defs.h. This patch fixes the problem. > > gdb/ChangeLog > 2019-08-14 Tom Tromey > > * darwin-nat.c: Include gdbarch.h. > * darwin-nat-info.c: Include gdbarch.h. Committed similar for linux-nat-trad.c. Thanks, - Tom [gdb] Fix gdb build on mips64-linux When compiling for mips64-linux, we get: ... src/gdb/linux-nat-trad.c:139:12: error: ‘gdbarch_num_regs’ was not declared \ in this scope 139 | regnum < gdbarch_num_regs (regcache->arch ()); ... Fix this by including gdbarch.h in linux-nat-trad.c, similar to commit b1c896b365 "Fix gdb build on macOS". Build on mips64-linux. gdb/ChangeLog: 2019-08-15 Tom de Vries * linux-nat-trad.c: Include gdbarch.h. --- gdb/linux-nat-trad.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gdb/linux-nat-trad.c b/gdb/linux-nat-trad.c index 04507e8041..c6208dccdb 100644 --- a/gdb/linux-nat-trad.c +++ b/gdb/linux-nat-trad.c @@ -22,6 +22,7 @@ #include "nat/gdb_ptrace.h" #include "inf-ptrace.h" +#include "gdbarch.h" /* Fetch register REGNUM from the inferior. */