From patchwork Wed Mar 8 21:08:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 19494 Received: (qmail 103887 invoked by alias); 8 Mar 2017 21:08:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 103861 invoked by uid 89); 8 Mar 2017 21:08:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.2 spammy=pcb X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Mar 2017 21:08:16 +0000 Received: from ESESSHC013.ericsson.se (Unknown_Domain [153.88.183.57]) by (Symantec Mail Security) with SMTP id 7D.72.32680.EB270C85; Wed, 8 Mar 2017 22:08:14 +0100 (CET) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.57) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 8 Mar 2017 22:08:13 +0100 Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none; sourceware.org; dmarc=none action=none header.from=ericsson.com; Received: from [142.133.50.177] (192.75.88.130) by AM4PR07MB1714.eurprd07.prod.outlook.com (10.166.133.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.961.8; Wed, 8 Mar 2017 21:08:12 +0000 Subject: Re: [PATCH 5/7] Pass ptid to target_fetch_registers To: References: <20170308164140.7281-1-simon.marchi@ericsson.com> <20170308164140.7281-6-simon.marchi@ericsson.com> From: Simon Marchi Message-ID: <567c2be1-ddbc-6728-c122-f78ca1728e09@ericsson.com> Date: Wed, 8 Mar 2017 16:08:04 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170308164140.7281-6-simon.marchi@ericsson.com> X-ClientProxiedBy: BN6PR03CA0045.namprd03.prod.outlook.com (10.175.124.31) To AM4PR07MB1714.eurprd07.prod.outlook.com (10.166.133.22) X-MS-Office365-Filtering-Correlation-Id: 5215c904-99a0-42d0-0272-08d466673b0e X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:AM4PR07MB1714; X-Microsoft-Exchange-Diagnostics: 1; AM4PR07MB1714; 3:CjTnVLk6F8N+Sxoap8NxH3WWiDk8OG9eYB6fUaLO3/YmMbioJ6uG87K3QUVk1dsvA3VMoQyMMLbWcRPXTJ2292j4OfiTvExW1rBPtO3/2vKJLD+1zkl6NQ1w3AhWuiJ8AhnzrFF8cGsRM9fFb/Mf0vnRmy2cPS7s1I1+lswqi57+hxu/ee683hoW2GF2uNGjOipEnjEJ3fHaHOrNX0/kocRxLjuuzRNTn0jrAwrrEs33NDbY8AJiLOjcDt+IJdODoh86vOeeLvnHVO8x108jIQ==; 25:6yCgpAkFjlFJ9d/uCCjtmK/22/vV0xJk6FRfRDMo3cst7mn/3YqfnWyR3CVkxjE+eGnyOkDZUqf4CIrSXHvJpSGBVjx7CZqgfoEZy8N5aoK623PZxtpojqOUm3XdKVU83jygiV1/Eh7kTpzlMpqaJ0NBtCPgBeDyPc8Ik0oWVc+7pZZ2qn1ieACM5kxzg+rYRI0LmqVVlZWWGnTaeZzwRk7b4SqViQPQ7w3UICVG2RwacjTsA9QnfhXK4QxhYFOv5TFXnDaIs0bxeAAbPX2u91Zzl9CvL5LJbvnpAgUalo7W1JQ5TfAYp5bvfcoNHXkJ8rf6RsTJnssouRhFVsbjJ/LEhm6sUoCOE6uHPSFQOhOLfAYebrHAYpXN6DJbmJ9ooS34nwP3rhVgZiAbzxKm6H9+yF8bJktdZbUO4h9Z4R62EOV1rXh5PyXc01DqozRmr7dH+5+xDKrrcwrzmRD7hQ== X-Microsoft-Exchange-Diagnostics: 1; AM4PR07MB1714; 31:0iIc85tsiXCcth2cgmQKtzVRpjltpX33TZ41pHJAs2LlQnU+IZZcX4SxwjE2VjqoP51AXnHgW74i9G1t0RgvvLXzLXM7qaZtm/4dbXV5vE0iQ3NFtFOm06/NZAxwzPHZyiE4gQVh36IW7C7RITr7mm+DDLtIhOQBitiIHYOAMFPrr+cMzxgUoMWyQylQziIkCbd30G8Di2jN4tAKUS3AnBbiLYfvpmj8KdtdjmqVQA6FQkKE16nP5z45EG3ZqavenqsbbJtqLDI7cUWNnIlZpw==; 20:0pYwNil/6r961pArXhXnt2S8/sOhvcn2yysd0pFAO/flqlEQca4AB6K9I6vMhDBEtLN76J2NzoVeMu6XytQRk47Knn1cJFoiSaVzXu4y5Tx8yT0tAIqG7F/JBzoNqvhR/GoMXWOLarMvKqSZMOSKLrLvevPJ6u9OLYaW4DmuaDswlGbU7M0e+UaGE4rY/91IoYgfkjQ49Ddj+KJEtQB7yQiO/yVV+vg6hiGO2hlILSjM3oOPTH/0ISVNotEZ4GrCV5qtaV836fOq9nPgKr2YiMAvuzTkEZ5mkdv/80+XjMYonbDd8lHCU8u3QVyUA8GrNyqUAV/wpdLMgr8lBBFPEsZmcbTG7KjQetQ/rH51iWn5GJ5z0mHnApuOzYOLUzZI/OOYEVrZB3KJscdhEtgLiniZMTbf+7sVW6E8heb08k98MESTyYTDKkQh7f7xsOI+WgQlyElrxL3lrhq1VFJNUYdOGcYDvkc1xhOlcc9NrI0CbBe8cCTh46hKridpA5EQ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123564025)(20161123555025)(20161123560025)(20161123558025)(20161123562025)(6072148); SRVR:AM4PR07MB1714; BCL:0; PCL:0; RULEID:; SRVR:AM4PR07MB1714; X-Microsoft-Exchange-Diagnostics: 1; AM4PR07MB1714; 4:lNpXYkYlEtq7A/QS1fTJTVVqMcg3t/pAYXIuvTu9EOFq8FavUMC5ffil9Xbv/C1CaeT+FksenaFlkqxhcj2r4n4LcNbH+G7kAsAOP4yFbm9AxVzAguRfCmmc1MknrL2p8nlysnRakioJKNF2igpo5FqDugkloqoIiqc0+RoNmHBmSI6axkNMyYR/GBsvkOAijtK19pTG2dPU6639r0B3vaaPTuN8T9WAxD+F5eIq6GgzrComd2M7RE/maIYZaJJlo8kZxKYizFqSK7JOnujO8/lr9WYWWQvL0RVMGn9OebQkrsjTOcpeto1O63m1ffBUQcmj5Sm/5z0QrqVMQK+CUclr2hDfbWxWc6qmQjCuDHwQeHrpwQQAcNQluX5v2KF/vtX6F0KKmtGKW4K4iZVVS5ARjyT88T3eIDd1ceOxHdDb56Tc6oGsUKddotFTuraej+jd6HvxDMr+AXxeEUtE4cK55Lc+B357KwADvoXOpN9rPY3sDCS5/MbPZd0nlHXptyxYbpN3WtlmgW35c7dV1Dv9BW5wPmMGt8orlFvMLiAJMtfrLav6i0oy/2EToyTkOP5rpc0xbrP1ajIhrJljQZI57XcUTxn7V2dJUqMsFLE= X-Forefront-PRVS: 02408926C4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6049001)(6009001)(39450400003)(24454002)(377454003)(377424004)(575784001)(50986999)(3846002)(86362001)(42186005)(6116002)(189998001)(5660300001)(33646002)(305945005)(65826007)(229853002)(54356999)(47776003)(76176999)(7736002)(65956001)(31696002)(66066001)(65806001)(50466002)(230700001)(2351001)(23746002)(6666003)(8676002)(31686004)(6486002)(6916009)(36756003)(81166006)(6246003)(83506001)(53546006)(25786008)(110136004)(2906002)(38730400002)(53936002)(2950100002)(90366009); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR07MB1714; H:[142.133.50.177]; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; AM4PR07MB1714; 23:1ampOYK0i+4Rr1n4dmdXmN6/0e5B2zPv6jrL4?= =?Windows-1252?Q?9wndnvVk8s4R2OmbwNIkkqtlZoEmkAXTW6KoedckWvxIkfP0qPYFFa67?= =?Windows-1252?Q?1dqLWMRAKlbZtWZkkgcZc84/iDukZWNL3MQEzcWPTVe+qSQGEsJaa6+f?= =?Windows-1252?Q?1XbU4u2UxKXd4hMH9TLm+D3MsMh98oVvkz2iMqyW0qmH+dqztM1f3ixd?= =?Windows-1252?Q?zo4c5gOjgcp0GenSgiVbH3lIZorXnUfQ+OJKoyDhUY96N0tZlHM7w2LU?= =?Windows-1252?Q?PApBDkNjDcX3O1L8li3Wd4b2L5rnyqzwyoObhsYoScVA2slZsZhBYhQ9?= =?Windows-1252?Q?XVPfg0cBXDVuRUOsQl7x7AeDsCKd6SUejio/lRrGVeL5YKFlx8biCIsQ?= =?Windows-1252?Q?NfRo6JCK+4vhZgG58yB3YOpL1TfQ1pPsFVMgmR/xyUI0uAcjn3CsUd3+?= =?Windows-1252?Q?jcVJ7GXxVXcV/rnY2FqAA8vMVsUJp0AU9aekR2WtVPJmy2XTD/5sawIK?= =?Windows-1252?Q?a1/MbpL5ObNYngZ3wMPoEcLrNVbqHP3jG2p8KRjqQiOFjdNhCBRb2+ZC?= =?Windows-1252?Q?GxBlzTQlQf4Q8tqsIxvF/Uv2r/v/PsSXygvsKvxz6vT4LngQhQRfFyS1?= =?Windows-1252?Q?5Wzv9SOlws0ZO5TkpAvTZyXI93fD9WX7BTa8AFu9OBp/W8P0iSKmzLuO?= =?Windows-1252?Q?wWfjtooU3sZPCQOsKTppn4s7QbxcvLaH/Sbue3wBc8yKV/Zt6sXeR0sd?= =?Windows-1252?Q?SI8uEiU8EusPTtWLPvPMWAJSESe/1TX7l/PLt8eW83CYeCZTUSP0TY9d?= =?Windows-1252?Q?UmasMOi4GluY4VYcibAr3dcE063Hd3JAQbIYdvCW17So+R8kzKQsXwtV?= =?Windows-1252?Q?gc79D0yK0D3SoZTzwXy+rECPhopghm2h81aGWTW0T73UL3FvFEwdD7Md?= =?Windows-1252?Q?r5Lmd+of+p5X+0xHLFJmqGU3aRC2ntP7TXVL033dmTxFgBLYs4Tyf7fL?= =?Windows-1252?Q?byXwSHUJoVg9y12GMiBK5aJzkBqQi7Hy5Sk6p+hynQYo/MVr0rINjsbk?= =?Windows-1252?Q?BZEifFJO8LMjawwaQfxX2QpH8/Ghyq3Qq4o6zueuf3a+fYwnxixCycfQ?= =?Windows-1252?Q?qAsvXwlRR4qzvOHh3IXW4al0Vjv5CKxHWRXoEwoksxBLrNyUEFphhgHK?= =?Windows-1252?Q?zASDoMyZe4ejFWrL5BdqOT8qjJCNnpdoDFfiVCABEttlssfTkWJLxvea?= =?Windows-1252?Q?8V8qd+q1ZISzFVCrA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; AM4PR07MB1714; 6:XgxBSkFK0oDng7KFz3AAwIBBUDhK8URMecNZls5cuKcTT+su+GrJjxtBqmA/q6YGPKPirEnFXWQHXergKeZnou3E3FPctG3SJHOqq9uxWnG9qhe1Q7LOJt6eychwRSgnmLqu8C0lOPAl5zf59OOCmTc4k4orpjZ23/Ut+tVnvmmlyjhxUKsRrRyVfUp+KU6bCLeZWv9DFPJeT2Zl/9zBDjIMSTKJMp7Ag6LYsPVqSmfMZSCeoyFiTfGFvbyEQnnCZlbpoQ/Cjgfji1PJLbbDohH1ZkIbMxhybwrACJD3UlPfhS4BJRVz/+zvKdpI0BNYIcrG4/tQr2CrXZg/lhIzoTWyyU6sruh3GJSBEEF9vp5el3oghBWBl8je0f8TmjtCaYMEphPoBHMv0nPzRjLDYA==; 5:AhXvTEuG8kO/uFLwHa6Q0uZ14oFpkxaW1uJft0puafvB8hpPnLsPMMWY5c1nzQCIDva3YqhVnK2uOhdIn91n9QGBVluRH0bkLUcrrSX3b5JOVTcZhckkiIvwR0mk8e0y+GZOEmvneElYBXRurrW1qQFuoxrzCak6fxfhqfyStEE=; 24:RfAIobetXjLz0NscTEKu0W5MmCnkID78z87Y9iOisF2KNK94WktvWDUbBeWcoqDnPhvw23ZMdoM8GVJepFlPjONihKgShPpmXK4cLnD16so= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM4PR07MB1714; 7:8ThN4jVOIh/7NDpIFg8yPQn3d6uoSuPPCCyfgbYzolfdrjmnx4A14KMS4ib1Fey+Tna4dD0CEOsLJtuJOAYpEsAGXvIcnjR0zfHFP6VEJvL0cp6o1htsPnug79MKJa+VLSbrG2bnkF32hjwr5Y3dA427fc3pscYtolmsUD+95vUY/je4C/WPizziUZIeCubOcVCFZYQtbBQN1/68lKH/IklkKtSfLk6tFwfL4CBMl6koy/MQ0/rcVg1AjBOQUt8JDxcYd+dC4IVYh3SLk6ZRlLT4TSGXlpNk87JIUJaEW8zi9JG6sEjKrWOxxY7CH6zA3P7HlbPdr9IV3CX+mNpk6Q== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2017 21:08:12.1083 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR07MB1714 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes On 17-03-08 11:41 AM, Simon Marchi wrote: > This patch adds a ptid parameter to the target_fetch_registers and the > to_fetch_registers method of target_ops. The implementations are > therefore expected to rely on this and not on inferior_ptid. I managed to build GDB on FreeBSD, and it showed I had forgotten a few spots in bsd-kvm.c. Consider this diff to be part of the patch as well: diff --git a/gdb/bsd-kvm.c b/gdb/bsd-kvm.c index 7ca59ba2b9..2eac0d5289 100644 --- a/gdb/bsd-kvm.c +++ b/gdb/bsd-kvm.c @@ -98,7 +98,7 @@ bsd_kvm_open (const char *arg, int from_tty) add_thread_silent (bsd_kvm_ptid); inferior_ptid = bsd_kvm_ptid; - target_fetch_registers (get_current_regcache (), -1); + target_fetch_registers (get_current_regcache (), inferior_ptid, -1); reinit_frame_cache (); print_stack_frame (get_selected_frame (NULL), 0, SRC_AND_LOC, 1); @@ -297,7 +297,7 @@ bsd_kvm_proc_cmd (char *arg, int fromtty) if (kvm_read (core_kd, addr, &bsd_kvm_paddr, sizeof bsd_kvm_paddr) == -1) error (("%s"), kvm_geterr (core_kd)); - target_fetch_registers (get_current_regcache (), -1); + target_fetch_registers (get_current_regcache (), inferior_ptid, -1); reinit_frame_cache (); print_stack_frame (get_selected_frame (NULL), 0, SRC_AND_LOC, 1); @@ -317,7 +317,7 @@ bsd_kvm_pcb_cmd (char *arg, int fromtty) bsd_kvm_paddr = (struct pcb *)(u_long) parse_and_eval_address (arg); - target_fetch_registers (get_current_regcache (), -1); + target_fetch_registers (get_current_regcache (), inferior_ptid, -1); reinit_frame_cache (); print_stack_frame (get_selected_frame (NULL), 0, SRC_AND_LOC, 1);