From patchwork Mon Dec 21 12:48:25 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pedro Alves X-Patchwork-Id: 10091 Received: (qmail 95160 invoked by alias); 21 Dec 2015 12:48:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 95151 invoked by uid 89); 21 Dec 2015 12:48:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=no version=3.3.2 spammy=display.exp, displayexp, UD:display.exp, 194, 9 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 21 Dec 2015 12:48:27 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id B86A3218F; Mon, 21 Dec 2015 12:48:26 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tBLCmPus024344; Mon, 21 Dec 2015 07:48:25 -0500 Message-ID: <5677F519.2010000@redhat.com> Date: Mon, 21 Dec 2015 12:48:25 +0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] Remove HP-UX references fom testsuite References: <1450567845-27030-1-git-send-email-simon.marchi@polymtl.ca> <1450567845-27030-3-git-send-email-simon.marchi@polymtl.ca> In-Reply-To: <1450567845-27030-3-git-send-email-simon.marchi@polymtl.ca> I looked this one over too. A few minor comments below, but otherwise looks good to me. Thanks for doing this! On 12/19/2015 11:30 PM, Simon Marchi wrote: > * gdb.multi/bkpt-multi-exec.ex: Likewise.p Typo: "ex: Likewise.p" -> "exp: Likewise." > +gdb_test_multiple "catch vfork" "$name" { > + -re "Catchpoint \[0-9\]* .vfork..*$gdb_prompt $" { > + pass $name > + } > + -re "Catch of vfork not yet implemented.*$gdb_prompt $" { This case can be removed. GDB doesn't ever output this. > + pass $name > } > } > > --- a/gdb/testsuite/gdb.base/display.exp > +++ b/gdb/testsuite/gdb.base/display.exp > @@ -194,15 +194,9 @@ gdb_test "print/r j" " = 0x0\[\\r\\n\]+" "debug test output 2a" > gdb_test "print j" " = 0\[\\r\\n\]+" "debug test output 3" > > # x/0 j doesn't produce any output and terminates PA64 process when testing > -if [istarget "hppa2.0w-hp-hpux11*"] { > - xfail "'x/0 j' terminates PA64 process - skipped test point" > -} else { > - gdb_test_no_output "x/0 j" > -} > -if [istarget "hppa*-hp-hpux*"] { > - # on HP-UX you could access the first page without getting an error > - gdb_test "x/rx j" ".*(Cannot access|Error accessing) memory.*|.*0xa:\[ \t\]*\[0-9\]+.*" > -} > +gdb_test_no_output "x/0 j" > + > +gdb_test "x/rx j" ".*(Cannot access|Error accessing) memory.*|.*0xa:\[ \t\]*\[0-9\]+.*" This last one used to only run on hpux. It seems like it'll now fail on is_address_zero_readable targets -- the non-error alternative assumes the variable's value is "0xa" ? You could guard it with "if [is_address_zero_readable]", but, that proc does "x 0" internally, so it sounds like it'd be pointless? > gdb_test "print/0 j" ".*Item count other than 1 is meaningless.*" "print/0 j" > gdb_test "print/s sum" " = 1000" "ignored s" > --- a/gdb/testsuite/gdb.dwarf2/pr10770.c > +++ b/gdb/testsuite/gdb.dwarf2/pr10770.c > @@ -4,7 +4,6 @@ > /* HP-UX libunwind.so doesn't provide _UA_END_OF_STACK */ > /* { dg-do run } */ > /* { dg-options "-fexceptions" } */ > -/* { dg-skip-if "" { "ia64-*-hpux11.*" } { "*" } { "" } } */ > /* Verify DW_OP_* handling in the unwinder. */ > > #include You should remove the HP-UX reference at the top too then. But, GDB doesn't use the dg-* markers. Note the comment at the top: /* This file comes from GCC. If you are tempted to change it, consider also changing the copy there. */ I'd either leave it be, or, remove the whole dg-* comment block. Comparing our copy to the gcc copy, that's the only bit that diverged so far: $ diff -up ~/gdb/mygit/src/gdb/testsuite/gdb.dwarf2/pr10770.c src/gcc/testsuite/gcc.dg/cleanup-13.c Thanks, Pedro Alves --- /home/pedro/gdb/mygit/src/gdb/testsuite/gdb.dwarf2/pr10770.c 2015-05-08 17:35:43.878768249 +0100 +++ src/gcc/testsuite/gcc.dg/cleanup-13.c 2015-08-22 16:16:35.514064275 +0100 @@ -1,10 +1,8 @@ -/* This file comes from GCC. If you are tempted to change it, - consider also changing the copy there. */ - /* HP-UX libunwind.so doesn't provide _UA_END_OF_STACK */ /* { dg-do run } */ /* { dg-options "-fexceptions" } */ /* { dg-skip-if "" { "ia64-*-hpux11.*" } { "*" } { "" } } */ +/* { dg-skip-if "" { ! nonlocal_goto } { "*" } { "" } } */ /* Verify DW_OP_* handling in the unwinder. */ #include