From patchwork Wed Nov 18 16:21:28 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 9725 Received: (qmail 72904 invoked by alias); 18 Nov 2015 16:21:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 72884 invoked by uid 89); 18 Nov 2015 16:21:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 18 Nov 2015 16:21:31 +0000 Received: from EUSAAHC003.ericsson.se (Unknown_Domain [147.117.188.81]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 7B.9E.32596.D734C465; Wed, 18 Nov 2015 10:23:10 +0100 (CET) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.83) with Microsoft SMTP Server id 14.3.248.2; Wed, 18 Nov 2015 11:21:28 -0500 Subject: Re: [pushed/ob] Constify value_cstring To: Pedro Alves , References: <1447862472-3721-1-git-send-email-palves@redhat.com> From: Simon Marchi Message-ID: <564CA588.3030308@ericsson.com> Date: Wed, 18 Nov 2015 11:21:28 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447862472-3721-1-git-send-email-palves@redhat.com> X-IsSubscribed: yes On 15-11-18 11:01 AM, Pedro Alves wrote: > From: Simon Marchi > > gdb/ChangeLog: > 2015-11-18 Simon Marchi > > * valops.c (value_cstring): Constify 'ptr' parameter. > * value.h (value_cstring): Constify 'ptr' parameter. > --- > gdb/ChangeLog | 5 +++++ > gdb/valops.c | 2 +- > gdb/value.h | 2 +- > 3 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index a7b44fe..32f8134 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,3 +1,8 @@ > +2015-11-18 Simon Marchi > + > + * valops.c (value_cstring): Constify 'ptr' parameter. > + * value.h (value_cstring): Constify 'ptr' parameter. > + > 2015-11-18 Yao Qi > > * aarch64-tdep.c (pass_in_v): Add argument len. Add local array > diff --git a/gdb/valops.c b/gdb/valops.c > index 1e372ef..67e6afe 100644 > --- a/gdb/valops.c > +++ b/gdb/valops.c > @@ -1626,7 +1626,7 @@ value_array (int lowbound, int highbound, struct value **elemvec) > } > > struct value * > -value_cstring (char *ptr, ssize_t len, struct type *char_type) > +value_cstring (const char *ptr, ssize_t len, struct type *char_type) > { > struct value *val; > int lowbound = current_language->string_lower_bound; > diff --git a/gdb/value.h b/gdb/value.h > index 0a4bc47..94a2234 100644 > --- a/gdb/value.h > +++ b/gdb/value.h > @@ -696,7 +696,7 @@ extern struct value *value_mark (void); > > extern void value_free_to_mark (struct value *mark); > > -extern struct value *value_cstring (char *ptr, ssize_t len, > +extern struct value *value_cstring (const char *ptr, ssize_t len, > struct type *char_type); > extern struct value *value_string (char *ptr, ssize_t len, > struct type *char_type); > I pushed this one as well... From 7cc3f8e23b5c19a50722adefce986230b191e9cd Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Wed, 18 Nov 2015 11:20:22 -0500 Subject: [PATCH] Constify value_string If we constify value_cstring, we might as well constify this one. gdb/ChangeLog: * valops.c (value_string): Constify 'ptr' parameter. * value.h (value_string): Constify 'ptr' parameter. --- gdb/ChangeLog | 5 +++++ gdb/valops.c | 2 +- gdb/value.h | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index d92ba43..d1b40b8 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,4 +1,9 @@ 2015-11-18 Simon Marchi + + * valops.c (value_string): Constify 'ptr' parameter. + * value.h (value_string): Constify 'ptr' parameter. + +2015-11-18 Simon Marchi Pedro Alves * break-catch-sig.c (signal_catchpoint_print_one): Add cast. diff --git a/gdb/valops.c b/gdb/valops.c index 67e6afe..5e5f685 100644 --- a/gdb/valops.c +++ b/gdb/valops.c @@ -1649,7 +1649,7 @@ value_cstring (const char *ptr, ssize_t len, struct type *char_type) string may contain embedded null bytes. */ struct value * -value_string (char *ptr, ssize_t len, struct type *char_type) +value_string (const char *ptr, ssize_t len, struct type *char_type) { struct value *val; int lowbound = current_language->string_lower_bound; diff --git a/gdb/value.h b/gdb/value.h index 94a2234..eea0e59 100644 --- a/gdb/value.h +++ b/gdb/value.h @@ -698,7 +698,7 @@ extern void value_free_to_mark (struct value *mark); extern struct value *value_cstring (const char *ptr, ssize_t len, struct type *char_type); -extern struct value *value_string (char *ptr, ssize_t len, +extern struct value *value_string (const char *ptr, ssize_t len, struct type *char_type); extern struct value *value_array (int lowbound, int highbound,