From patchwork Tue Oct 20 16:55:54 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aleksandar Ristovski X-Patchwork-Id: 9274 Received: (qmail 100608 invoked by alias); 20 Oct 2015 16:55:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 100432 invoked by uid 89); 20 Oct 2015 16:55:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: smtp-a02.blackberry.com Received: from smtp-a02.blackberry.com (HELO smtp-a02.blackberry.com) (208.65.78.91) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Oct 2015 16:55:57 +0000 Received: from mhs101cnc.rim.net ([10.65.141.79]) by mhs214cnc-app.rim.net with ESMTP; 20 Oct 2015 12:55:55 -0400 Received: from unknown (HELO [10.222.109.89]) ([10.65.140.254]) by mhs101cnc.rim.net with ESMTP; 20 Oct 2015 16:55:55 +0000 Subject: Re: [PATCH 2/3] (patch 2/4, v2) [nto] Implement TARGET_OBJECT_AUXV. To: Pedro Alves , "gdb-patches@sourceware.org" References: <56263FED.3050602@redhat.com> <1445351294-18179-1-git-send-email-aristovski@qnx.com> <1445351294-18179-3-git-send-email-aristovski@qnx.com> <56265BB2.6060204@redhat.com> <562660E9.7000000@qnx.com> <562665DE.1030104@redhat.com> Newsgroups: gmane.comp.gdb.patches From: Aleksandar Ristovski X-Enigmail-Draft-Status: N1110 Message-ID: <5626721A.5060808@qnx.com> Date: Tue, 20 Oct 2015 12:55:54 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <562665DE.1030104@redhat.com> On 15-10-20 12:03 PM, Pedro Alves wrote: > On 10/20/2015 04:42 PM, Aleksandar Ristovski wrote: >> On 15-10-20 11:20 AM, Pedro Alves wrote: >>> Does this result in any visible improvement? I assume that >>> at least, "info auxv" now works [1] [2]. It'd be really nice to have a >>> blurb in the commit log mentioning what motivated this. >> >> Yes, info auxv works on a live process. For the core I have other >> patches that need to go in first, but the mechanism of getting auxv >> remains the same; only determining initial stack changes. > > OK, but please clarify or drop the misleading comment until > those patches go in then. Please push with that fixed. Comment dropped. /* procfs is always 'self-hosted', no byte-order manipulation. */ > >> >> I will add something to the commit log. >> "Fix 'info auxv' for nto." > > Thanks. > >>> [1] - BTW, if you enable gdb.base/auxv.exp on NTO, does it pass? >>> >> >> It fails since we have AT_* entries that are specific to nto, and get >> printed as ??? which causes regex to not match. I have it patched >> internally and print them out, but didn't think it would be acceptable >> upstream. > > Why wouldn't it? If the issue is that the numbers conflict with other > ports, then it can be handled with a gdbarch method. We have added tags with neutrino specific meanings. I'll address that later if that's ok with you. Thanks, Aleksandar Ristovski --- a/gdb/nto-procfs.c +++ b/gdb/nto-procfs.c @@ -934,8 +934,6 @@ procfs_xfer_partial (struct target_ops *ops, enum target_object object, if (err != EOK) return TARGET_XFER_E_IO; - /* Similar as in the case of a core file, we read auxv from - initial_stack. */ initial_stack = procinfo.initial_stack;