[gdb/testsuite] Fix wrong return type in tests
Commit Message
Done (see attached patch).
*** gdb/testsuite/ChangeLog ***
2017-11-29 Thomas Preud'homme <thomas.preudhomme@arm.com>
* gdb.cp/psymtab-parameter.cc (func): Change return type back to long.
Return 0 as a long.
* gdb.cp/psymtab-parameter.exp: Change func's return type back to long.
Testing: Testcase still PASSes with the change.
Best regards,
Thomas
On 29/11/17 12:06, Pedro Alves wrote:
> On 11/29/2017 11:59 AM, Thomas Preudhomme wrote:
>> My apologize, I thought it couldn't be significant since it was not
>> returning anything. I didn't think about the impact on the prototype
>> itself.
>
> No worries. It was easy to miss.
>
> How about making it return 0 instead then?
>
> Yes please, go ahead and push such a fix in.
>
> Thanks,
> Pedro Alves
>
@@ -16,9 +16,10 @@
along with this program. If not, see <http://www.gnu.org/licenses/>. */
template <typename T>
-void
+long
func ()
{
+ return 0L;
}
void
@@ -31,6 +31,6 @@ gdb_test_no_output "set language c++"
# XFAIL than FAIL here. For example -readnow breaks it.
gdb_test_no_output "maintenance info symtabs"
-# GDB has shown only the `void func<short>()' ELF symbol before, not the DWARF
+# GDB has shown only the `long func<short>()' ELF symbol before, not the DWARF
# symbol
gdb_test "complete p 'func<short>(" "p 'func<short>\\(\\)"