From patchwork Mon Jul 27 18:18:23 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 7875 Received: (qmail 40488 invoked by alias); 27 Jul 2015 18:18:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 40476 invoked by uid 89); 27 Jul 2015 18:18:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 27 Jul 2015 18:18:27 +0000 Received: from EUSAAHC005.ericsson.se (Unknown_Domain [147.117.188.87]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id 96.B2.07675.2AD06B55; Mon, 27 Jul 2015 12:53:22 +0200 (CEST) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.89) with Microsoft SMTP Server id 14.3.210.2; Mon, 27 Jul 2015 14:18:23 -0400 Message-ID: <55B675EF.1020702@ericsson.com> Date: Mon, 27 Jul 2015 14:18:23 -0400 From: Simon Marchi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Pedro Alves , Subject: Re: [PATCH 12/14] Factor out float printing code from generic_val_print References: <1436978863-15125-1-git-send-email-simon.marchi@ericsson.com> <1436978863-15125-13-git-send-email-simon.marchi@ericsson.com> <55B160A1.8010107@redhat.com> In-Reply-To: <55B160A1.8010107@redhat.com> X-IsSubscribed: yes On 15-07-23 05:46 PM, Pedro Alves wrote: > On 07/15/2015 05:47 PM, Simon Marchi wrote: >> +/* generic_val_print helper for TYPE_CODE_FLT. */ >> + >> +static void >> +generic_val_print_float (struct type *type, const gdb_byte *valaddr, >> + int embedded_offset, struct ui_file *stream, >> + const struct value *original_value, >> + const struct value_print_options *options) >> +{ >> + if (options->format) >> + { >> + val_print_scalar_formatted (type, valaddr, embedded_offset, >> + original_value, options, 0, stream); >> + } >> + else >> + { >> + print_floating (valaddr + embedded_offset, type, stream); >> + } > > Wrong indentation, it seem. Otherwise OK. > >> +} > > > Thanks, > Pedro Alves Here is what I pushed: From 7784724bb1b8a5732239e27935cd76813b9df35c Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Mon, 27 Jul 2015 14:11:24 -0400 Subject: [PATCH] Factor out float printing code from generic_val_print gdb/ChangeLog: * valprint.c (generic_val_print): Factor out float printing code to ... (generic_val_print_float): ... this new function. --- gdb/ChangeLog | 6 ++++++ gdb/valprint.c | 30 +++++++++++++++++++++--------- 2 files changed, 27 insertions(+), 9 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 782a893..135e789 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,11 @@ 2015-07-27 Simon Marchi + * valprint.c (generic_val_print): Factor out float + printing code to ... + (generic_val_print_float): ... this new function. + +2015-07-27 Simon Marchi + * valprint.c (generic_val_print): Factor out char printing code to ... (generic_val_print_char): ... this new function. diff --git a/gdb/valprint.c b/gdb/valprint.c index c8f1e0a..0bce438 100644 --- a/gdb/valprint.c +++ b/gdb/valprint.c @@ -707,6 +707,25 @@ generic_val_print_char (struct type *type, struct type *unresolved_type, } } +/* generic_val_print helper for TYPE_CODE_FLT. */ + +static void +generic_val_print_float (struct type *type, const gdb_byte *valaddr, + int embedded_offset, struct ui_file *stream, + const struct value *original_value, + const struct value_print_options *options) +{ + if (options->format) + { + val_print_scalar_formatted (type, valaddr, embedded_offset, + original_value, options, 0, stream); + } + else + { + print_floating (valaddr + embedded_offset, type, stream); + } +} + /* A generic val_print that is suitable for use by language implementations of the la_val_print method. This function can handle most type codes, though not all, notably exception @@ -794,15 +813,8 @@ generic_val_print (struct type *type, const gdb_byte *valaddr, break; case TYPE_CODE_FLT: - if (options->format) - { - val_print_scalar_formatted (type, valaddr, embedded_offset, - original_value, options, 0, stream); - } - else - { - print_floating (valaddr + embedded_offset, type, stream); - } + generic_val_print_float (type, valaddr, embedded_offset, stream, + original_value, options); break; case TYPE_CODE_DECFLOAT: