From patchwork Mon Jul 27 18:15:51 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 7872 Received: (qmail 35004 invoked by alias); 27 Jul 2015 18:16:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 34994 invoked by uid 89); 27 Jul 2015 18:16:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 27 Jul 2015 18:16:12 +0000 Received: from EUSAAHC001.ericsson.se (Unknown_Domain [147.117.188.75]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id 4C.82.07675.A1D06B55; Mon, 27 Jul 2015 12:51:06 +0200 (CEST) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.77) with Microsoft SMTP Server id 14.3.210.2; Mon, 27 Jul 2015 14:15:51 -0400 Message-ID: <55B67557.8060506@ericsson.com> Date: Mon, 27 Jul 2015 14:15:51 -0400 From: Simon Marchi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Pedro Alves , CC: Simon Marchi Subject: Re: [PATCH 01/14] Factor out print_unpacked_pointer from generic_val_print References: <1436978863-15125-1-git-send-email-simon.marchi@ericsson.com> <1436978863-15125-2-git-send-email-simon.marchi@ericsson.com> <55B16081.5010400@redhat.com> In-Reply-To: <55B16081.5010400@redhat.com> X-IsSubscribed: yes On 15-07-23 05:45 PM, Pedro Alves wrote: > Line too long. Comment seems stale -- there's no UNRESOLVED_ELTTYPE > parameter. > > Otherwise looks good. > > Thanks, > Pedro Alves Fixed, here is what I pushed: From 9f436164d55690a0b3d2e4308bfd8834996b97d1 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Mon, 27 Jul 2015 14:11:18 -0400 Subject: [PATCH] Factor out print_unpacked_pointer from generic_val_print gdb/ChangeLog: * valprint.c (generic_val_print): Factor out print_unpacked_pointer code to ... (print_unpacked_pointer): ... this new function. --- gdb/ChangeLog | 6 ++++++ gdb/valprint.c | 48 +++++++++++++++++++++++++++++++----------------- 2 files changed, 37 insertions(+), 17 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index a03ca35..c36f548 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2015-07-27 Simon Marchi + + * valprint.c (generic_val_print): Factor out + print_unpacked_pointer code to ... + (print_unpacked_pointer): ... this new function. + 2015-07-27 Patrick Palka * event-top.c (handle_sigterm): Don't inspect diff --git a/gdb/valprint.c b/gdb/valprint.c index 52a386a..c643956 100644 --- a/gdb/valprint.c +++ b/gdb/valprint.c @@ -359,6 +359,33 @@ val_print_invalid_address (struct ui_file *stream) fprintf_filtered (stream, _("")); } +/* Print a pointer based on the type of its target. + + Arguments to this functions are roughly the same as those in + generic_val_print. A difference is that ADDRESS is the address to print, + with embedded_offset already added. ELTTYPE represents + the pointed type after check_typedef. */ + +static void +print_unpacked_pointer (struct type *type, struct type *elttype, + CORE_ADDR address, struct ui_file *stream, + const struct value_print_options *options) +{ + struct gdbarch *gdbarch = get_type_arch (type); + + if (TYPE_CODE (elttype) == TYPE_CODE_FUNC) + { + /* Try to print what function it points to. */ + print_function_pointer_address (options, gdbarch, address, stream); + return; + } + + if (options->symbol_print) + print_address_demangle (options, gdbarch, address, stream, demangle); + else if (options->addressprint) + fputs_filtered (paddress (gdbarch, address), stream); +} + /* A generic val_print that is suitable for use by language implementations of the la_val_print method. This function can handle most type codes, though not all, notably exception @@ -414,7 +441,8 @@ generic_val_print (struct type *type, const gdb_byte *valaddr, /* Array of unspecified length: treat like pointer to first elt. */ addr = address + embedded_offset; - goto print_unpacked_pointer; + print_unpacked_pointer (type, elttype, addr, stream, options); + break; case TYPE_CODE_MEMBERPTR: val_print_scalar_formatted (type, valaddr, embedded_offset, @@ -430,22 +458,8 @@ generic_val_print (struct type *type, const gdb_byte *valaddr, } unresolved_elttype = TYPE_TARGET_TYPE (type); elttype = check_typedef (unresolved_elttype); - { - addr = unpack_pointer (type, valaddr + embedded_offset); - print_unpacked_pointer: - - if (TYPE_CODE (elttype) == TYPE_CODE_FUNC) - { - /* Try to print what function it points to. */ - print_function_pointer_address (options, gdbarch, addr, stream); - return; - } - - if (options->symbol_print) - print_address_demangle (options, gdbarch, addr, stream, demangle); - else if (options->addressprint) - fputs_filtered (paddress (gdbarch, addr), stream); - } + addr = unpack_pointer (type, valaddr + embedded_offset); + print_unpacked_pointer (type, elttype, addr, stream, options); break; case TYPE_CODE_REF: