show configuration --without-python

Message ID 55A4E839.504@aegee.org
State New, archived
Headers

Commit Message

Дилян Палаузов July 14, 2015, 10:45 a.m. UTC
  Emit information upon "show configuration", if GDB has no Python 
support, as it is done for Guile.
  

Comments

Doug Evans July 18, 2015, 6:33 p.m. UTC | #1
Dilyan Palauzov <dilyan.palauzov@aegee.org> writes:

> Emit information upon "show configuration", if GDB has no Python
> support, as it is done for Guile.
>
> diff --git a/gdb/top.c b/gdb/top.c
> index 1e30b1c..bd42641 100644
> --- a/gdb/top.c
> +++ b/gdb/top.c
> @@ -1326,6 +1326,10 @@ This GDB was configured as follows:\n\
>    fprintf_filtered (stream, _("\
>               --with-python=%s%s\n\
>  "), WITH_PYTHON_PATH, PYTHON_PATH_RELOCATABLE ? " (relocatable)" : "");
> +#else
> +  fprintf_filtered (stream, _("\
> +             --without-python\n\
> +"));
>  #endif
>  #if HAVE_GUILE
>    fprintf_filtered (stream, _("\

LGTM
[with requisite changelog entry of course]
  
Дилян Палаузов Dec. 12, 2018, 8:01 a.m. UTC | #2
Any progress here?

On Tue, 2015-07-14 at 12:45 +0200, Dilyan Palauzov wrote:
> Emit information upon "show configuration", if GDB has no Python 
> support, as it is done for Guile.
> 
> diff --git a/gdb/top.c b/gdb/top.c
> index 1e30b1c..bd42641 100644
> --- a/gdb/top.c
> +++ b/gdb/top.c
> @@ -1326,6 +1326,10 @@ This GDB was configured as follows:\n\
>     fprintf_filtered (stream, _("\
>                --with-python=%s%s\n\
>   "), WITH_PYTHON_PATH, PYTHON_PATH_RELOCATABLE ? " (relocatable)" : "");
> +#else
> +  fprintf_filtered (stream, _("\
> +             --without-python\n\
> +"));
>   #endif
>   #if HAVE_GUILE
>     fprintf_filtered (stream, _("\
  
Joel Brobecker Dec. 21, 2018, 7:29 a.m. UTC | #3
> Any progress here?

Sorry for the late reply. This looks fine. Do you have write access
to the GDB repository?

> 
> On Tue, 2015-07-14 at 12:45 +0200, Dilyan Palauzov wrote:
> > Emit information upon "show configuration", if GDB has no Python 
> > support, as it is done for Guile.
> > 
> > diff --git a/gdb/top.c b/gdb/top.c
> > index 1e30b1c..bd42641 100644
> > --- a/gdb/top.c
> > +++ b/gdb/top.c
> > @@ -1326,6 +1326,10 @@ This GDB was configured as follows:\n\
> >     fprintf_filtered (stream, _("\
> >                --with-python=%s%s\n\
> >   "), WITH_PYTHON_PATH, PYTHON_PATH_RELOCATABLE ? " (relocatable)" : "");
> > +#else
> > +  fprintf_filtered (stream, _("\
> > +             --without-python\n\
> > +"));
> >   #endif
> >   #if HAVE_GUILE
> >     fprintf_filtered (stream, _("\
  

Patch

diff --git a/gdb/top.c b/gdb/top.c
index 1e30b1c..bd42641 100644
--- a/gdb/top.c
+++ b/gdb/top.c
@@ -1326,6 +1326,10 @@  This GDB was configured as follows:\n\
    fprintf_filtered (stream, _("\
               --with-python=%s%s\n\
  "), WITH_PYTHON_PATH, PYTHON_PATH_RELOCATABLE ? " (relocatable)" : "");
+#else
+  fprintf_filtered (stream, _("\
+             --without-python\n\
+"));
  #endif
  #if HAVE_GUILE
    fprintf_filtered (stream, _("\