From patchwork Wed Aug 10 15:09:03 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pedro Alves X-Patchwork-Id: 14470 Received: (qmail 50400 invoked by alias); 10 Aug 2016 15:09:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 50385 invoked by uid 89); 10 Aug 2016 15:09:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Administrator, administrator, H*MI:sk:2016081, late X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 10 Aug 2016 15:09:06 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6E5D181F03; Wed, 10 Aug 2016 15:09:05 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7AF94LF022020; Wed, 10 Aug 2016 11:09:04 -0400 Subject: [pushed] Quiet ARI gettext checks (Re: New ARI warning Wed Aug 10 01:56:29 UTC 2016) To: GDB Administrator , gdb-patches@sourceware.org References: <20160810015629.GA47929@sourceware.org> From: Pedro Alves Message-ID: <559ce37b-9cc7-4105-8722-8f0674a9a2b2@redhat.com> Date: Wed, 10 Aug 2016 16:09:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160810015629.GA47929@sourceware.org> On 08/10/2016 02:56 AM, GDB Administrator wrote: > 89a90,93 >> gdb/common/signals-state-save-restore.c:46: gettext: _ markup: All messages should be marked up with _. > gdb/common/signals-state-save-restore.c:46: perror_with_name ("sigprocmask"); >> gdb/common/signals-state-save-restore.c:59: gettext: _ markup: All messages should be marked up with _. > gdb/common/signals-state-save-restore.c:59: perror_with_name ("sigaction"); >> gdb/common/signals-state-save-restore.c:87: gettext: _ markup: All messages should be marked up with _. > gdb/common/signals-state-save-restore.c:87: perror_with_name ("sigaction"); >> gdb/common/signals-state-save-restore.c:92: gettext: _ markup: All messages should be marked up with _. > gdb/common/signals-state-save-restore.c:92: perror_with_name ("sigprocmask"); > Fixed with the patch below. Master and 7.12 branch. ----------- From 9be00a778d646d92b7940d74425b58d93cb73d0d Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Wed, 10 Aug 2016 16:07:43 +0100 Subject: [PATCH] Quiet ARI gettext checks The ARI complains about this new file: common/signals-state-save-restore.c:46: warning: gettext: All messages should be marked up with _. common/signals-state-save-restore.c:59: warning: gettext: All messages should be marked up with _. common/signals-state-save-restore.c:87: warning: gettext: All messages should be marked up with _. common/signals-state-save-restore.c:92: warning: gettext: All messages should be marked up with _. Since these are untranslatable strings, use () instead of _(). gdb/ChangeLog: 2016-08-10 Pedro Alves * common/signals-state-save-restore.c (save_original_signals_state, restore_original_signals_state): Wrap perror_with_name arguments with '()'. --- gdb/ChangeLog | 6 ++++++ gdb/common/signals-state-save-restore.c | 8 ++++---- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index eca96db..80c28c9 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2016-08-10 Pedro Alves + + * common/signals-state-save-restore.c + (save_original_signals_state, restore_original_signals_state): + Wrap perror_with_name arguments with '()'. + 2016-08-09 Pedro Alves PR gdb/20418 diff --git a/gdb/common/signals-state-save-restore.c b/gdb/common/signals-state-save-restore.c index 1c00cdd..5269062 100644 --- a/gdb/common/signals-state-save-restore.c +++ b/gdb/common/signals-state-save-restore.c @@ -43,7 +43,7 @@ save_original_signals_state (void) res = sigprocmask (0, NULL, &original_signal_mask); if (res == -1) - perror_with_name ("sigprocmask"); + perror_with_name (("sigprocmask")); for (i = 1; i < NSIG; i++) { @@ -56,7 +56,7 @@ save_original_signals_state (void) continue; } else if (res == -1) - perror_with_name ("sigaction"); + perror_with_name (("sigaction")); /* If we find a custom signal handler already installed, then this function was called too late. */ @@ -84,11 +84,11 @@ restore_original_signals_state (void) continue; } else if (res == -1) - perror_with_name ("sigaction"); + perror_with_name (("sigaction")); } res = sigprocmask (SIG_SETMASK, &original_signal_mask, NULL); if (res == -1) - perror_with_name ("sigprocmask"); + perror_with_name (("sigprocmask")); #endif }