From patchwork Thu Jul 2 13:53:52 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Clifton X-Patchwork-Id: 7470 X-Patchwork-Delegate: vapier@gentoo.org Received: (qmail 16151 invoked by alias); 2 Jul 2015 13:53:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 16141 invoked by uid 89); 2 Jul 2015 13:53:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 02 Jul 2015 13:53:56 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 824EF8F270; Thu, 2 Jul 2015 13:53:55 +0000 (UTC) Received: from [10.36.6.112] (vpn1-6-112.ams2.redhat.com [10.36.6.112]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t62DrrKd029381 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 2 Jul 2015 09:53:54 -0400 Subject: Re: RFA: AArch64 sim To: Andre Vieira , vapier@gentoo.org References: <87vbe8hvfo.fsf@redhat.com> <559501B1.6090801@arm.com> Cc: gdb-patches@sourceware.org From: Nicholas Clifton Message-ID: <55954270.5090803@redhat.com> Date: Thu, 2 Jul 2015 14:53:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <559501B1.6090801@arm.com> Hi Andre, > I realize EXTRA_SIM_CFLAGS with "-lm" is in there to deal with the use > of math lib. Though I think EXTRA_SIM_CFLAGS is being expanded too early > in the compile command, i.e. before libsim.a is passed on. Shouldn't it > be put after libsim.a? As it could potentially cause a linker failure. You are right, although strangely it still works for me... Anyway, please could you test out the patch below. If it works for you then I will check it in. Cheers Nick diff --git a/sim/arm/Makefile.in b/sim/arm/Makefile.in index 7605588..1eeec25 100644 --- a/sim/arm/Makefile.in +++ b/sim/arm/Makefile.in @@ -17,7 +17,8 @@ ## COMMON_PRE_CONFIG_FRAG -SIM_EXTRA_CFLAGS = -DMODET -lm +SIM_EXTRA_CFLAGS = -DMODET +SIM_EXTRA_LIBS = -lm SIM_OBJS = \ wrapper.o \