diff mbox

RFA: AArch64 sim

Message ID 55954270.5090803@redhat.com
State Committed
Delegated to: Mike Frysinger
Headers show

Commit Message

Nick Clifton July 2, 2015, 1:53 p.m. UTC
Hi Andre,

> I realize EXTRA_SIM_CFLAGS with "-lm" is in there to deal with the use
> of math lib. Though I think EXTRA_SIM_CFLAGS is being expanded too early
> in the compile command, i.e. before libsim.a is passed on. Shouldn't it
> be put after libsim.a? As it could potentially cause a linker failure.

You are right, although strangely it still works for me...

Anyway, please could you test out the patch below.  If it works for you 
then I will check it in.

Cheers
   Nick

Comments

Andre Vieira July 2, 2015, 2:43 p.m. UTC | #1
That works for me!

Thank you,
Andre Vieira

On 02/07/15 14:53, Nicholas Clifton wrote:
> Hi Andre,
>
>> I realize EXTRA_SIM_CFLAGS with "-lm" is in there to deal with the use
>> of math lib. Though I think EXTRA_SIM_CFLAGS is being expanded too early
>> in the compile command, i.e. before libsim.a is passed on. Shouldn't it
>> be put after libsim.a? As it could potentially cause a linker failure.
>
> You are right, although strangely it still works for me...
>
> Anyway, please could you test out the patch below.  If it works for you
> then I will check it in.
>
> Cheers
>     Nick
>
> diff --git a/sim/arm/Makefile.in b/sim/arm/Makefile.in
> index 7605588..1eeec25 100644
> --- a/sim/arm/Makefile.in
> +++ b/sim/arm/Makefile.in
> @@ -17,7 +17,8 @@
>
>    ## COMMON_PRE_CONFIG_FRAG
>
> -SIM_EXTRA_CFLAGS = -DMODET -lm
> +SIM_EXTRA_CFLAGS = -DMODET
> +SIM_EXTRA_LIBS = -lm
>
>    SIM_OBJS = \
>           wrapper.o \
>
Nick Clifton July 2, 2015, 3:20 p.m. UTC | #2
Hi Andre,

> That works for me!

Great - I have checked the patch in along with this changelog entry.

Cheers
   Nick

sim/arm/ChangeLog
2015-07-02  Nick Clifton  <nickc@redhat.com>

	* Makefile.in (SIM_EXTRA_CFLAGS): Revert previous delta.
	(SIM_EXTRA_LIBS): Add -lm.
diff mbox

Patch

diff --git a/sim/arm/Makefile.in b/sim/arm/Makefile.in
index 7605588..1eeec25 100644
--- a/sim/arm/Makefile.in
+++ b/sim/arm/Makefile.in
@@ -17,7 +17,8 @@ 

  ## COMMON_PRE_CONFIG_FRAG

-SIM_EXTRA_CFLAGS = -DMODET -lm
+SIM_EXTRA_CFLAGS = -DMODET
+SIM_EXTRA_LIBS = -lm

  SIM_OBJS = \
         wrapper.o \