From patchwork Mon Jun 15 22:12:51 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Eager X-Patchwork-Id: 7192 Received: (qmail 51453 invoked by alias); 15 Jun 2015 22:12:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 51441 invoked by uid 89); 15 Jun 2015 22:12:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: homiemail-a78.g.dreamhost.com Received: from sub5.mail.dreamhost.com (HELO homiemail-a78.g.dreamhost.com) (208.113.200.129) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 15 Jun 2015 22:12:53 +0000 Received: from homiemail-a78.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a78.g.dreamhost.com (Postfix) with ESMTP id 24ACB20006457; Mon, 15 Jun 2015 15:12:52 -0700 (PDT) Received: from vm-fedora21.eagercon.com (c-24-7-16-38.hsd1.ca.comcast.net [24.7.16.38]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by homiemail-a78.g.dreamhost.com (Postfix) with ESMTPSA id E31FA20006454; Mon, 15 Jun 2015 15:12:51 -0700 (PDT) Message-ID: <557F4DE3.6020306@eagerm.com> Date: Mon, 15 Jun 2015 15:12:51 -0700 From: Michael Eager User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org CC: Pedro Alves , Doug Evans , =?UTF-8?B?SWFnbyBMw7NwZXogR2FsZWlyYXM=?= Subject: Re: [PATCH 2/9 v2] Introduce nat/linux-namespaces.[ch] References: <1429186791-6867-1-git-send-email-gbenson@redhat.com> <1430395542-16017-3-git-send-email-gbenson@redhat.com> <557EE8F7.5090706@eagerm.com> In-Reply-To: <557EE8F7.5090706@eagerm.com> X-IsSubscribed: yes On 06/15/2015 08:02 AM, Michael Eager wrote: > On 04/30/2015 05:05 AM, Gary Benson wrote: >> This commit introduces new shared files nat/linux-namespaces.[ch] >> containing code to support Linux namespaces that will be used by >> both GDB and gdbserver. >> >> gdb/ChangeLog: >> >> * configure.ac (AC_CHECK_FUNCS): Add setns. >> * config.in: Regenerate. >> * configure: Likewise. >> * nat/linux-namespaces.h: New file. >> * nat/linux-namespaces.c: Likewise. >> * Makefile.in (HFILES_NO_SRCDIR): Add nat/linux-namespaces.h. >> (linux-namespaces.o): New rule. >> * config/aarch64/linux.mh (NATDEPFILES): Add linux-namespaces.o. >> * config/alpha/alpha-linux.mh (NATDEPFILES): Likewise. >> * config/arm/linux.mh (NATDEPFILES): Likewise. >> * config/i386/linux.mh (NATDEPFILES): Likewise. >> * config/i386/linux64.mh (NATDEPFILES): Likewise. >> * config/ia64/linux.mh (NATDEPFILES): Likewise. >> * config/m32r/linux.mh (NATDEPFILES): Likewise. >> * config/m68k/linux.mh (NATDEPFILES): Likewise. >> * config/mips/linux.mh (NATDEPFILES): Likewise. >> * config/pa/linux.mh (NATDEPFILES): Likewise. >> * config/powerpc/linux.mh (NATDEPFILES): Likewise. >> * config/powerpc/ppc64-linux.mh (NATDEPFILES): Likewise. >> * config/powerpc/spu-linux.mh (NATDEPFILES): Likewise. >> * config/s390/linux.mh (NATDEPFILES): Likewise. >> * config/sparc/linux.mh (NATDEPFILES): Likewise. >> * config/sparc/linux64.mh (NATDEPFILES): Likewise. >> * config/tilegx/linux.mh (NATDEPFILES): Likewise. >> * config/xtensa/linux.mh (NATDEPFILES): Likewise. > > This patch causes a build failure in nat/linux-namespaces.c with > glibc-2.5, which does not define MSG_CMSG_CLOEXEC. It looks like > this symbol was introduced in glib-2.7. Here is a patch which allows this to compile if the symbol is not defined. Changelog: * nat/linux-namespaces.c (MSG_CMSG_CLOEXEC): Define if not defined. From 7ccb1f19f15c6ef052d06f1da9e92fda9c2c1fe7 Mon Sep 17 00:00:00 2001 From: Michael Eager Date: Mon, 15 Jun 2015 11:26:12 -0700 Subject: [PATCH] GDB -- Define MSG_CMSG_CLOEXEC if undefined * nat/linux-namespaces.c (MSG_CMSG_CLOEXEC): Define. --- gdb/nat/linux-namespaces.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gdb/nat/linux-namespaces.c b/gdb/nat/linux-namespaces.c index f18e40d..3fc4326 100644 --- a/gdb/nat/linux-namespaces.c +++ b/gdb/nat/linux-namespaces.c @@ -47,6 +47,10 @@ setns (int fd, int nstype) } #endif +#ifndef MSG_CMSG_CLOEXEC +#define MSG_CMSG_CLOEXEC 0 +#endif + /* A Linux namespace. */ struct linux_ns -- 2.2.1