From patchwork Mon Jun 15 18:25:41 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jon Turney X-Patchwork-Id: 7190 Received: (qmail 110302 invoked by alias); 15 Jun 2015 18:25:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 110284 invoked by uid 89); 15 Jun 2015 18:25:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW autolearn=unavailable version=3.3.2 X-HELO: out5-smtp.messagingengine.com Received: from out5-smtp.messagingengine.com (HELO out5-smtp.messagingengine.com) (66.111.4.29) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 15 Jun 2015 18:25:49 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 65BF520A34 for ; Mon, 15 Jun 2015 14:25:46 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute3.internal (MEProxy); Mon, 15 Jun 2015 14:25:46 -0400 Received: from [192.168.1.102] (unknown [86.141.128.210]) by mail.messagingengine.com (Postfix) with ESMTPA id D044D6801AF; Mon, 15 Jun 2015 14:25:45 -0400 (EDT) Message-ID: <557F18A5.2080906@dronecode.org.uk> Date: Mon, 15 Jun 2015 19:25:41 +0100 From: Jon TURNEY User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Andreas Schwab CC: binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PATCH] Allow gdb to find debug symbols file by build-id for PE file format also References: <20150609193638.GM2855@adacore.com> <1433946324-7600-1-git-send-email-jon.turney@dronecode.org.uk> <20150615163431.GF23443@vapier> <87oakgq1pv.fsf@igel.home> In-Reply-To: <87oakgq1pv.fsf@igel.home> On 15/06/2015 19:13, Andreas Schwab wrote: > Mike Frysinger writes: > >> don't know what the policy is here in this header > > It should use bfd_size_type. Patch attached. From 9c96da937babaedd5b23ae352359c3caaf8524ad Mon Sep 17 00:00:00 2001 From: Jon Turney Date: Mon, 15 Jun 2015 19:20:02 +0100 Subject: [PATCH] Fix build when size_t is not available in bfd-in2.h bfd/ChangeLog: 2015-06-15 Jon Turney * bfd.c: Change struct bfd_build_id to use bfd_size_type. * bfd-in2.h : Regenerate. Signed-off-by: Jon Turney --- bfd/ChangeLog | 5 +++++ bfd/bfd-in2.h | 2 +- bfd/bfd.c | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 886da5b..265cc41f 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,8 @@ +2015-06-15 Jon Turney + + * bfd.c: Change struct bfd_build_id to use bfd_size_type. + * bfd-in2.h : Regenerate. + 2015-06-10 Jon Turney * elf-bfd.h : Remove struct elf_build_id. diff --git a/bfd/bfd-in2.h b/bfd/bfd-in2.h index dfffe3c..2d32c74 100644 --- a/bfd/bfd-in2.h +++ b/bfd/bfd-in2.h @@ -6328,7 +6328,7 @@ enum bfd_plugin_format struct bfd_build_id { - size_t size; + bfd_size_type size; bfd_byte data[1]; }; diff --git a/bfd/bfd.c b/bfd/bfd.c index e60f358..8d85de5 100644 --- a/bfd/bfd.c +++ b/bfd/bfd.c @@ -53,7 +53,7 @@ CODE_FRAGMENT . .struct bfd_build_id . { -. size_t size; +. bfd_size_type size; . bfd_byte data[1]; . }; .