From patchwork Mon Jun 15 17:36:46 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 7187 Received: (qmail 57654 invoked by alias); 15 Jun 2015 17:36:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 56755 invoked by uid 89); 15 Jun 2015 17:36:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 15 Jun 2015 17:36:49 +0000 Received: from EUSAAHC008.ericsson.se (Unknown_Domain [147.117.188.96]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 1A.E6.32689.C23BE755; Mon, 15 Jun 2015 13:12:45 +0200 (CEST) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.98) with Microsoft SMTP Server id 14.3.210.2; Mon, 15 Jun 2015 13:36:47 -0400 Message-ID: <557F0D2E.7040200@ericsson.com> Date: Mon, 15 Jun 2015 13:36:46 -0400 From: Simon Marchi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Pedro Alves , Subject: Re: [PATCH v2 2/7] Cleanup some docs about memory write References: <1429127258-1033-1-git-send-email-simon.marchi@ericsson.com> <1429127258-1033-3-git-send-email-simon.marchi@ericsson.com> <555E19B1.3010504@redhat.com> <557B3043.1040302@ericsson.com> <557EA16D.5070706@redhat.com> In-Reply-To: <557EA16D.5070706@redhat.com> X-IsSubscribed: yes On 15-06-15 05:57 AM, Pedro Alves wrote: > On 06/12/2015 08:17 PM, Simon Marchi wrote: > >> Actually it seems obvious now. I'll drop this part from the patch. If we want >> to clarify the comments we should do it for all the functions of the interface >> (in a separate patch). >> >> Well then, all that remains would be to fix that stale comment. Is it ok? > > OK. > > Thanks, > Pedro Alves Thanks, pushed as this: From cb6f16cf4f7a12f9aadddc0451d47f0511729c8d Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Mon, 15 Jun 2015 13:34:47 -0400 Subject: [PATCH] Cleanup write_memory doc This doc about write_memory seems outdated. gdb/ChangeLog: * corefile.c (write_memory): Update doc. * gdbcore.h (write_memory): Same. --- gdb/ChangeLog | 5 +++++ gdb/corefile.c | 4 ++-- gdb/gdbcore.h | 6 ++---- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index db7fb63..a63d894 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2015-06-15 Simon Marchi + + * corefile.c (write_memory): Update doc. + * gdbcore.h (write_memory): Same. + 2015-06-15 Jan Kratochvil * linux-tdep.c (enum filterflags): Make it from anonymous enum. diff --git a/gdb/corefile.c b/gdb/corefile.c index a042e6d..5246f71 100644 --- a/gdb/corefile.c +++ b/gdb/corefile.c @@ -383,8 +383,8 @@ read_memory_typed_address (CORE_ADDR addr, struct type *type) return extract_typed_address (buf, type); } -/* Same as target_write_memory, but report an error if can't - write. */ +/* See gdbcore.h. */ + void write_memory (CORE_ADDR memaddr, const bfd_byte *myaddr, ssize_t len) diff --git a/gdb/gdbcore.h b/gdb/gdbcore.h index a437c8a..0c08b37 100644 --- a/gdb/gdbcore.h +++ b/gdb/gdbcore.h @@ -101,10 +101,8 @@ extern void read_memory_string (CORE_ADDR, char *, int); CORE_ADDR read_memory_typed_address (CORE_ADDR addr, struct type *type); -/* This takes a char *, not void *. This is probably right, because - passing in an int * or whatever is wrong with respect to - byteswapping, alignment, different sizes for host vs. target types, - etc. */ +/* Same as target_write_memory, but report an error if can't + write. */ extern void write_memory (CORE_ADDR memaddr, const gdb_byte *myaddr, ssize_t len);