From patchwork Wed Mar 4 20:50:37 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pedro Alves X-Patchwork-Id: 5459 Received: (qmail 62192 invoked by alias); 4 Mar 2015 20:50:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 61901 invoked by uid 89); 4 Mar 2015 20:50:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 04 Mar 2015 20:50:42 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t24KodAa020802 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 4 Mar 2015 15:50:39 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t24KobuU009772; Wed, 4 Mar 2015 15:50:39 -0500 Message-ID: <54F7701D.5040100@redhat.com> Date: Wed, 04 Mar 2015 20:50:37 +0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Eli Zaretskii CC: gdb-patches@sourceware.org Subject: Re: [PATCH 4/8] remote+docs: software/hardware breakpoint traps References: <1424909852-25917-1-git-send-email-palves@redhat.com> <1424909852-25917-5-git-send-email-palves@redhat.com> <83fv9s62hj.fsf@gnu.org> In-Reply-To: <83fv9s62hj.fsf@gnu.org> On 02/26/2015 04:50 PM, Eli Zaretskii wrote: >> +@item swbreak >> +This feature indicates whether @value{GDBN} supports the swbreak stop >> +reason in stop replies. See @xref{swbreak stop reason}, for details. >> + >> +@item hwbreak >> +This feature indicates whether @value{GDBN} supports the hwbreak stop >> +reason in stop replies. See @xref{swbreak stop reason}, for details. > ^^^^^^^^^ > @xref should always be at the beginning of a sentence, as it generates > text that starts with a capital letter. I think you meant @ref here. Ah, good catch, thanks. I just dropped the See and use @xref, which is the same thing. > >> +If the stub supports non-stop mode, it should also support the >> +@samp{swbreak} stop reason if software breakpoints are supported, and >> +the @samp{hwbreak} stop reason if software breakpoints are supported > ^^^^^^^^ > "hardware", I guess. Indeed. > > Otherwise, OK for the documentation parts. Thanks. I fixed another typo I notice, and push it in, with this merged in: diff --git i/gdb/doc/gdb.texinfo w/gdb/doc/gdb.texinfo index 72fa86c7..4b76ce9 100644 --- i/gdb/doc/gdb.texinfo +++ w/gdb/doc/gdb.texinfo @@ -35214,7 +35214,7 @@ breakpoint address plus an offset. On such targets, the stub is responsible for adjusting the PC to point back at the breakpoint address. -This packet should be not sent by default; older @value{GDBN} versions +This packet should not be sent by default; older @value{GDBN} versions did not support it. @value{GDBN} requests it, by supplying an appropriate @samp{qSupported} feature (@pxref{qSupported}). The remote stub must also supply the appropriate @samp{qSupported} feature @@ -35815,11 +35815,11 @@ instruction reply packet}). @item swbreak This feature indicates whether @value{GDBN} supports the swbreak stop -reason in stop replies. See @xref{swbreak stop reason}, for details. +reason in stop replies. @xref{swbreak stop reason}, for details. @item hwbreak This feature indicates whether @value{GDBN} supports the hwbreak stop -reason in stop replies. See @xref{swbreak stop reason}, for details. +reason in stop replies. @xref{swbreak stop reason}, for details. @end table Stubs should ignore any unknown values for @@ -37633,7 +37633,7 @@ or if the target is not attached to any process, it shall respond If the stub supports non-stop mode, it should also support the @samp{swbreak} stop reason if software breakpoints are supported, and -the @samp{hwbreak} stop reason if software breakpoints are supported +the @samp{hwbreak} stop reason if hardware breakpoints are supported (@pxref{swbreak stop reason}). This is because given the asynchronous nature of non-stop mode, between the time a thread hits a breakpoint and the time the event is finally processed by @value{GDBN}, the