From patchwork Thu Feb 12 11:49:01 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pedro Alves X-Patchwork-Id: 5052 Received: (qmail 4921 invoked by alias); 12 Feb 2015 11:49:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 4897 invoked by uid 89); 12 Feb 2015 11:49:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 12 Feb 2015 11:49:09 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1CBn4tX026174 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 12 Feb 2015 06:49:04 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1CBn1Ts026220; Thu, 12 Feb 2015 06:49:02 -0500 Message-ID: <54DC932D.6000904@redhat.com> Date: Thu, 12 Feb 2015 11:49:01 +0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Andrew Pinski CC: "gdb-patches@sourceware.org" , GCC Patches Subject: Re: [PATCH 09/36] floatformat.h: Wrap in extern "C". References: <1423524046-20605-1-git-send-email-palves@redhat.com> <1423524046-20605-10-git-send-email-palves@redhat.com> <54D94780.9050606@redhat.com> In-Reply-To: <54D94780.9050606@redhat.com> On 02/09/2015 11:49 PM, Pedro Alves wrote: > On 02/09/2015 11:35 PM, Andrew Pinski wrote: >> On Mon, Feb 9, 2015 at 3:20 PM, Pedro Alves wrote: >>> Just like libiberty.h. So that C++ programs, such as GDB when built >>> as a C++ program, can use it. >> >> Why is not needed for GCC building with C++ compiler? > > Because it doesn't include it. > > The header of the file claims it is part of GDB, though MAINTAINERS > nowadays says that everything under include/ is owned by GCC. Here's an update that moves the extern "C" below the #include. OK to push to the GCC repo? From: Pedro Alves Subject: [PATCH] floatformat.h: Wrap in extern "C". Just like libiberty.h. So that C++ programs, such as GDB when built as a C++ program, can use it. include/ChangeLog: 2015-02-12 Pedro Alves * floatformat.h [__cplusplus]: Wrap in extern "C". --- include/floatformat.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/include/floatformat.h b/include/floatformat.h index 6b559864..af4d09c 100644 --- a/include/floatformat.h +++ b/include/floatformat.h @@ -22,6 +22,10 @@ Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA. #include "ansidecl.h" +#ifdef __cplusplus +extern "C" { +#endif + /* A floatformat consists of a sign bit, an exponent and a mantissa. Once the bytes are concatenated according to the byteorder flag, then each of those fields is contiguous. We number the bits with 0 being the most significant @@ -148,4 +152,8 @@ floatformat_from_double (const struct floatformat *, const double *, void *); extern int floatformat_is_valid (const struct floatformat *fmt, const void *from); +#ifdef __cplusplus +} +#endif + #endif /* defined (FLOATFORMAT_H) */