From patchwork Sun Jan 18 07:57:31 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Wei-cheng, Wang" X-Patchwork-Id: 4727 Received: (qmail 27245 invoked by alias); 18 Jan 2015 08:01:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 27066 invoked by uid 89); 18 Jan 2015 08:00:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL, BAYES_00, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f176.google.com Received: from mail-pd0-f176.google.com (HELO mail-pd0-f176.google.com) (209.85.192.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sun, 18 Jan 2015 07:57:46 +0000 Received: by mail-pd0-f176.google.com with SMTP id r10so30610558pdi.7 for ; Sat, 17 Jan 2015 23:57:44 -0800 (PST) X-Received: by 10.66.63.2 with SMTP id c2mr34978613pas.23.1421567864246; Sat, 17 Jan 2015 23:57:44 -0800 (PST) Received: from [192.168.2.3] ([123.110.214.155]) by mx.google.com with ESMTPSA id nm12sm8375797pdb.64.2015.01.17.23.57.41 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 17 Jan 2015 23:57:43 -0800 (PST) Message-ID: <54BB676B.2090101@gmail.com> Date: Sun, 18 Jan 2015 15:57:31 +0800 From: Wei-cheng Wang User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Jan Kratochvil CC: Ulrich Weigand , gdb-patches@sourceware.org, Joel Brobecker Subject: Re: Broken build: rs6000-tdep.c: 32-bit host --enable-targets=all --enable-64-bit-bfd [Re: [PATCH 2/3 v4] Process record support for PowerPC] References: <201501171146.t0HBktpk008932@d03av02.boulder.ibm.com> <20150117185342.GA10419@adacore.com> <20150117212014.GA32152@host2.jankratochvil.net> <54BB3AC2.6050507@gmail.com> <20150118065908.GA12626@host2.jankratochvil.net> In-Reply-To: <20150118065908.GA12626@host2.jankratochvil.net> On 2015/1/18 下午 02:59, Jan Kratochvil wrote: > GDB has paddress(), core_addr_to_string() and hex_string() instead while the > codebase uses these three interchangeably. But the codebase uses even the > %lx+long form. Using %s+paddress instead of %lx+long in this patch. Thanks, Wei-cheng diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c index 75811d1..6e37622 100644 --- a/gdb/rs6000-tdep.c +++ b/gdb/rs6000-tdep.c @@ -3356,7 +3356,6 @@ rs6000_epilogue_frame_cache (struct frame_info *this_frame, void **this_cache) struct rs6000_frame_cache *cache; struct gdbarch *gdbarch = get_frame_arch (this_frame); struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); - CORE_ADDR sp; if (*this_cache) return *this_cache; @@ -3957,8 +3956,8 @@ ppc_process_record_op4 (struct gdbarch *gdbarch, struct regcache *regcache, return 0; } - fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record " - "%08x at %08lx, 4-%d.\n", insn, addr, ext); + fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record %08x " + "at %s, 4-%d.\n", insn, paddress (gdbarch, addr), ext); return -1; } @@ -4000,8 +3999,8 @@ ppc_process_record_op19 (struct gdbarch *gdbarch, struct regcache *regcache, return 0; } - fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record " - "%08x at %08lx, 19-%d.\n", insn, addr, ext); + fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record %08x " + "at %s, 19-%d.\n", insn, paddress (gdbarch, addr), ext); return -1; } @@ -4458,7 +4457,8 @@ ppc_process_record_op31 (struct gdbarch *gdbarch, struct regcache *regcache, case 878: /* Transaction Abort Doubleword Conditional Immediate */ case 910: /* Transaction Abort */ fprintf_unfiltered (gdb_stdlog, "Cannot record Transaction instructions. " - "%08x at %08lx, 31-%d.\n", insn, addr, ext); + "%08x at %s, 31-%d.\n", + insn, paddress (gdbarch, addr), ext); return -1; case 1014: /* Data Cache Block set to Zero */ @@ -4477,8 +4477,8 @@ ppc_process_record_op31 (struct gdbarch *gdbarch, struct regcache *regcache, } UNKNOWN_OP: - fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record " - "%08x at %08lx, 31-%d.\n", insn, addr, ext); + fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record %08x " + "at %s, 31-%d.\n", insn, paddress (gdbarch, addr), ext); return -1; } @@ -4569,8 +4569,8 @@ ppc_process_record_op59 (struct gdbarch *gdbarch, struct regcache *regcache, return 0; } - fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record " - "%08x at %08lx, 59-%d.\n", insn, addr, ext); + fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record %08x " + "at %s, 59-%d.\n", insn, paddress (gdbarch, addr), ext); return -1; } @@ -4582,7 +4582,6 @@ ppc_process_record_op60 (struct gdbarch *gdbarch, struct regcache *regcache, { struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); int ext = PPC_EXTOP (insn); - int tmp; switch (ext >> 2) { @@ -4852,8 +4851,8 @@ ppc_process_record_op60 (struct gdbarch *gdbarch, struct regcache *regcache, return 0; } - fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record " - "%08x at %08lx, 60-%d.\n", insn, addr, ext); + fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record %08x " + "at %s, 60-%d.\n", insn, paddress (gdbarch, addr), ext); return -1; } @@ -5018,8 +5017,8 @@ ppc_process_record_op63 (struct gdbarch *gdbarch, struct regcache *regcache, } - fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record " - "%08x at %08lx, 59-%d.\n", insn, addr, ext); + fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record %08x " + "at %s, 59-%d.\n", insn, paddress (gdbarch, addr), ext); return -1; } @@ -5298,8 +5297,8 @@ ppc_process_record (struct gdbarch *gdbarch, struct regcache *regcache, default: UNKNOWN_OP: - fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record " - "%08x at %08lx, %d.\n", insn, addr, op6); + fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record %08x " + "at %s, %d.\n", insn, paddress (gdbarch, addr), op6); return -1; }