From patchwork Tue Jul 1 13:21:49 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Machado X-Patchwork-Id: 1834 Received: (qmail 29541 invoked by alias); 1 Jul 2014 13:22:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 29487 invoked by uid 89); 1 Jul 2014 13:21:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Jul 2014 13:21:55 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1X1y0N-0003oB-T2 from Luis_Gustavo@mentor.com for gdb-patches@sourceware.org; Tue, 01 Jul 2014 06:21:51 -0700 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 1 Jul 2014 06:21:51 -0700 Received: from [172.30.72.164] (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.2.247.3; Tue, 1 Jul 2014 06:20:58 -0700 Message-ID: <53B2B5ED.40607@codesourcery.com> Date: Tue, 1 Jul 2014 15:21:49 +0200 From: Luis Machado Reply-To: User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: "'gdb-patches@sourceware.org'" Subject: [PATCH] Handle powerpc branch instruction on gdb.trace/entry-values.exp X-IsSubscribed: yes Hi, This testcase currently does not handle powerpc branches. It kinda does in a way, because the arm/aarch64 branch instruction is the same as powerpc's, but the target triplet pattern is not there. In summary, the testcase fails to locate the branch offset and causes a failure and the early termination of the test. The following patch adds a separate conditional block for powerpc (to keep things organized), allowing the testcase to continue. I see full passes and 1 unsupported test now (due to lack of tracepoint support). Luis 2014-07-01 Luis Machado * gdb.trace/entry-values.exp: Handle powerpc-specific branch instruction. diff --git a/gdb/testsuite/gdb.trace/entry-values.exp b/gdb/testsuite/gdb.trace/entry-values.exp index f10ffa6..d648bd1 100644 --- a/gdb/testsuite/gdb.trace/entry-values.exp +++ b/gdb/testsuite/gdb.trace/entry-values.exp @@ -79,6 +79,8 @@ if { [istarget "arm*-*-*"] || [istarget "aarch64*-*-*"] } { set call_insn "bl" } elseif { [istarget "s390*-*-*"] } { set call_insn "brasl" +} elseif { [istarget "powerpc*-*-*"] } { + set call_insn "bl" } else { set call_insn "call" }