Message ID | 537DBDF3.1080907@arm.com |
---|---|
State | Committed |
Headers |
Return-Path: <x14314964@homiemail-mx23.g.dreamhost.com> X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx23.g.dreamhost.com (peon2454.g.dreamhost.com [208.113.200.127]) by wilcox.dreamhost.com (Postfix) with ESMTP id 633EA360073 for <siddhesh@wilcox.dreamhost.com>; Thu, 22 May 2014 02:13:34 -0700 (PDT) Received: by homiemail-mx23.g.dreamhost.com (Postfix, from userid 14314964) id 2A59F64024115; Thu, 22 May 2014 02:13:34 -0700 (PDT) X-Original-To: gdb@patchwork.siddhesh.in Delivered-To: x14314964@homiemail-mx23.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx23.g.dreamhost.com (Postfix) with ESMTPS id 0622B6401C3FD for <gdb@patchwork.siddhesh.in>; Thu, 22 May 2014 02:13:33 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:cc :subject:content-type; q=dns; s=default; b=hEidpu8FkT10Og12pBaWB 58xQAoGlqY0xW/eA5a6oPrgzifY5P29so97Yg0jvqo6cbu0pGS0ZAdVwfNjkwtTF mHYmVDOytUqFrPFxqleXcsNvue1QDDpfGxdAxUUBwcgIXa0MADbsdTywicKPw9mj PK+tmU39vOmaJ5/ammowrU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:cc :subject:content-type; s=default; bh=2n8bBl7prMldnNDUxw5aarxaOfo =; b=bY0/z9jp1IvAr9GlaxuI3ug3WjzLDB+505XstkiG+RHG4nVuIqmKsGyyK0p hqeT9GaTmM4sv7/Egd2+DynXxrUyZiR8OK7pSv/AxFWhFUN5YwaLnU4lwKpqsyLC Nq0XWZCu87HcLxBF4mKozmIu/J8Z+QSDdODnE3q3K3Yn7IMc= Received: (qmail 19316 invoked by alias); 22 May 2014 09:07:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-gdb=patchwork.siddhesh.in@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 9447 invoked by uid 89); 22 May 2014 09:05:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: collaborate-mta1.arm.com Received: from fw-tnat.austin.arm.com (HELO collaborate-mta1.arm.com) (217.140.110.23) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 May 2014 09:05:58 +0000 Received: from [10.1.209.147] (e104577-lin.cambridge.arm.com [10.1.209.147]) by collaborate-mta1.arm.com (Postfix) with ESMTPS id 82DF413F841; Thu, 22 May 2014 04:05:56 -0500 (CDT) Message-ID: <537DBDF3.1080907@arm.com> Date: Thu, 22 May 2014 10:05:55 +0100 From: Ramana Radhakrishnan <ramana.radhakrishnan@arm.com> User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org> CC: Marcus Shawcroft <Marcus.Shawcroft@arm.com> Subject: [Patch AArch64] Include asm/ptrace.h in aarch64-linux-nat.c Content-Type: multipart/mixed; boundary="------------070904080300000607040205" X-DH-Original-To: gdb@patchwork.siddhesh.in |
Commit Message
Ramana Radhakrishnan
May 22, 2014, 9:05 a.m. UTC
Hi, A recent change to glibc removed asm/ptrace.h from user.h for AArch64. This meant that cross-native builds of gdb using trunk glibc broke because aarch64-linux-nat.c because user_hwdebug_state couldn't be found. Fixed by including asm/ptrace.h like other ports. Ok ? regards Ramana 2014-05-22 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com> * aarch64-linux-nat.c (asm/ptrace.h): Include. commit 53278fc086b53264d75ec9cb2a4929565276100a Author: Ramana Radhakrishnan <ramana.radhakrishnan@arm.com> Date: Thu May 22 09:41:41 2014 +0100 Include asm/ptrace.h for recent glibc changes.
Comments
> A recent change to glibc removed asm/ptrace.h from user.h for > AArch64. This meant that cross-native builds of gdb using trunk > glibc broke because aarch64-linux-nat.c because user_hwdebug_state > couldn't be found. > > Fixed by including asm/ptrace.h like other ports. Thanks for the explanation. Can you make sure you include that in the revision history of your commit? > 2014-05-22 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com> > > * aarch64-linux-nat.c (asm/ptrace.h): Include. > OK to push. Thank you. > commit 53278fc086b53264d75ec9cb2a4929565276100a > Author: Ramana Radhakrishnan <ramana.radhakrishnan@arm.com> > Date: Thu May 22 09:41:41 2014 +0100 > > Include asm/ptrace.h for recent glibc changes. > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index 6f5c9c2..95df3e1 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,5 +1,9 @@ > 2014-05-22 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com> > > + * aarch64-linux-nat.c (asm/ptrace.h): Include. > + > +2014-05-22 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com> > + > * MAINTAINERS (Write After Approval): Move self back from > Paper trail. > > diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c > index 28ad38b..877e702 100644 > --- a/gdb/aarch64-linux-nat.c > +++ b/gdb/aarch64-linux-nat.c > @@ -33,6 +33,7 @@ > > #include <sys/ptrace.h> > #include <sys/utsname.h> > +#include <asm/ptrace.h> > > #include "gregset.h" >
On 05/22/14 13:49, Joel Brobecker wrote: >> A recent change to glibc removed asm/ptrace.h from user.h for >> AArch64. This meant that cross-native builds of gdb using trunk >> glibc broke because aarch64-linux-nat.c because user_hwdebug_state >> couldn't be found. >> >> Fixed by including asm/ptrace.h like other ports. > > Thanks for the explanation. Can you make sure you include that > in the revision history of your commit? > >> 2014-05-22 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com> >> >> * aarch64-linux-nat.c (asm/ptrace.h): Include. >> > > OK to push. Thank you. Thanks, pushed. Ramana >
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 6f5c9c2..95df3e1 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2014-05-22 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com> + * aarch64-linux-nat.c (asm/ptrace.h): Include. + +2014-05-22 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com> + * MAINTAINERS (Write After Approval): Move self back from Paper trail. diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c index 28ad38b..877e702 100644 --- a/gdb/aarch64-linux-nat.c +++ b/gdb/aarch64-linux-nat.c @@ -33,6 +33,7 @@ #include <sys/ptrace.h> #include <sys/utsname.h> +#include <asm/ptrace.h> #include "gregset.h"