Drop srcdir from untested source path.

Message ID 534FA596.6040502@arm.com
State Committed
Headers

Commit Message

Marcus Shawcroft April 17, 2014, 9:57 a.m. UTC
  Hi,

Following on from my earlier patch, various gdb tests report the 
absolute path to a source file in UNTESTED outcomes.  This creates noise 
when comparing result output with previous test runs.  This patch drops 
the srcdir prefix from the reported path in one of the offending 
untested calls.

2014-04-17  Marcus Shawcroft  <marcus.shawcroft@arm.com>

	* gdb.java/jnpe.exp: Drop srcdir from untested path.
commit 0e3c473a07b06ebd742478b7a602fcb9ebfc7388
Author: Marcus Shawcroft <marcus.shawcroft@arm.com>
Date:   Mon Mar 31 14:25:36 2014 +0100

    [PATCH] Drop srcdir from untested source path.
  

Comments

Joel Brobecker April 17, 2014, 1:35 p.m. UTC | #1
> 2014-04-17  Marcus Shawcroft  <marcus.shawcroft@arm.com>
> 
> 	* gdb.java/jnpe.exp: Drop srcdir from untested path.

LGTM!

> commit 0e3c473a07b06ebd742478b7a602fcb9ebfc7388
> Author: Marcus Shawcroft <marcus.shawcroft@arm.com>
> Date:   Mon Mar 31 14:25:36 2014 +0100
> 
>     [PATCH] Drop srcdir from untested source path.
> 
> diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
> index c230f8c..e9e8249 100644
> --- a/gdb/testsuite/ChangeLog
> +++ b/gdb/testsuite/ChangeLog
> @@ -1,5 +1,9 @@
>  2014-03-31  Marcus Shawcroft  <marcus.shawcroft@arm.com>
>  
> +	* gdb.java/jnpe.exp: Drop srcdir from untested path.
> +
> +2014-03-31  Marcus Shawcroft  <marcus.shawcroft@arm.com>
> +
>  	* lib/gdb.exp (gdb_compile_pthreads, gdb_compile_objc): Drop prefix
>  	from unsupported source file path.
>  
> diff --git a/gdb/testsuite/gdb.java/jnpe.exp b/gdb/testsuite/gdb.java/jnpe.exp
> index 054ade8..bd47f109c 100644
> --- a/gdb/testsuite/gdb.java/jnpe.exp
> +++ b/gdb/testsuite/gdb.java/jnpe.exp
> @@ -17,7 +17,7 @@ load_lib "java.exp"
>  
>  standard_testfile .java
>  if  { [compile_java_from_source $srcdir/$subdir/$srcfile $binfile "-g"] != "" } {
> -    untested "Couldn't compile ${srcdir}/$subdir/${srcfile}"
> +    untested "Couldn't compile $subdir/${srcfile}"
>      return -1
>  }
>
  

Patch

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index c230f8c..e9e8249 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,9 @@ 
 2014-03-31  Marcus Shawcroft  <marcus.shawcroft@arm.com>
 
+	* gdb.java/jnpe.exp: Drop srcdir from untested path.
+
+2014-03-31  Marcus Shawcroft  <marcus.shawcroft@arm.com>
+
 	* lib/gdb.exp (gdb_compile_pthreads, gdb_compile_objc): Drop prefix
 	from unsupported source file path.
 
diff --git a/gdb/testsuite/gdb.java/jnpe.exp b/gdb/testsuite/gdb.java/jnpe.exp
index 054ade8..bd47f109c 100644
--- a/gdb/testsuite/gdb.java/jnpe.exp
+++ b/gdb/testsuite/gdb.java/jnpe.exp
@@ -17,7 +17,7 @@  load_lib "java.exp"
 
 standard_testfile .java
 if  { [compile_java_from_source $srcdir/$subdir/$srcfile $binfile "-g"] != "" } {
-    untested "Couldn't compile ${srcdir}/$subdir/${srcfile}"
+    untested "Couldn't compile $subdir/${srcfile}"
     return -1
 }