[RFA/testsuite] Remove unused globals from mi-break.exp
Commit Message
Hi,
In a recent email, I asked a contributor to help cleanup some
ridiculously long expect regexps.
Eating my own dog food, I am going to be submitting some new MI
functions which will facilitate regexp construction for breakpoints.
This patch simply removes a bunch of unused globals from mi-break.exp.
Keith
2014-04-15 Keith Seitz <keiths@redhat.com>
* gdb.mi/mi-break.exp (test_tbreak_creation_and_listing): Remove
unused globals.
(test_rbreak_creation_and_listing): Likewise.
(test_ignore_count): Likewise.
(test_error): Likewise.
Comments
On 04/15/2014 04:47 PM, Keith Seitz wrote:
> 2014-04-15 Keith Seitz <keiths@redhat.com>
>
> * gdb.mi/mi-break.exp (test_tbreak_creation_and_listing): Remove
> unused globals.
> (test_rbreak_creation_and_listing): Likewise.
> (test_ignore_count): Likewise.
> (test_error): Likewise.
OK.
Thanks,
On 04/15/2014 11:26 AM, Pedro Alves wrote:
> On 04/15/2014 04:47 PM, Keith Seitz wrote:
>
>> 2014-04-15 Keith Seitz <keiths@redhat.com>
>>
>> * gdb.mi/mi-break.exp (test_tbreak_creation_and_listing): Remove
>> unused globals.
>> (test_rbreak_creation_and_listing): Likewise.
>> (test_ignore_count): Likewise.
>> (test_error): Likewise.
>
> OK.
Pushed. Thank you!
Keith
@@ -56,14 +56,12 @@ set line_callme_body [expr $line_callme_head + 2]
set fullname "fullname=\"${fullname_syntax}${srcfile}\""
proc test_tbreak_creation_and_listing {} {
- global mi_gdb_prompt
global srcfile
global hex
- global line_callee4_head line_callee4_body
- global line_callee3_head line_callee3_body
- global line_callee2_head line_callee2_body
- global line_callee1_head line_callee1_body
- global line_main_head line_main_body
+ global line_callee4_head
+ global line_callee3_head
+ global line_callee2_body
+ global line_main_body
global fullname
# Insert some breakpoints and list them
@@ -98,14 +96,12 @@ proc test_tbreak_creation_and_listing {} {
}
proc test_rbreak_creation_and_listing {} {
- global mi_gdb_prompt
- global srcfile
global hex
- global line_callee4_head line_callee4_body
- global line_callee3_head line_callee3_body
- global line_callee2_head line_callee2_body
- global line_callee1_head line_callee1_body
- global line_main_head line_main_body
+ global line_callee4_body
+ global line_callee3_body
+ global line_callee2_body
+ global line_callee1_body
+ global line_main_body
# Insert some breakpoints and list them
# Also, disable some so they do not interfere with other tests
@@ -165,7 +161,6 @@ proc test_abreak_creation {} {
}
proc test_ignore_count {} {
- global mi_gdb_prompt
global line_callme_body
mi_gdb_test "-break-insert -i 1 callme" \
@@ -179,8 +174,6 @@ proc test_ignore_count {} {
}
proc test_error {} {
- global mi_gdb_prompt
-
mi_gdb_test "-break-insert function_that_does_not_exist" \
".*\\^error,msg=\"Function \\\\\"function_that_does_not_exist\\\\\" not defined.\"" \
"breakpoint at nonexistent function"
@@ -211,7 +204,6 @@ proc test_error {} {
}
proc test_disabled_creation {} {
- global mi_gdb_prompt
global hex
global line_callee2_body