diff mbox

Drop prefix from unsupported source path.

Message ID 533972A1.6030604@arm.com
State Committed
Headers show

Commit Message

Marcus Shawcroft March 31, 2014, 1:50 p.m. UTC 
Hi,

Various gdb tests report the absolute path to a source file in an 
UNSUPPORTED outcome.  This creates noise when comparing result output 
with previous test runs.  This patch drops the directory prefix from the 
reported path in a couple of the offending unsupported calls.

OK?

Cheers
/Marcus

2014-03-31  Marcus Shawcroft  <marcus.shawcroft@arm.com>

	* lib/gdb.exp (gdb_compile_pthreads, gdb_compile_objc):
	Drop prefix from unsupported source file path.

Comments

Marcus Shawcroft April 16, 2014, 9:56 a.m. UTC | #1 
On 31 March 2014 14:50, Marcus Shawcroft <marcus.shawcroft@arm.com> wrote:
> Hi,
>
> Various gdb tests report the absolute path to a source file in an
> UNSUPPORTED outcome.  This creates noise when comparing result output with
> previous test runs.  This patch drops the directory prefix from the reported
> path in a couple of the offending unsupported calls.
>
> OK?

Ping!

Cheers
/Marcus
Joel Brobecker April 16, 2014, 3:34 p.m. UTC | #2 
> Various gdb tests report the absolute path to a source file in an
> UNSUPPORTED outcome.  This creates noise when comparing result
> output with previous test runs.  This patch drops the directory
> prefix from the reported path in a couple of the offending
> unsupported calls.
[...]
> 2014-03-31  Marcus Shawcroft  <marcus.shawcroft@arm.com>
> 
> 	* lib/gdb.exp (gdb_compile_pthreads, gdb_compile_objc):
> 	Drop prefix from unsupported source file path.

Sorry for the delay. This is OK.

> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
> index 73e935a..dd59738 100644
> --- a/gdb/testsuite/lib/gdb.exp
> +++ b/gdb/testsuite/lib/gdb.exp
> @@ -2828,7 +2828,7 @@ proc gdb_compile_pthreads {source dest type options} {
>          }
>      }
>      if {!$built_binfile} {
> -        unsupported "Couldn't compile $source: ${why_msg}"
> +	unsupported "Couldn't compile [file tail $source]: ${why_msg}"
>          return -1
>      }
>  }
> @@ -3000,7 +3000,7 @@ proc gdb_compile_objc {source dest type options} {
>          }
>      }
>      if {!$built_binfile} {
> -        unsupported "Couldn't compile $source: ${why_msg}"
> +        unsupported "Couldn't compile [file tail $source]: ${why_msg}"
>          return -1
>      }
>  }

Thanks,
diff mbox

Patch

diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 73e935a..dd59738 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -2828,7 +2828,7 @@  proc gdb_compile_pthreads {source dest type options} {
         }
     }
     if {!$built_binfile} {
-        unsupported "Couldn't compile $source: ${why_msg}"
+	unsupported "Couldn't compile [file tail $source]: ${why_msg}"
         return -1
     }
 }
@@ -3000,7 +3000,7 @@  proc gdb_compile_objc {source dest type options} {
         }
     }
     if {!$built_binfile} {
-        unsupported "Couldn't compile $source: ${why_msg}"
+        unsupported "Couldn't compile [file tail $source]: ${why_msg}"
         return -1
     }
 }