From patchwork Wed Mar 19 08:02:29 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Hui Zhu X-Patchwork-Id: 155 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx20.g.dreamhost.com (caibbdcaaahc.dreamhost.com [208.113.200.72]) by wilcox.dreamhost.com (Postfix) with ESMTP id 25E9E3600F1 for ; Wed, 19 Mar 2014 01:02:48 -0700 (PDT) Received: by homiemail-mx20.g.dreamhost.com (Postfix, from userid 14314964) id CB01A40DE4FB5; Wed, 19 Mar 2014 01:02:47 -0700 (PDT) X-Original-To: gdb@patchwork.siddhesh.in Delivered-To: x14314964@homiemail-mx20.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx20.g.dreamhost.com (Postfix) with ESMTPS id ADB5040DDDAF0 for ; Wed, 19 Mar 2014 01:02:47 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=E4W684xxZ36BD6GY 3HLcMPnrzYdGa8jfH+tZTADcdVdETM5fY/LVEoZaYITsssn1DPsZlKcHUQqBrNtA L4kIps4FD+WjwoCUCsLz0mS2v2+FQRukcMB2mCobvuf3xYJH037ibvbEQygLvf3L 1UAyUHQ4fkJQ5K1YAWVNqjxbwjE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; s=default; bh=hA+3E+VE/5sRYTgeC/odxz mXkhw=; b=G3loNRYYmKnGveiPc8p3ZH2ZqwoBY008WH6mUAV+HB1t5mfp4u8bm7 7zigckseFqNqosXUDzJuZqcTuF2SD65GurbXb0ROWkZmJ/kJGk5jmhWeIuNiHeki dLZGpr+cOhZnLWfCaDbx0YKfxlLyk5p9DHN0g3tdosvy9+mm6bTeE= Received: (qmail 3210 invoked by alias); 19 Mar 2014 08:02:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 3201 invoked by uid 89); 19 Mar 2014 08:02:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Mar 2014 08:02:43 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1WQBSP-0002aw-EC from Hui_Zhu@mentor.com ; Wed, 19 Mar 2014 01:02:37 -0700 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 19 Mar 2014 01:02:37 -0700 Received: from localhost.localdomain (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.2.247.3; Wed, 19 Mar 2014 01:02:36 -0700 Message-ID: <53294F15.4050503@mentor.com> Date: Wed, 19 Mar 2014 16:02:29 +0800 From: Hui Zhu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Stan Shebs , CC: Eli Zaretskii Subject: Re: [PATCH/doc] Remove fixme of packet "k" References: <5322AE41.4050008@mentor.com> <5328B210.9060702@earthlink.net> In-Reply-To: <5328B210.9060702@earthlink.net> X-IsSubscribed: yes X-DH-Original-To: gdb@patchwork.siddhesh.in On 03/19/14 04:52, Stan Shebs wrote: > On 3/14/14 12:22 AM, Hui Zhu wrote: > > [...] >> So make a patch update doc of 'k' to: >> ‘k’ >> Kill all processes. >> >> The ‘k’ packet has no reply. > > For old packets in the protocol, we need to be careful not to tweak the > description so as to change the meaning. In this case, the effect of > 'k' is not precisely specified; while the current version of GDBserver > has taken it to mean "all inferiors", that may not be true of the stub > I shipped to a customer four years ago. > > As a replacement for the FIXME, I suggest something like > > "Kill the target process or processes." > > "The exact effect of this packet is not specified. For a single-process > target, it will kill that process if possible. A multiple-process > target may choose to kill just one process, or all that that > are under GDB's control. For more precise control, use the vKill packet." > > "The ‘k’ packet has no reply." > > It seems like it should say something about inferiors as well, but > I couldn't think of how to express it clearly. > > Stan > stan@codesourcery.com > Hi Stan, According to your comments. I make a new patch. Thanks, Hui 2014-03-19 Stan Shebs Hui Zhu * gdb.texinfo (k packet): Remove fixme and update introduction. (vKill packet): Add anchor. --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -33952,11 +33952,16 @@ step packet}. @item k @cindex @samp{k} packet -Kill request. +Kill the target process or processes. -FIXME: @emph{There is no description of how to operate when a specific -thread context has been selected (i.e.@: does 'k' kill only that -thread?)}. +The exact effect of this packet is not specified. For a single-process +target, it will kill that process if possible. + +A multiple-process target may choose to kill just one process, or all +that that are under GDB's control. For more precise control, use the +vKill packet.(@pxref{vKill packet}) + +The @samp{k} packet has no reply. @item m @var{addr},@var{length} @cindex @samp{m} packet @@ -34258,6 +34263,7 @@ request is completed. @item vKill;@var{pid} @cindex @samp{vKill} packet +@anchor{vKill packet} Kill the process with the specified process ID. @var{pid} is a hexadecimal integer identifying the process. This packet is used in preference to @samp{k} when multiprocess protocol extensions are