From patchwork Wed Mar 12 12:48:23 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pedro Alves X-Patchwork-Id: 51 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx23.g.dreamhost.com (caibbdcaabja.dreamhost.com [208.113.200.190]) by wilcox.dreamhost.com (Postfix) with ESMTP id 1B6B336007D for ; Wed, 12 Mar 2014 06:37:31 -0700 (PDT) Received: by homiemail-mx23.g.dreamhost.com (Postfix, from userid 14314964) id BF36D61C28C77; Wed, 12 Mar 2014 06:37:30 -0700 (PDT) X-Original-To: gdb@patchwork.siddhesh.in Delivered-To: x14314964@homiemail-mx23.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx23.g.dreamhost.com (Postfix) with ESMTPS id 99EA761C2CD26 for ; Wed, 12 Mar 2014 06:37:30 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; q=dns; s=default; b=yzg/rPu75J61ifP/uK0BqkraonzTyjcyqU19EssZgav 0xU0ad2MKdgZXWoSll3ZS8JeQrBF2rbyQJvRzEJ1VIDpdj8L7xLXEuppcImWAKrn E1L31wzIClO9NOkw5sLhwdwOYQoHbqtlGCFaPZg5PNg31i1m5KMw0DPxwYuoyFJE = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; s=default; bh=gi+ydrq9XdhbKdr3LOoGu2H3Kl8=; b=hZ2Pt93s+33dwWjvJ sTBt9HgraGSN1C2WsxM1eLNAxKqLuz2J1DzSaA22aJg+E1mWaLrB+ZRehObm7EqI kLCHny7ty+fVRlAEGFuwen66cUgeTqCiofNAYmGcuUgYvadjZA0i9CSqpzbtmnFT oDBErym7mXGufTT62mPGyo8zdk= Received: (qmail 23043 invoked by alias); 12 Mar 2014 13:37:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 23003 invoked by uid 89); 12 Mar 2014 13:37:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Mar 2014 13:37:22 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2CDbKTv016937 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 12 Mar 2014 09:37:21 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s2CCmOqr016099 for ; Wed, 12 Mar 2014 08:48:24 -0400 Message-ID: <53205797.3050309@redhat.com> Date: Wed, 12 Mar 2014 12:48:23 +0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Rename Solaris's target to "target child" like most other ports. References: <1394627872-18619-1-git-send-email-palves@redhat.com> In-Reply-To: <1394627872-18619-1-git-send-email-palves@redhat.com> X-DH-Original-To: gdb@patchwork.siddhesh.in On 03/12/2014 12:37 PM, Pedro Alves wrote: > I wonder whether anyone would miss this badly? The difference would be: > > (gdb) maint print target-stack > The current target stack is: > - multi-thread (multi-threaded child process.) > - - child (Unix child process) > + - child (Child process) > - exec (Local exec file) > - None (None) > > (gdb) help target child > - Unix child process (started by the "run" command). > + Child process (started by the "run" command). > > I find it unnecessary (and really slightly a lie) on GNU/Linux. > > It's also odd that e.g., the Windows port says "Unix" in reaction to > "target child" (it was already that way before Windows used > inf-child.c). > > How about we just say the same mostly everywhere? > > In the same vein, I'd also rename Solaris/procfs.c's "target procfs" > to "target child". Like this. (Untested.) ------- [PATCH] Rename Solaris's target to "target child" like most other ports. Note that "target procfs" is used by QNX, but the test must be failing there, as nto-procfs.c overrides to_open with a method that doesn't throw the error being tested. So I'm just removing the test completely. gdb/ 2014-03-12 Pedro Alves * procfs.c (procfs_target): Don't override to_shortname, to_longname or to_doc. gdb/testsuite/ 2014-03-12 Pedro Alves * gdb.base/default.exp: Don't test "target procfs". --- gdb/procfs.c | 4 ---- gdb/testsuite/gdb.base/default.exp | 3 --- 2 files changed, 7 deletions(-) diff --git a/gdb/procfs.c b/gdb/procfs.c index 8204747..f0d65d2 100644 --- a/gdb/procfs.c +++ b/gdb/procfs.c @@ -184,10 +184,6 @@ procfs_target (void) { struct target_ops *t = inf_child_target (); - t->to_shortname = "procfs"; - t->to_longname = "Unix /proc child process"; - t->to_doc = - "Unix /proc child process (started by the \"run\" command)."; t->to_create_inferior = procfs_create_inferior; t->to_kill = procfs_kill_inferior; t->to_mourn_inferior = procfs_mourn_inferior; diff --git a/gdb/testsuite/gdb.base/default.exp b/gdb/testsuite/gdb.base/default.exp index b63955e..a39ffcf 100644 --- a/gdb/testsuite/gdb.base/default.exp +++ b/gdb/testsuite/gdb.base/default.exp @@ -749,9 +749,6 @@ gdb_test "symbol-file" ".*" "symbol-file" #test target child gdb_test "target child" "Use the \"run\" command to start a child process.*|Undefined target command: \"child\". *Try \"help target\".*" "target child" -#test target procfs -gdb_test "target procfs" "Use the \"run\" command to start a child process.*|Undefined target command: \"procfs\". *Try \"help target\".*" "target procfs" - #test target core send_gdb "target core\n" gdb_expect {