Message ID | 53205797.3050309@redhat.com |
---|---|
State | Committed |
Headers | show |
> Like this. (Untested.) > > ------- > [PATCH] Rename Solaris's target to "target child" like most other > ports. > > Note that "target procfs" is used by QNX, but the test must be failing > there, as nto-procfs.c overrides to_open with a method that doesn't > throw the error being tested. So I'm just removing the test > completely. > > gdb/ > 2014-03-12 Pedro Alves <palves@redhat.com> > > * procfs.c (procfs_target): Don't override to_shortname, > to_longname or to_doc. > > gdb/testsuite/ > 2014-03-12 Pedro Alves <palves@redhat.com> > > * gdb.base/default.exp: Don't test "target procfs". FWIW, this looks good to commit to me, even if untested. In the very unlikely even that it does break somethhing, I will take care of it then.
On 03/13/2014 07:39 AM, Joel Brobecker wrote: >> Like this. (Untested.) >> >> ------- >> [PATCH] Rename Solaris's target to "target child" like most other >> ports. >> >> Note that "target procfs" is used by QNX, but the test must be failing >> there, as nto-procfs.c overrides to_open with a method that doesn't >> throw the error being tested. So I'm just removing the test >> completely. >> >> gdb/ >> 2014-03-12 Pedro Alves <palves@redhat.com> >> >> * procfs.c (procfs_target): Don't override to_shortname, >> to_longname or to_doc. >> >> gdb/testsuite/ >> 2014-03-12 Pedro Alves <palves@redhat.com> >> >> * gdb.base/default.exp: Don't test "target procfs". > > FWIW, this looks good to commit to me, even if untested. In the very > unlikely even that it does break somethhing, I will take care of it > then. Thanks Joel. Pushed.
diff --git a/gdb/procfs.c b/gdb/procfs.c index 8204747..f0d65d2 100644 --- a/gdb/procfs.c +++ b/gdb/procfs.c @@ -184,10 +184,6 @@ procfs_target (void) { struct target_ops *t = inf_child_target (); - t->to_shortname = "procfs"; - t->to_longname = "Unix /proc child process"; - t->to_doc = - "Unix /proc child process (started by the \"run\" command)."; t->to_create_inferior = procfs_create_inferior; t->to_kill = procfs_kill_inferior; t->to_mourn_inferior = procfs_mourn_inferior; diff --git a/gdb/testsuite/gdb.base/default.exp b/gdb/testsuite/gdb.base/default.exp index b63955e..a39ffcf 100644 --- a/gdb/testsuite/gdb.base/default.exp +++ b/gdb/testsuite/gdb.base/default.exp @@ -749,9 +749,6 @@ gdb_test "symbol-file" ".*" "symbol-file" #test target child gdb_test "target child" "Use the \"run\" command to start a child process.*|Undefined target command: \"child\". *Try \"help target\".*" "target child" -#test target procfs -gdb_test "target procfs" "Use the \"run\" command to start a child process.*|Undefined target command: \"procfs\". *Try \"help target\".*" "target procfs" - #test target core send_gdb "target core\n" gdb_expect {