From patchwork Fri May 18 19:49:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 27329 Received: (qmail 70506 invoked by alias); 18 May 2018 19:50:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 70482 invoked by uid 89); 18 May 2018 19:50:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_NUMSUBJECT, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 May 2018 19:50:54 +0000 Received: from ESESSHC020.ericsson.se (Unknown_Domain [153.88.183.78]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 93.09.01293.B9E2FFA5; Fri, 18 May 2018 21:50:51 +0200 (CEST) Received: from ESESBMR505.ericsson.se (153.88.183.201) by ESESSHC020.ericsson.se (153.88.183.78) with Microsoft SMTP Server (TLS) id 14.3.382.0; Fri, 18 May 2018 21:50:08 +0200 Received: from ESESBMB503.ericsson.se (153.88.183.170) by ESESBMR505.ericsson.se (153.88.183.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Fri, 18 May 2018 21:50:08 +0200 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB503.ericsson.se (153.88.183.170) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Fri, 18 May 2018 21:50:08 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.48.114] (192.75.88.130) by BN7PR15MB2385.namprd15.prod.outlook.com (2603:10b6:406:8c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.776.11; Fri, 18 May 2018 19:50:06 +0000 Subject: Re: New ARI warning Fri May 18 01:56:48 UTC 2018 To: Simon Marchi , Joel Brobecker CC: References: <20180518015648.GA106395@sourceware.org> <20180518182907.xhpjfk2jj2f3t65e@adacore.com> <9f29119c84b9d58b4499929bb752be78@simark.ca> <20180518190346.4yy6e7dfn7bwascu@adacore.com> From: Simon Marchi Message-ID: <4f3b5ef9-f310-c4a3-a122-fe15aed41ab1@ericsson.com> Date: Fri, 18 May 2018 15:49:55 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: X-ClientProxiedBy: SN2PR01CA0079.prod.exchangelabs.com (2603:10b6:800::47) To BN7PR15MB2385.namprd15.prod.outlook.com (2603:10b6:406:8c::23) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:BN7PR15MB2385; X-Microsoft-Exchange-Diagnostics: 1; BN7PR15MB2385; 3:1MELz9mKgn8x50UOZz65zAxUuRlu0vLlcOYjO5oCWYHU+jcfH8gR0DqJEYuzJEjLxeCn0/+Zb4V3CMH8lBqBp/uWk5Yh7Ke36uVczbeY9oq3VNWyJ7Cuz4clspvuZNHu+HnSiKdDVRDTxS7t4IYQiEio5YYGCGj53vtPkAxVtkCP/kK0DRweXYRkI5NhlT143MwUnE/DD4nLpggvsCH+jBpmonlYIGAwqFyruqm/8aWSEfD7TVSCBBipEhc+JtT5; 25:3CccYBx2KEsWGkmEqR7XhAz6v8rlSmQn9YtZMTTNVTwetqiKVECVZ+dcn/z0YUeyppRY68q0ie0Wj2+M82BykUTfA7rEf9AGNu4pI3i3/B8oqWPnEB95WuYX2xBNoGduF66hI8wkLhxOKaQBQmhF2FEkXxYgr0eu+s+X6eHamoc59uo/0GFjn8ETBjZqRD3yujcUWCitGbZJ2327kiUfqFex0bmYoB+AUr2+DwSvluGO8vRItZ6FGwfx+y5AKTLf8mbH+/9bcOnGw1aNfps7OlnVs4xWtLtDHKNfvPlTtqNNrugz807bO3DGiZFRMG+lYXbAvl9R60ZLwvdyzz6rdQ==; 31:QsAlVNeHuE0W5ptQAFndWKz6dZe1XoO+gTbebQOjgPGAqNdMtz0FjcWf26R+xsIVLwdZkPbw6raSReSoTEDyBKZUiDBHWUG3JuiCMXvh2hSBnhj6M9VM1LQQ1ROyIu2dSZka314M69JAAiLXsbj8MwMnz7lZbxag9DamyOyTmJ8wzCy1CAuFUgoyidOo/9E2Evinl2IZ5YPGwAkH9+B6dRIhT34Xx5RPL032PgE8HAg= X-MS-TrafficTypeDiagnostic: BN7PR15MB2385: X-Microsoft-Exchange-Diagnostics: 1; BN7PR15MB2385; 20:f3JRGqIM570t2W2UmP9zmkGOYWTcIqEZx7sLryj86TtKd8cufLs+9V7vaJ7szC10H0GGrI03iNMtODybgaEvTo6KW1PvgekgJqXT8ctiw2AxZPqP699vxC5+zwGVKuXNFioAC0ZHGgGLOhqlf35fv1XmrMMwHd7hjNZRZ0rgCZHpBshV2txX968TAYbu1hyLPmiuQ5bps+1+AaOSiZnE4cPhdDk8V7ijxBNlalFyTGclYlGxTTXdEfTiBAfdoeIGh0CjrPRsT4K+wjiJO23mtRycK0USnd75b4ITPJPovBJ1rSSqYit/3xobFxyy8/FVDTKI5dFI1K7l7IHrLtU3NV0p0ncOgb1X6feqwA8j93IGvSwZu3BXvngsDMzrDwELTn5Hgy4sFHvPYo4RTW48I/ah+ruvVfIMkUiBLYB3fOVAMRG+rue9akgw6Y3o6Bbpffny6fyfZJih3L30yFNqy1aV9MU/kSHIduRENSHA/rpAcAxN5CVuC73yOXmIHLie; 4:FX+TNUgdzoAdpfYQjgTqKyL0nwnHtVkWtSvOESCQafJKkSoLiU3fmoMuSK5aTElcDhl4C4/1vv9tJqh0lWdOnZSwG9HAY7SapCZ+OyEgen+D/vkeCmUSl58DF7EXK48PPATh555xQQMGMN8RkR1Ep9vBPWQTWWKzpodEH7Y6JDMcozd2iEnxQx4mr6IA31C/mGDxJGj6+nhQxi39rI0eOU5fRQTwSjLbufBFx+etscDLPNADFWICnl/CMVvWJNhn6w0E0UliuaPuzA3Vz/uxXqlNhNjLOI7Z3EGTdLemKkwYBOJ2U2uK+pf4MOQ/61LR X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(37575265505322); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231254)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(149027)(150027)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:BN7PR15MB2385; BCL:0; PCL:0; RULEID:; SRVR:BN7PR15MB2385; X-Forefront-PRVS: 0676F530A9 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(396003)(39860400002)(366004)(346002)(39380400002)(376002)(377424004)(199004)(189003)(54534003)(575784001)(86362001)(4326008)(2906002)(2486003)(7736002)(81156014)(2870700001)(76176011)(305945005)(8676002)(64126003)(93886005)(81166006)(6486002)(229853002)(16576012)(50466002)(110136005)(52116002)(52146003)(31696002)(49976009)(36756003)(23676004)(478600001)(26005)(6666003)(58126008)(65826007)(16526019)(186003)(25786009)(53936002)(65806001)(65956001)(66066001)(6246003)(31686004)(47776003)(97736004)(486006)(11346002)(106356001)(8936002)(6116002)(44832011)(105586002)(59450400001)(956004)(53546011)(68736007)(476003)(2616005)(5660300001)(3846002)(446003)(386003)(316002)(78286006); DIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR15MB2385; H:[142.133.48.114]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjdQUjE1TUIyMzg1OzIzOnJNZjRKckFJdkZNV1lSb3RWNnNBcEZ4U0FI?= =?utf-8?B?ZWVONVJ0OU1welRGbURkK2R5aVdhOUJvcG1xT0U5dEhtSFpTNDNqSzJWQjRM?= =?utf-8?B?RndmRmtZaWg2MUtCM0kveXRiTWNMZWpTVFVLbFJnQ3ZzekVEZG1ET1BKeFFI?= =?utf-8?B?NmdNZEgzSXp1L2xGUmRaK3V2MjZac1F3NVBkZTdvN2pNR240TDMzcmVpYWFy?= =?utf-8?B?cVRXdElNakhOMURJR3NTS3JDckVuL0IvWjQ5RElxN04rWUFycitQY1BwQm9O?= =?utf-8?B?SlRoWEVwbzF6cWNGK054R1Nzd0JSWXdjM0YxN0lIaXQ3clFqVDJFYnlMRi95?= =?utf-8?B?c3oyNHFIYmZkMDBReVpVV1pXSE4zT09SMEtwVkQrSUpGWVU1K0hBdXFBMnZU?= =?utf-8?B?TXhDTCszM0pwQmJKejIzUXpJTVJVWUN3ZkNmalZBTUhNaGhMbGc3V2c4aXZw?= =?utf-8?B?eDExQ0JhUEN4dDZqb0FINm9QUVpVdTFLdkNEU1YzSUVsZ2hQa3hZNzAvSEpi?= =?utf-8?B?SEVXQXlXOFQyUnlBL1hRN0pqM0Z1aXZwSUovYzdzU0xUbUZlNTdWcVkzV1dQ?= =?utf-8?B?Q253cjB6cG1CRzYwY3U5NEFIMXhvRHgzWXZCZEVyU0hFaWdpQ1NCUHB2Tmpw?= =?utf-8?B?YWs3aGIwYVc0c2g3L25CTzM2N0JDaGxmNzlRck81TXlsWHJraHVESkdKdUh4?= =?utf-8?B?V25DUFVFb2NIS3RsVEszUlR3aFpuWXRJR1gzdloyUU1IbHpxRFhMUVVMRVFS?= =?utf-8?B?cFNsYXhkQ0JjN3N5bEFYd2EwNXpZaWxrdW1LVERpZG9PekUxNFR6ck1ZdVZ0?= =?utf-8?B?dW9Ncnh4OGJtd2taMm9iNXl5cDcvRktuMUlQSGN3SEovSzFGeG5qTmNFb25U?= =?utf-8?B?RU1mTDZNaEMwMzZVRWRVQmQxd0ZrTjRNaS8wcDBSTWpQenNyVDJjS1VNT2tu?= =?utf-8?B?aFBFNVF4ZHJJenNTZHphbXJXVnd4STJVZjAyVXNNSk9LblBSa1lhSXhwVnZI?= =?utf-8?B?d2FySWVhajl6MS9RNzVUREpwTlowYzVlMzgxUGVvNVF1Y1cyRm94aktmaWFJ?= =?utf-8?B?YzV1MjY1a3FhQXIvaHhTRW4zZlo5KzBzZlhEZG1WL0JJaURISnJZTW5vTXZY?= =?utf-8?B?eVB5dFlCdWZEN3I0NldmcmZnOWl0WklqZU9xR1pJcGlaOVJVeFlhVGIvWGl6?= =?utf-8?B?cnlzVzg3RDEwQmp5TXRUelgzR2tJOG5pYjJOVitGM1JzMjByM1BZTDdMMHBa?= =?utf-8?B?ZXc2Z2J2NjRNV0VETldwcXF4Si9SamgrQXdZUlVyL2NxVU93WEh1d05MeFNE?= =?utf-8?B?bkdrVXQ0cC8vaVl1OElkVE1QcG5kWDBta1JmZVBrNUZJNmNwMzVsV1ZMUVZI?= =?utf-8?B?RmhNREZSdzhROTJYNElKM0ZsVkl0MmhoRXEvS3VOZnl2ZXRnQTVYdytQb1Fv?= =?utf-8?B?Qlh1WlBnWFlEWVNKZXlZSm0rUldYQkFjcVpVQUN6cyttSUVwWExmeFZLM0VH?= =?utf-8?B?MUUrODNsVlJRTFMwT0V5ZGVvNUVIekYxL2RKbHR6N2oyS2hUSERhRnNhTnN4?= =?utf-8?B?VUVyN3VsSmlDS2lLVHFXOXRnRUdxWXBOV0NEdjNVNjRJVGhPSjV5WHVUL1hN?= =?utf-8?B?encyZGpWcUlHYTd4SjQ1NWQ5SENwMnhSMEJsV2RhWHBERk9pakZXeVlVZzZK?= =?utf-8?B?cWlTTnZpOFM1WXg1dFR5RGExT05Kd3J0aENkVVJlelV4bHBqOGYxT05tbUV1?= =?utf-8?B?bXlJNXdlZjdSZ0NNVm9vQzJFSVFaQ09wai9sLytJODlicGM0ZTdnZFJiNzEv?= =?utf-8?B?Y081T05JaWxPejlHaDNBcXJzNlBlclg0UkpSVDhleEVXMTZWZDlnOWlrWlRq?= =?utf-8?B?V3J1UDFCZzQ1OVlIaUxhamhpYWJGc0pVTWVRYXVVZEltVnFSVEwyaEJJakFw?= =?utf-8?B?VzhzcDZkNHJlYUhSZjI5dmFoaXoxcnhQbEdZY0t3UitEdFRJRjI5SjllMzNV?= =?utf-8?B?VnFrNUxlNmlUbTZQS0MzTDZQRGRrVCtTc1FLZzB4VE8zZ2dJYjE0a3VNSzFi?= =?utf-8?B?ZE9WcEhEWXdpMzQrSTlFdTFVTHBnM3RYY3VCYnUzVGFKZFlDQkhpMW1kRmp3?= =?utf-8?Q?8j+EMcFao1n66343vClN+kQ=3D?= X-Microsoft-Antispam-Message-Info: QHSLvU6etuxXQCEqgi99ovdNmEDicvBazsEINTz0j/aO7t5X9hzEec2BV9rFiVr6Wpka+Lefjk5vCW7KcnJQTobQBJhBcVNKXNFIxMwAnbRzYfJMC+84pWXFt7gT0VFsIEaqJZ6vdtbsDyUfB6UGWAYwWGblUNseFXIaThE/DmNVzZNWNrvIsTmNw3gHKwZo X-Microsoft-Exchange-Diagnostics: 1; BN7PR15MB2385; 6:bxp92VjlFALfRYOApeItUPprN0ZeGNTcpz3c4iyP7M8rDgfzpAEkPGMK+I5ZxckZ0DNoU9Yx5ztPoN4rKxMEJ/tkaJjbjKNr026c3S2ZbAKukNqCdQ6UsnZT05I4ys1nnW7IzT9HvovCfaiIlvbtaLa663nv+NMKXNN2ZGdznBeYuO9YphIJtXfDdkuagl1PXiV+VyLLhbVvxYUKUwC5ZQvpfuKYk41joglZJJ5JEDPsJrDPjsTtJYT6MhSApHz9SEPC4Vtm5Mlk01Xa92xkZeHM3Ljbs6ZvC3BXMbE0PxpButw3soU8GEoV8r3ywA2faJ/fg7In/65WEp9kYyxK7va++ne2GWPyXWV2lXwFJq94S3vqnFc7GIV+XoWmCQx7aAILzbZDluy1TECvd0+WyYTZ9SSJ5Kn2Utq9Af1KoVnmw+Cevas6TXbxiclPcD4unTGJuEcjOQJrHJXfQ1Dd8Q==; 5:/j1ZRXjnDQxPy84+KdOMYWM2pDK0RDgeuSIo8LuelGcxjlVMCAWKIWF4iQptPzyeqOMIP/9u4ph8LHdWZ2cBiIBqShi1UZCQItVXpx7iKNqZZM3ELIIznHhMhfTfLLI/zbGDsDGqV5sVv4V0ysduVj3QYqvXU5hb4+M7mqlJ8rk=; 24:5kxY4KNlHmFW2frjddvUlAU0lXOXMcdKyLven0D6RMAa9uq3baQ/qvOxnkwqw1Kt0hBV6AukiPr/+Tnel9wSr0LFWj8NWb5T7ylmYJ6Gi/A= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN7PR15MB2385; 7:5TjTNmN+uH5Hy6qVU4Oi9orRAlsnjZoj1dYYiAUyf+b754JRvOdoTGJROfDUhwabMhVGieUm1CyBvtmltWHvAVb3yR5H8UTstELQJFD7uR5P0p/FWezX5BDKc1I0+vPf2tdGQpyHTY+Or5jv5OXLUPe/bnz67S5zKpwfzEeOxOIujnMAGm3CbAbEfCXm6XwFXiswCDGieudBzuMedCr7X4OO2r9ZW6eqLl0Uk+hsFGYIgvd7i2VOyMb6nC6YP5Qn X-MS-Office365-Filtering-Correlation-Id: 3324ab8d-66a4-4614-7ef2-08d5bcf88e50 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2018 19:50:06.3657 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3324ab8d-66a4-4614-7ef2-08d5bcf88e50 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR15MB2385 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes On 2018-05-18 03:14 PM, Simon Marchi wrote: > On 2018-05-18 15:03, Joel Brobecker wrote: >> Right, which is why I formulated this as a question. I don't really >> know what style we want there. But since it was easy to patch the >> script, I thought I'd send that right away, to show one of the options. >> But I'd be OK with deciding that unittests/ should follow the GDB >> coding standards. > > I think we can just add the /* ARI: ... */ comments, I'll try it later.  I don't see any reason why it would be harder in general to follow our code conventions in unit tests than anywhere else.  This case is just a bit of a special one. Here's what I pushed: From 1d143c36eedc0f0b124e6aa6fb3b98b1e6ff74b0 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Fri, 18 May 2018 15:47:56 -0400 Subject: [PATCH] format_pieces-selftests.c: Silence ARI warnings Silence this: unittests/format_pieces-selftests.c:51: warning: code: Do not use printf("%ll"), instead use printf("%s",phex()) to dump a `long long' value unittests/format_pieces-selftests.c:56: warning: code: Do not use printf("%ll"), instead use printf("%s",phex()) to dump a `long long' value gdb/ChangeLog: * unittests/format_pieces-selftests.c (test_format_specifier): Add ARI comments. --- gdb/ChangeLog | 5 +++++ gdb/unittests/format_pieces-selftests.c | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index d4d00f8..57edb23 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2018-05-18 Simon Marchi + + * unittests/format_pieces-selftests.c (test_format_specifier): + Add ARI comments. + 2018-05-18 Tom Tromey * c-typeprint.c (maybe_print_hole): New function. diff --git a/gdb/unittests/format_pieces-selftests.c b/gdb/unittests/format_pieces-selftests.c index 6d11a9c..8f63247 100644 --- a/gdb/unittests/format_pieces-selftests.c +++ b/gdb/unittests/format_pieces-selftests.c @@ -48,12 +48,12 @@ test_escape_sequences () static void test_format_specifier () { - check ("Hello %d%llx%%d", + check ("Hello %d%llx%%d", /* ARI: %ll */ { format_piece ("Hello ", literal_piece), format_piece ("%d", int_arg), format_piece ("", literal_piece), - format_piece ("%llx", long_long_arg), + format_piece ("%llx", long_long_arg), /* ARI: %ll */ format_piece ("%%d", literal_piece), }); }