New ARI warning Sun Sep 22 01:58:01 UTC 2019

Message ID 4e3f56b0-2a7d-f116-6837-2066a0c90e3f@simark.ca
State New, archived
Headers

Commit Message

Simon Marchi Sept. 22, 2019, 2:15 a.m. UTC
  On 2019-09-21 9:58 p.m., GDB Administrator wrote:
> 492a493
>> gdb/solib-svr4.c:3232: code: OP eol: Do not use &&, or || at the end of a line
> gdb/solib-svr4.c:3232:      if (abfd != nullptr &&

I pushed this patch to fix it.

From 7ab78ccbbb0d0918c293ade07bea59d789ea7d63 Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@polymtl.ca>
Date: Sat, 21 Sep 2019 22:13:49 -0400
Subject: [PATCH] gdb: fix formatting in solib-svr4.c

gdb/ChangeLog:

	* solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
	formatting.
---
 gdb/ChangeLog    | 5 +++++
 gdb/solib-svr4.c | 4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)
  

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 48f90186ffab..4374348c8df7 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@ 
+2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
+
+	* solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
+	formatting.
+
 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>

 	* breakpoint.h (bp_location) <inserted, permanent, duplicate>:
diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c
index dc635491058a..aa4af346b453 100644
--- a/gdb/solib-svr4.c
+++ b/gdb/solib-svr4.c
@@ -3229,8 +3229,8 @@  svr4_iterate_over_objfiles_in_search_order
       else
 	abfd = current_objfile->obfd;

-      if (abfd != nullptr &&
-	  scan_dyntag (DT_SYMBOLIC, abfd, nullptr, nullptr) == 1)
+      if (abfd != nullptr
+	  && scan_dyntag (DT_SYMBOLIC, abfd, nullptr, nullptr) == 1)
 	{
 	  checked_current_objfile = true;
 	  if (cb (current_objfile, cb_data) != 0)