diff mbox

Move gdbserver to top level

Message ID 4d5a1276-91aa-7197-5f90-854767987f73@suse.de
State New
Headers show

Commit Message

Tom de Vries Feb. 9, 2020, 2:17 p.m. UTC
On 09-02-2020 14:59, Tom de Vries wrote:
> On 03-02-2020 22:34, Tom Tromey wrote:
>> I'm going to push it tomorrow or the day after, unless there's some
>> objection.
> 
> Hi,
> 
> FYI, starting this commit, I'm running into:
> ...
> (gdb) PASS: gdb.multi/multi-target.exp: continue: non-stop=off: set
> remote-exec file in inferior 2
> spawn of  --once --multi localhost:2346 failed
> ERROR: tcl error sourcing
> /data/gdb_versions/devel/src/gdb/testsuite/gdb.multi/multi-target.exp.
> ERROR: Timeout waiting for gdbserver response.

Looking at other tests that use gdbserver, I guess this is missing:
...

...

[ It would be nice though if the gdbserver tests will work again, given
that I'm actually building gdbserver. ]

Thanks,
- Tom

Comments

Tom de Vries Feb. 10, 2020, 10:01 a.m. UTC | #1
On 09-02-2020 15:17, Tom de Vries wrote:
> [ It would be nice though if the gdbserver tests will work again, given
> that I'm actually building gdbserver. ]

Hmm, I noticed that also on the buildbot (
https://sourceware.org/ml/gdb-testers/2020-q1/msg03282.html ) we no
longer run the gdb.server tests:
...
Running
/home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.server/abspath.exp
...
testcase
/home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.server/abspath.exp
completed in 0 seconds

Running
/home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.server/bkpt-other-inferior.exp
...
testcase
/home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.server/bkpt-other-inferior.exp
completed in 0 seconds

Running
/home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.server/connect-stopped-target.exp
...
testcase
/home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.server/connect-stopped-target.exp
completed in 0 seconds
...

Thanks,
- Tom
Sergio Durigan Junior Feb. 10, 2020, 3:54 p.m. UTC | #2
On Monday, February 10 2020, Tom de Vries wrote:

> On 09-02-2020 15:17, Tom de Vries wrote:
>> [ It would be nice though if the gdbserver tests will work again, given
>> that I'm actually building gdbserver. ]
>
> Hmm, I noticed that also on the buildbot (
> https://sourceware.org/ml/gdb-testers/2020-q1/msg03282.html ) we no
> longer run the gdb.server tests:
> ...
> Running
> /home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.server/abspath.exp
> ...
> testcase
> /home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.server/abspath.exp
> completed in 0 seconds
>
> Running
> /home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.server/bkpt-other-inferior.exp
> ...
> testcase
> /home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.server/bkpt-other-inferior.exp
> completed in 0 seconds
>
> Running
> /home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.server/connect-stopped-target.exp
> ...
> testcase
> /home/gdb-buildbot-2/fedora-x86-64-2/fedora-x86-64/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.server/connect-stopped-target.exp
> completed in 0 seconds
> ...

I wonder why...  We build GDB from scratch on every build.  Is there
anything special that needs to be done to run the gdbserver tests now?
Tom Tromey Feb. 12, 2020, 12:55 a.m. UTC | #3
>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:

Sergio> I wonder why...  We build GDB from scratch on every build.  Is there
Sergio> anything special that needs to be done to run the gdbserver tests now?

No, I just neglected to update the gdb test suite to find gdbserver in
the new spot.

I will send a patch momentarily.

Tom
Sergio Durigan Junior Feb. 12, 2020, 4:46 p.m. UTC | #4
On Tuesday, February 11 2020, Tom Tromey wrote:

>>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
>
> Sergio> I wonder why...  We build GDB from scratch on every build.  Is there
> Sergio> anything special that needs to be done to run the gdbserver tests now?
>
> No, I just neglected to update the gdb test suite to find gdbserver in
> the new spot.
>
> I will send a patch momentarily.

Thanks, Tom.
diff mbox

Patch

diff --git a/gdb/testsuite/gdb.multi/multi-target.exp
b/gdb/testsuite/gdb.multi/multi-target.exp
index 3588eb4d76..6c727b5e3b 100644
--- a/gdb/testsuite/gdb.multi/multi-target.exp
+++ b/gdb/testsuite/gdb.multi/multi-target.exp
@@ -17,6 +17,10 @@ 

 load_lib gdbserver-support.exp

+if { [skip_gdbserver_tests] } {
+    return 0
+}
+
 standard_testfile

 # The plain remote target can't do multiple inferiors.