[testsuite] Skip batch-preserve-term-settings.exp tests that cannot work on Windows
Commit Message
Here's another in my series of patches to clean up test results on
remote Windows host. OK to commit?
-Sandra
Comments
On 2019-08-13 6:18 p.m., Sandra Loosemore wrote:
> Here's another in my series of patches to clean up test results on
> remote Windows host. OK to commit?
>
> -Sandra
>
Thanks, this LGTM.
Simon
commit 9d18683821f58c98722626aa2b2672876b6f513a
Author: Sandra Loosemore <sandra@codesourcery.com>
Date: Tue Aug 13 14:43:59 2019 -0700
Skip batch-preserve-term-settings.exp tests that cannot work on Windows.
This group of tests assume that the gdb "shell" command launches a
POSIX-compliant shell supporting the PPID environment variable, which
is used to get gdb's pid for killing it from a remote_exec shell. But
on Windows host "shell" launches cmd.exe, which doesn't have an
equivalent query.
2019-08-13 Sandra Loosemore <sandra@codesourcery.com>
gdb/testsuite
* gdb.base/batch-preserve-term-settings.exp
(test_terminal_settings_preserved_after_sigterm): Skip on Windows.
@@ -1,3 +1,8 @@
+2019-08-13 Sandra Loosemore <sandra@codesourcery.com>
+
+ * gdb.base/batch-preserve-term-settings.exp
+ (test_terminal_settings_preserved_after_sigterm): Skip on Windows.
+
2019-08-13 Tom de Vries <tdevries@suse.de>
* gdb.gdb/selftest.exp (send ^C to child process again): Accept also
@@ -273,6 +273,13 @@ proc test_terminal_settings_preserved_after_sigterm { } {
global gdb_prompt
global shell_prompt_re
+ # On Windows, GDB's "shell" command spawns cmd.exe, which does not
+ # understand PPID. So we're out of luck even if the test harness
+ # uses a remote_exec shell with a working "kill" command.
+ if [ishost *-*-mingw*] {
+ return
+ }
+
if ![spawn_shell] {
return
}