From patchwork Tue Apr 28 15:33:29 2015
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: John Baldwin <jhb@freebsd.org>
X-Patchwork-Id: 6476
Received: (qmail 121191 invoked by alias); 28 Apr 2015 15:33:39 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>,
	<http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Delivered-To: mailing list gdb-patches@sourceware.org
Received: (qmail 121181 invoked by uid 89); 28 Apr 2015 15:33:38 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL, BAYES_00,
	SPF_HELO_PASS, SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: bigwig.baldwin.cx
Received: from bigwig.baldwin.cx (HELO bigwig.baldwin.cx) (96.47.65.170) by
	sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with
	(CAMELLIA256-SHA encrypted) ESMTPS; Tue, 28 Apr 2015 15:33:32 +0000
Received: from ralph.baldwin.cx (pool-173-54-116-245.nwrknj.fios.verizon.net
	[173.54.116.245])	by bigwig.baldwin.cx (Postfix) with ESMTPSA
	id E3B81B93A; Tue, 28 Apr 2015 11:33:29 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>
Subject: Re: New ARI warning Tue Apr 28 01:54:12 UTC 2015
Date: Tue, 28 Apr 2015 11:33:29 -0400
Message-ID: <4578472.FfTsiG9exU@ralph.baldwin.cx>
User-Agent: KMail/4.14.2 (FreeBSD/10.1-STABLE; KDE/4.14.2; amd64; ; )
In-Reply-To: <20150428123125.GA4994@adacore.com>
References: <20150428015412.GA105793@sourceware.org>
	<20150428123125.GA4994@adacore.com>
MIME-Version: 1.0
X-IsSubscribed: yes

On Tuesday, April 28, 2015 08:31:25 AM Joel Brobecker wrote:
> John,
> 
> On Tue, Apr 28, 2015 at 01:54:13AM +0000, GDB Administrator wrote:
> > 169a170
> > > gdb/fbsd-nat.c:30: regression: wait.h: Do not include wait.h or sys/wait.h, instead include gdb_wait.h
> > gdb/fbsd-nat.c:30:#include <sys/wait.h>
> 
> Looking at the file that triggered this new warning, I'd guess
> this one comes from one of your changes. It might make a little
> less sense in a -nat file to follow that rule, but I don't think
> it'd hurt, and this would avoid increasing the number of ARI hits.
> Would you mind fixing, please?

Not at all, does this look ok?

Use "gdb_wait.h" instead of <sys/wait.h>.

gdb/ChangeLog:
	* fbsd-nat.c: Include "gdb_wait.h" instead of <sys/wait.h>.

diff --git a/gdb/fbsd-nat.c b/gdb/fbsd-nat.c
index 066e288..9705d45 100644
--- a/gdb/fbsd-nat.c
+++ b/gdb/fbsd-nat.c
@@ -23,11 +23,11 @@
 #include "regcache.h"
 #include "regset.h"
 #include "gdbthread.h"
+#include "gdb_wait.h"
 #include <sys/types.h>
 #include <sys/procfs.h>
 #include <sys/ptrace.h>
 #include <sys/sysctl.h>
-#include <sys/wait.h>
 #ifdef HAVE_KINFO_GETVMMAP
 #include <sys/user.h>
 #include <libutil.h>